Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44634 )
Change subject: mb/google/zork: support custom WiFi SAR for morphius ......................................................................
Patch Set 3:
(2 comments)
make[1]: *** No rule to make target 'src/mainboard/google/zork/wifi_sar_defaults.hex'
I put some suggestions in comments on how to make this work.
https://review.coreboot.org/c/coreboot/+/44634/3/src/mainboard/google/zork/K... File src/mainboard/google/zork/Kconfig:
https://review.coreboot.org/c/coreboot/+/44634/3/src/mainboard/google/zork/K... PS3, Line 260: bool "Enable SAR options for Chrome OS build" By not making things default to 'y' would follow how hatch and drallion implemented it. We'd put that selection into the chromium sys-boot/coreboot/files/config.X files for selecting it as well as setting WIFI_SAR_CBFS_FILEPATH to the correct file path during build.
https://review.coreboot.org/c/coreboot/+/44634/3/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/morphius/variant.c:
https://review.coreboot.org/c/coreboot/+/44634/3/src/mainboard/google/zork/v... PS3, Line 9: return filename; Just return "wifi_sar-morphius.hex". But I think the better option would be to make this string a Kconfig option. Then a common piece of code could just 'return CONFIG_WIFI_WAR_CBFS_FILENAME;'