[coreboot-gerrit] Change in coreboot[master]: vboot: create board-specific test-only GBB HWID if not set

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35634 )

Change subject: vboot: create board-specific test-only GBB HWID if not set
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35634/1/src/security/vboot/gen_hwid... 
File src/security/vboot/gen_hwid.sh:

https://review.coreboot.org/c/coreboot/+/35634/1/src/security/vboot/gen_hwid... 
PS1, Line 38: crc="$(python -c "import zlib, sys; sys.stdout.write(\
> Why don't we let futility calculate the checksum based on the input string?

Like said, the vboot does not define how HWID should look like. It only expects a string.
It is Chrome OS browser that expects a string following HWID v2 CRC, or HWID v3/v4/... etc.

Unless you're suggesting to make a "calculate CRC32" general function (not for hwid), otherwise it'll be adding a deprecated feature, or breaking all HWID v3/v4 systems.