Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45568 )
Change subject: drivers/tpm: Implement full PPI
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45568/6/src/drivers/tpm/ppi.c
File src/drivers/tpm/ppi.c:
https://review.coreboot.org/c/coreboot/+/45568/6/src/drivers/tpm/ppi.c@83
PS6, Line 83: * Check if we have TPM1.2 but a TPM2 PPI function was called
: * or if we have TPM2.0 but a TPM1.2 PPI function was called.
: */
This comment looks crooked
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45568
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifffe1d9b715e2c37568e1b009e86c298025c89ac
Gerrit-Change-Number: 45568
Gerrit-PatchSet: 7
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 16 Dec 2020 16:56:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment