Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42846 )
Change subject: soc/amd/picasso: add NULL-pointer check to root_complex_fill_ssdt ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42846/1/src/soc/amd/picasso/root_co... File src/soc/amd/picasso/root_complex.c:
https://review.coreboot.org/c/coreboot/+/42846/1/src/soc/amd/picasso/root_co... PS1, Line 139: printk(BIOS_ERR, "Error: %s device is NULL.\n", __func__);
I'd avoid mentioning `Error` in the log message: […]
Done
https://review.coreboot.org/c/coreboot/+/42846/1/src/soc/amd/picasso/root_co... PS1, Line 163: .acpi_fill_ssdt = root_complex_fill_ssdt,
Doesn't this guarantee that `device` will never be null?
it should. i still prefer having a bit too much error handling that lacking proper error handling and i also don't think that this will create too much additional overhead