Attention is currently required from: Kevin Chiu, Bhanu Prakash Maiya, Rob Barnes.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60265 )
Change subject: mb/google/guybrush/var/nipperkin: turn on WLAN ASPM L1ss
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/guybrush/variants/nipperkin/variant.c:
https://review.coreboot.org/c/coreboot/+/60265/comment/34da9967_7870b811
PS3, Line 10: true
Isn't this dependent on the board id? Also the latest board still requires false unless the rework was completed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/60265
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie1f295eaa57af7c2942e1807b3a0c4dcd89cd696
Gerrit-Change-Number: 60265
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Attention: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Comment-Date: Tue, 04 Jan 2022 17:47:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment