Attention is currently required from: Jason Glenesk, Raul Rangel, Furquan Shaikh, Marshall Dawson.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57051 )
Change subject: mb/google/guybrush: Use register and bit defines for eSPI setup
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
should i add a comment about the bit definitions of LPC_LDRQ0_PU_EN and LPC_LDRQ0_PD_EN that were swapped between picasso and cezanne near the code that sets/clears those bits, so that if anyone ever decides to port this functionality back to picasso won't run into problems? my plan is to factor out this functionality and move it to soc/amd/cezanne in a follow up patch and i could add the comment there then
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57051
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2d74ed3b9b4984ab1e2a22c50375baf9c9589df0
Gerrit-Change-Number: 57051
Gerrit-PatchSet: 3
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Comment-Date: Mon, 11 Oct 2021 14:01:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment