Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36098 )
Change subject: mb/google/hatch/var/dratini: Update DPTF parameters
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/36098/1/src/mainboard/google/hatch/...
File src/mainboard/google/hatch/variants/dratini/include/variant/acpi/dptf.asl:
https://review.coreboot.org/c/coreboot/+/36098/1/src/mainboard/google/hatch/...
PS1, Line 96: /* CPU Throttle Effect on CPU (TSR1) */
: Package () { _SB.PCI0.TCPU, _SB.DPTF.TSR1, 100, 60, 0, 0, 0, 0 },
Just to make sure, you want the 5V thermal sensor to throttle CPU as if it's the CPU thermal sensor? I haven't looked at the layout.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36098
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5da8d373f38d23929ffec95bc1c9e942f131297f
Gerrit-Change-Number: 36098
Gerrit-PatchSet: 1
Gerrit-Owner: Chen Wisley
wisley.chen@quantatw.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Comment-Date: Thu, 17 Oct 2019 15:21:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment