Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43495 )
Change subject: soc/amd/picasso: Configure ACP_PME_EN and ACP_I2S_WAKE_EN ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43495/4/src/soc/amd/picasso/acp.c File src/soc/amd/picasso/acp.c:
https://review.coreboot.org/c/coreboot/+/43495/4/src/soc/amd/picasso/acp.c@3... PS4, Line 38: write32((void *)(bar + ACP_PME_EN), !!cfg->acpi_pme_enable);
We should technically be doing a r-m-w since the other bits are marked 'reserved'.
Makes sense. I kept it as write32 since the other bits come out of reset as 0. But, I agree doing a r-m-w would be more appropriate.