EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48111 )
Change subject: mb/google/brya: Enable building for Chrome OS ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48111/3/src/mainboard/google/brya/M... File src/mainboard/google/brya/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/48111/3/src/mainboard/google/brya/M... PS3, Line 2: bootblock-$(CONFIG_CHROMEOS) += chromeos.c
not used in bootblock
This confused me as well. Agree!
https://review.coreboot.org/c/coreboot/+/48111/3/src/mainboard/google/brya/c... File src/mainboard/google/brya/chromeos.c:
https://review.coreboot.org/c/coreboot/+/48111/3/src/mainboard/google/brya/c... PS3, Line 12: {-1, ACTIVE_HIGH, get_write_protect_state(), "write protect"},
not necessary anymore, see CB:39318
Yes, I forgot this.