Attention is currently required from: Furquan Shaikh, zanxi chen, Henry Sun, Tao Xia.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52315 )
Change subject: mb/google/dedede/var/storo:Add P-sensor for storo
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/dedede/variants/storo/gpio.c:
https://review.coreboot.org/c/coreboot/+/52315/comment/3f99669f_c92d55e0
PS1, Line 22: INT
Yes. The same P-sensor sx9324 has been used on the "boten" variant.
Boten definitely has configured this GPIO differently. I am wondering why now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52315
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia2df1a227b04688a6b98384cd3a4e63023c0c1d9
Gerrit-Change-Number: 52315
Gerrit-PatchSet: 1
Gerrit-Owner: zanxi chen
chenzanxi@huaqin.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jessie Xu
xuyanan@huaqin.corp-partner.google.com
Gerrit-CC: Jinfang Mao
maojinfang@huaqin.corp-partner.google.com
Gerrit-CC: Tao Xia
xiatao5@huaqin.corp-partner.google.com
Gerrit-CC: Weimin Wu
wuweimin@huaqin.corp-partner.google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: zanxi chen
chenzanxi@huaqin.corp-partner.google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Tao Xia
xiatao5@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Thu, 15 Apr 2021 07:25:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tao Xia
xiatao5@huaqin.corp-partner.google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment