[coreboot-gerrit] Change in coreboot[master]: sb/intel/lynxpoint/acpi/gpio.asl: Convert to ASL 2.0

[Angel Pons (Code Review)]

Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/50329 )

Change subject: sb/intel/lynxpoint/acpi/gpio.asl: Convert to ASL 2.0
......................................................................

sb/intel/lynxpoint/acpi/gpio.asl: Convert to ASL 2.0

Change-Id: I37d6cf75ee5a5cb2ff92c89178cd4469dc059403
Signed-off-by: Elyes HAOUAS 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/50329
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
---
M src/southbridge/intel/lynxpoint/acpi/gpio.asl
1 file changed, 8 insertions(+), 7 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/src/southbridge/intel/lynxpoint/acpi/gpio.asl b/src/southbridge/intel/lynxpoint/acpi/gpio.asl
index 358bdec..2e432ad 100644
--- a/src/southbridge/intel/lynxpoint/acpi/gpio.asl
+++ b/src/southbridge/intel/lynxpoint/acpi/gpio.asl
@@ -50,17 +50,18 @@
    Method (GWAK, 1, Serialized)
    {
    	// Local0 = GPIO Base Address
-		Store (GPBS & ~1, Local0)
+		Local0 = GPBS & ~1

// Local1 = BANK, Local2 = OFFSET
-		Divide (Arg0, 32, Local2, Local1)
+		Local2 = Arg0 % 32
+		Local1 = Arg0 / 32

//
    	// Set OWNER to ACPI
    	//

// Local3 = GPIOBASE + GPIO_OWN(BANK)
-		Store (Local0 + Local1 * 4, Local3)
+		Local3 = Local0 + Local1 * 4

// GPIO_OWN(BANK)
    	OperationRegion (IOWN, SystemIO, Local3, 4)
@@ -69,14 +70,14 @@
    	}

// GPIO_OWN[GPIO] = 0 (ACPI)
-		Store (GOWN & ~(1 << Local2), GOWN)
+		GOWN &= ~(1 << Local2)

//
    	// Set ROUTE to SCI
    	//

// Local3 = GPIOBASE + GPIO_ROUTE(BANK)
-		Store (Local0 + 0x30 + Local1 * 4, Local3)
+		Local3 = Local0 + 0x30 + Local1 * 4

// GPIO_ROUTE(BANK)
    	OperationRegion (IROU, SystemIO, Local3, 4)
@@ -85,14 +86,14 @@
    	}

// GPIO_ROUTE[GPIO] = 0 (SCI)
-		Store (GROU & ~(1 << Local2), GROU)
+		GROU &= ~(1 << Local2)

//
    	// Set GPnCONFIG to GPIO|INPUT|INVERT
    	//

// Local3 = GPIOBASE + GPnCONFIG0(GPIO)
-		Store (Local0 + 0x100 + Arg0 * 8, Local3)
+		Local3  = Local0 + 0x100 + Arg0 * 8

// GPnCONFIG(GPIO)
    	OperationRegion (GPNC, SystemIO, Local3, 8)