Maciej Matuszczyk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35864 )
Change subject: mb/lenovo/{t60,r60}: Add ThinkPad R60 support as variant board
......................................................................
Patch Set 55:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35864/51/Documentation/mainboard/le...
File Documentation/mainboard/lenovo/r60.md:
https://review.coreboot.org/c/coreboot/+/35864/51/Documentation/mainboard/le...
PS51, Line 30:
Is there anything that has *not* been tested?
Yes. The things like WWAN, Expresscard, CardBus, 56k modem,
https://review.coreboot.org/c/coreboot/+/35864/51/Documentation/mainboard/le...
PS51, Line 45: Sometimes it takes several second to run coreboot. Just wait for it
"several" is not what I would expect 20 seconds to be like.
Well it varies between 5-20. I suspect that capacitor. Have to get more reports.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35864
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibd9208a5eafd228f8eedbc8fb4f4eb9ed1932a14
Gerrit-Change-Number: 35864
Gerrit-PatchSet: 55
Gerrit-Owner: Maciej Matuszczyk
maccraft123mc@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Maciej Matuszczyk
maccraft123mc@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Peter Lemenkov
lemenkov@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 24 Oct 2019 17:13:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment