Attention is currently required from: Sean Rhodes, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58149 )
Change subject: soc/intel/*/me.c: Check more than PCI interface for printing ME info ......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/alderlake/me.c:
https://review.coreboot.org/c/coreboot/+/58149/comment/7fe53a6c_8101ae44 PS1, Line 103: !cse_is_hfs1_cws_normal() || : !cse_is_hfs1_com_normal() || : !cse_is_hfs1_com_soft_temp_disable()) : return;
Just realised your point! Think this would account for that? […]
Frankly speaking, I *always* want these printed in my logs. We have found CSME bugs before by having these in the logs. Also you're already reading HFS1 several times here in order to avoid printing it later. For example, maybe the CSE is accidentally in soft temp disable but you wanted it in normal (and so these register dumps could be helpful). What is the harm in always printing these?