17 Dec
2024
17 Dec
'24
4:34 p.m.
Attention is currently required from: Felix Held, Zheng Bao.
Bao Zheng has posted comments on this change by Bao Zheng. ( https://review.coreboot.org/c/coreboot/+/84338?usp=email )
Change subject: amdfwtool: Check fletcher of each header ......................................................................
Patch Set 3:
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/84338/comment/308973ba_ccd22581?usp... : PS1, Line 571: default: /* ISH */
hmm, the ISH table has its checksum where all other tables have the cookie field, so if we're unluck […]
It seems there isn't a way to identify the ISH.
--
To view, visit https://review.coreboot.org/c/coreboot/+/84338?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie7540386027c6449317e9b7c0b4fd22d09d4a3a3
Gerrit-Change-Number: 84338
Gerrit-PatchSet: 3
Gerrit-Owner: Bao Zheng fishbaozi@gmail.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 17 Dec 2024 14:34:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de