Attention is currently required from: Angel Pons.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46921 )
Change subject: cpu/intel/haswell: Add fast ramp voltage for Broadwell
......................................................................
Patch Set 15: Code-Review+2
(1 comment)
File src/cpu/intel/haswell/haswell.h:
https://review.coreboot.org/c/coreboot/+/46921/comment/b8bedb17_6639f744
PS15, Line 172: static inline u32 cpu_family_model(void)
: {
: return cpuid_eax(1) & 0x0fff0ff0;
: }
It does way more than I need, though.
Done. LGTM and worry about it later.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46921
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I03d9ff16bcaab9091bd723ce933aa3f2d71e29b9
Gerrit-Change-Number: 46921
Gerrit-PatchSet: 15
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 22 Jan 2021 19:30:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment