Attention is currently required from: Shelley Chen, Julius Werner.
Douglas Anderson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56901 )
Change subject: trogdor: Fix "TPM interrupt" lb_gpio to be ACTIVE_HIGH
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
"latched" means the line is edge triggered and the hardware will set an interrupt flag as soon as it […]
OK, makes sense! ...so something (presumably in coreboot) is in charge of setting whether this cares about rising edges, falling edges, or both and that's abstracted out from here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56901
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie1586b0e10b64df0712e28552411c4d540a7e457
Gerrit-Change-Number: 56901
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Douglas Anderson
dianders@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Mon, 16 Aug 2021 22:31:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Douglas Anderson
dianders@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment