Attention is currently required from: Michał Żygowski, Maciej Pijanowski, Christian Walter, Krystian Hebel.
Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68748 )
Change subject: [WIP] security/tpm: add TPM log format as per 2.0 spec
......................................................................
Patch Set 3:
(2 comments)
File src/security/tpm/tpm2_log_serialized.h:
https://review.coreboot.org/c/coreboot/+/68748/comment/466695ca_ccdad124
PS2, Line 51: uint32_t digest_count;
Please add a comment that this is hardcoded to 1 in current version.
Done
File src/security/tpm/tspi/log-tpm2.c:
https://review.coreboot.org/c/coreboot/+/68748/comment/491e294d_4e4f4f51
PS2, Line 42: static struct tcpa_table *tcpa_cbmem_init(void)
This is not TCPA, TCPA was the format for TPM1.2. […]
They can only be removed for all log formats or we'll have to add typedefs or implement each common function for each format. Can add a commit for renaming `tcpa_table` to `tpm_eventlog` or something first and then add new formats.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68748
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0fac386bebab1b7104378ae3424957c6497e84e1
Gerrit-Change-Number: 68748
Gerrit-PatchSet: 3
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Comment-Date: Wed, 26 Oct 2022 22:03:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-MessageType: comment