Attention is currently required from: Sean Rhodes, Patrick Rudolph, Arthur Heymans. Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62990 )
Change subject: drivers/smmstore: Move SMMSTORE block size to Kconfig ......................................................................
Patch Set 2:
(4 comments)
File src/drivers/smmstore/Kconfig:
https://review.coreboot.org/c/coreboot/+/62990/comment/b4a96eb5_eb9b1a3d PS2, Line 35: "SMMSTORE Block size" do we want this user overrideable?
https://review.coreboot.org/c/coreboot/+/62990/comment/7e7d7442_bb77e2fe PS2, Line 41: that use : 8MiB SPI's maybe 'have 8MiB ROM' or 'have 8MiB flash' ?
https://review.coreboot.org/c/coreboot/+/62990/comment/9bc9e4df_a77afe3b PS2, Line 42: it's not possible to align SMMSTORE to 64KiB due to xyz?
File src/include/smmstore.h:
https://review.coreboot.org/c/coreboot/+/62990/comment/0c967e99_bcecfafe PS2, Line 39: The Version 2 protocol separates the SMMSTORE into 64KiB blocks, each : * of which can be read/written/cleared in an independent manner. The : * data format isn't specified. See documentation page for more details. probably need to adjust this comment and the documentation as well