Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44645 )
Change subject: mb/google/dedede: Fix board specific CSE reset
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44645/1/src/mainboard/google/dedede...
File src/mainboard/google/dedede/mainboard.c:
https://review.coreboot.org/c/coreboot/+/44645/1/src/mainboard/google/dedede...
PS1, Line 18: outb(FULL_RST | SYS_RST, RST_CNT);
I wonder if this entire function should be moved to src/vendorcode/google/chromeos/ so that all main […]
That is much cleaner so that we don't have to replicate it multiple times. I will move it and define a Kconfig so that it can be enabled in the required mainboards.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44645
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I46a390c71e380328cd7fe70214df09553b2db75c
Gerrit-Change-Number: 44645
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 20 Aug 2020 21:47:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment