Attention is currently required from: Angel Pons, Dinesh Gehlot, Jayvik Desai, Paul Menzel.
Julius Werner has posted comments on this change by Jayvik Desai. ( https://review.coreboot.org/c/coreboot/+/83705?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: vc/google/chromeos: Enable eSOL config with libgfx and uGOP ......................................................................
Patch Set 20:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83705/comment/b6101f7c_d8e4d622?usp... : PS20, Line 15: Cq-Depend: CB:83769, CB:83770 This is a thing specific to the ChromeOS CI, it does not work here. In general, since coreboot is built from a single repo, there is no need for these sort of cross-repo dependency annotations. If you upload multiple patches in a patch series, the CI automatically understands that the later patches are dependent on the earlier ones. (In cases where you're depending on submodule code, you'll have to put the submodule uprev before or into the patch that depends on it.)
File src/vendorcode/google/chromeos/Kconfig:
https://review.coreboot.org/c/coreboot/+/83705/comment/1642968c_11092f35?usp... : PS20, Line 105: config CHROMEOS_ENABLE_ESOL Does this Kconfig actually do anything? I don't see it referenced anywhere?
Normally you should add Kconfigs together with the first piece of code that uses them.