Attention is currently required from: Nico Huber.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80647?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: soc/intel/common/lpc_lib: Demote printk for IO base value 0
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
If this function gets called with a 0 value, that's most likely a bug at the […]
so you would keep it as an error then?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80647?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I593f8e3c7eb9e877f89568fd63eabe12bb777f93
Gerrit-Change-Number: 80647
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Sun, 25 Feb 2024 19:32:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment