Attention is currently required from: Angel Pons, Máté Kukri, Paul Menzel, Varshit Pandya.
Leah Rowe has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81529?usp=email )
Change subject: mb/dell/optiplex_9020: Implement late HWM initialization
......................................................................
Patch Set 9:
(1 comment)
Patchset:
PS8:
Why was it not working, though? This shouldn't have resulted in coreboot failing to boot...
sorry, i should be clear: what i tested was an old version of the patch; in the old version, when an unknown chassis type is found, it calls die()
in the newer patch, mate turns off fan controls in that case. i'm about to test the newer patch.
nevertheless, both patches were wrong: it was reading the right gpio. i just tested mate's fix on top of the old patch (fix what gpio is read), which he also did in the new patch set, which i'm about to test. i'll reply soon with a comment saying yay or nay as to whether the current patch set is correct.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81529?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibdccd3fc7364e03e84ca606592928410624eed43
Gerrit-Change-Number: 81529
Gerrit-PatchSet: 9
Gerrit-Owner: Máté Kukri
kukri.mate@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Leah Rowe
leahleahrowerowe@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Attention: Máté Kukri
kukri.mate@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sun, 21 Apr 2024 20:44:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Máté Kukri
kukri.mate@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Leah Rowe
leahleahrowerowe@gmail.com
Gerrit-MessageType: comment