Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36216 )
Change subject: soc/intel: common,skl,cnl,icl: drop reserved mmio memory size calculation ......................................................................
Patch Set 6:
Patch Set 6:
sorry for being late in review.. what is the reason of dropping reverse API call ? what we are really wish to achieve here.
I do doubt ur test coverage, i mean did u really enable any reversed range like PRMRR, ME Stolen Memory, GDXC etc...the reason we wrote this function to know if FSP has reserved something without CB knowledge. existing code should hold good.
I do doubt ur test coverage, i mean did u really enable any reversed range like PRMRR
Yes, and it broke. See discussion, please
existing code should hold good.
No. See discussion.
Subrata, check the whole patch series, please. There are multiple problems that need to be solved by a) relying on FSP or b) Intel making FSP finally open source or c) Intel doing it's homework and documenting their stuff ;-) I prefer b, but I guess this won't happen, even though Raja Koduri claimed working on making it open which I suspect to be some marketing move :/