[coreboot-gerrit] [M] Change in coreboot[master]: mb/google/link: rework TP/TS ACPI to add support for new Windows I2C ...

[Matt DeVillier (Code Review)]

Attention is currently required from: CoolStar, Felix Singer, Martin Roth, Stefan Reinauer.

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76159?usp=email )

Change subject: mb/google/link: rework TP/TS ACPI to add support for new Windows I2C driver
......................................................................

Patch Set 4:

(1 comment)

File src/mainboard/google/link/acpi/mainboard.asl:

https://review.coreboot.org/c/coreboot/+/76159/comment/5e31fa2c_ef722a51 :
PS1, Line 14: // Trackpad Wake is GPIO12
            : 		Name(_PRW, Package() { BOARD_TRACKPAD_WAKE_GPIO, 0x03 } )
            :
> I don't know if it's worth it, but how about using a Kconfig option to decide which code should be u […]

well, there's no reason to make it either-or, since the two coexist without issue. And using a Kconfig would mean you could only have the TP/TS functional in one OS vs the other, which is not what we want here. As it is now, both OSes work without issue.