Attention is currently required from: Arthur Heymans, Julius Werner, Jérémy Compostella, Philipp Hug, Ron Minnich.
Nico Huber has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/83574?usp=email )
Change subject: Makefile.mk: Add a common link_stage function and use it
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83574/comment/2bd695b5_bd48cc4a?us… :
PS2, Line 16: - the x86 --oformat is dropped as it is not needed.
Would be nice to do this in smaller steps, e.g. one patch to drop --oformat,
one to drop LIBGCC_FILE_NAME_ (this one looks like a merge artifact after
switching to COMPILER_RT_ in November 2014 oO).
And now I just realized why we don't need the `--oformat`. It's because we
use separate toolchains now? i.e. the x86_64 one doesn't support i386 any
more. But wouldn't this break compiling with a host toolchain?
--
To view, visit https://review.coreboot.org/c/coreboot/+/83574?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I64f7686894c99732d06972e7ba327061db6d7c44
Gerrit-Change-Number: 83574
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Philipp Hug <philipp(a)hug.cx>
Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Philipp Hug <philipp(a)hug.cx>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com>
Gerrit-Comment-Date: Fri, 19 Jul 2024 09:34:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Matt DeVillier, Nico Huber, Paul Menzel.
Michał Żygowski has posted comments on this change by Michał Żygowski. ( https://review.coreboot.org/c/coreboot/+/83469?usp=email )
Change subject: superio/ite,mb: Switch to new ITE GPIO driver
......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83469/comment/e1150894_df6bcc27?us… :
PS2, Line 11:
> not at all, please do
@paulepanter@mailbox.org I think we can resolve this one?
--
To view, visit https://review.coreboot.org/c/coreboot/+/83469?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I707ee090ee2551b4935847e12ade678d36ff9302
Gerrit-Change-Number: 83469
Gerrit-PatchSet: 5
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Fri, 19 Jul 2024 09:31:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu.
Hello Hung-Te Lin, Yidi Lin, Yu-Ping Wu, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83572?usp=email
to look at the new patch set (#4).
Change subject: soc/mediatek/mt8196: Add a stub implementation of the MT8196 SoC
......................................................................
soc/mediatek/mt8196: Add a stub implementation of the MT8196 SoC
Add new folder and basic drivers for Mediatek SoC 'MT8196'.
This patch also enables UART and ARM arch timer.
TEST=saw the coreboot uart log to bootblock
BUG=b:317009620
Change-Id: I8190253ed000db879b04a806ca0bdf29c14be806
Signed-off-by: Jarried Lin <jarried.lin(a)mediatek.corp-partner.google.com>
---
A src/soc/mediatek/mt8196/Kconfig
A src/soc/mediatek/mt8196/Makefile.mk
A src/soc/mediatek/mt8196/bootblock.c
A src/soc/mediatek/mt8196/emi.c
A src/soc/mediatek/mt8196/include/soc/addressmap.h
A src/soc/mediatek/mt8196/include/soc/emi.h
A src/soc/mediatek/mt8196/include/soc/memlayout.ld
A src/soc/mediatek/mt8196/include/soc/pll.h
A src/soc/mediatek/mt8196/include/soc/spi.h
A src/soc/mediatek/mt8196/include/soc/timer.h
A src/soc/mediatek/mt8196/soc.c
A src/soc/mediatek/mt8196/spi.c
A src/soc/mediatek/mt8196/timer.c
13 files changed, 328 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/83572/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/83572?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8190253ed000db879b04a806ca0bdf29c14be806
Gerrit-Change-Number: 83572
Gerrit-PatchSet: 4
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Attention is currently required from: Michał Żygowski, Nico Huber, Paul Menzel.
Hello Matt DeVillier, Nico Huber, Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/83469?usp=email
to look at the new patch set (#5).
Change subject: superio/ite,mb: Switch to new ITE GPIO driver
......................................................................
superio/ite,mb: Switch to new ITE GPIO driver
Refactor mainboards' code to use the new GPIO driver.
TEST=Put Google Jecht to S3 sleep and check if the LED blinks.
Change-Id: I707ee090ee2551b4935847e12ade678d36ff9302
Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Tested-by: Matt DeVillier <matt.devillier(a)gmail.com>
---
M src/mainboard/google/beltino/variants/mccloud/led.c
M src/mainboard/google/beltino/variants/tricky/led.c
M src/mainboard/google/jecht/led.c
M src/mainboard/hp/pro_3500_series/led.c
M src/mainboard/samsung/stumpy/early_init.c
M src/mainboard/samsung/stumpy/smihandler.c
6 files changed, 72 insertions(+), 61 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/83469/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/83469?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I707ee090ee2551b4935847e12ade678d36ff9302
Gerrit-Change-Number: 83469
Gerrit-PatchSet: 5
Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Attention is currently required from: Arthur Heymans, Felix Singer, Jérémy Compostella.
Nico Huber has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/83563?usp=email )
Change subject: arch/x86/Makefile.mk: Remove obsolete romcc reference
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83563/comment/dce3d7c3_849bbc73?us… :
PS2, Line 9: No assembly.inc file is being generated by romcc anymore.
Please also mention "The `-I.` was only used in a single place that
can use the common `-Isrc` instead.".
--
To view, visit https://review.coreboot.org/c/coreboot/+/83563?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I57a3a6e1c2cf7cf30fb0cd94cc8455f715050490
Gerrit-Change-Number: 83563
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Fri, 19 Jul 2024 09:21:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: Arthur Heymans, Jérémy Compostella.
Nico Huber has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/83562?usp=email )
Change subject: arch/x86: Build all stages using the same function
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File src/arch/x86/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/83562/comment/416917aa_671eb288?us… :
PS1, Line 314: # The rmodule_link definition creates an elf file with .rmod extension.
> > Why drop this? […]
Oh, right, it's using an implicit rule now...
--
To view, visit https://review.coreboot.org/c/coreboot/+/83562?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I458c7c6822b310847e7ab32519fd8d66a90f88f7
Gerrit-Change-Number: 83562
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Fri, 19 Jul 2024 09:16:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Attention is currently required from: Arthur Heymans.
Nico Huber has posted comments on this change by Arthur Heymans. ( https://review.coreboot.org/c/coreboot/+/71910?usp=email )
Change subject: arch/x86: Link ramstage in one step
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/71910?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3b23d86e604229262d7c762e23bb963a0e944b5d
Gerrit-Change-Number: 71910
Gerrit-PatchSet: 4
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Jérémy Compostella <jeremy.compostella(a)intel.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Comment-Date: Fri, 19 Jul 2024 09:14:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/83572?usp=email )
Change subject: soc/mediatek/mt8196: Add a stub implementation of the MT8196 SoC
......................................................................
Patch Set 3:
(4 comments)
File src/soc/mediatek/mt8196/Kconfig:
https://review.coreboot.org/c/coreboot/+/83572/comment/5bd6ab54_6a6183bb?us… :
PS1, Line 1: config SOC_MEDIATEK_MT8196
> add SPDX identifier.
Done
File src/soc/mediatek/mt8196/soc.c:
https://review.coreboot.org/c/coreboot/+/83572/comment/f803ca2d_c7eb4fa6?us… :
PS2, Line 5: #include <symbols.h>
> I think we need CB:83570 before this patch to have symbols.h.
Acknowledged
File src/soc/mediatek/mt8196/timer.c:
https://review.coreboot.org/c/coreboot/+/83572/comment/0d55f397_47478ed2?us… :
PS1, Line 6: #include <soc/timer_common.h>
> no need
Done
https://review.coreboot.org/c/coreboot/+/83572/comment/05afd5ea_e1fdd581?us… :
PS1, Line 10: timer_prepare();
> remove
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/83572?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8190253ed000db879b04a806ca0bdf29c14be806
Gerrit-Change-Number: 83572
Gerrit-PatchSet: 3
Gerrit-Owner: Jarried Lin <jarried.lin(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidilin(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Attention: Yidi Lin <yidilin(a)google.com>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Fri, 19 Jul 2024 09:14:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin <yidilin(a)google.com>
Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com>