Attention is currently required from: Matt DeVillier, Nick Vaccaro, Subrata Banik.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80177?usp=email )
Change subject: mb/google/hatch/var/jinlon: Use name 'LCD0' for internal panel output
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80177?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4204a518876bed38584260f7566d4d6c9aaa042f
Gerrit-Change-Number: 80177
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Tue, 13 Feb 2024 19:05:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80174?usp=email )
Change subject: mb/google/brya/var/*: Use name 'LCD0' for internal panel output
......................................................................
mb/google/brya/var/*: Use name 'LCD0' for internal panel output
The GMA driver generates the brightness controls expecting the name
LCD0, so we need to use it here as well so that the DSDT and SSDT
parts match.
TEST=build/boot Win11 on google/brya (redrix), verify brightness
controls are functional.
Change-Id: I389553b2ddc5b09d165229e2d8066cacf852b82c
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80174
Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Reviewed-by: Won Chung <wonchung(a)google.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Martin L Roth <gaumless(a)gmail.com>
Reviewed-by: Eric Lai <ericllai(a)google.com>
---
M src/mainboard/google/brya/variants/anahera/overridetree.cb
M src/mainboard/google/brya/variants/anahera4es/overridetree.cb
M src/mainboard/google/brya/variants/anraggar/overridetree.cb
M src/mainboard/google/brya/variants/banshee/overridetree.cb
M src/mainboard/google/brya/variants/brya0/overridetree.cb
M src/mainboard/google/brya/variants/crota/overridetree.cb
M src/mainboard/google/brya/variants/dochi/overridetree.cb
M src/mainboard/google/brya/variants/felwinter/overridetree.cb
M src/mainboard/google/brya/variants/gimble/overridetree.cb
M src/mainboard/google/brya/variants/gimble4es/overridetree.cb
M src/mainboard/google/brya/variants/kano/overridetree.cb
M src/mainboard/google/brya/variants/marasov/overridetree.cb
M src/mainboard/google/brya/variants/mithrax/overridetree.cb
M src/mainboard/google/brya/variants/omnigul/overridetree.cb
M src/mainboard/google/brya/variants/osiris/overridetree.cb
M src/mainboard/google/brya/variants/primus/overridetree.cb
M src/mainboard/google/brya/variants/redrix/overridetree.cb
M src/mainboard/google/brya/variants/redrix4es/overridetree.cb
M src/mainboard/google/brya/variants/skolas/overridetree.cb
M src/mainboard/google/brya/variants/skolas4es/overridetree.cb
M src/mainboard/google/brya/variants/taeko/overridetree.cb
M src/mainboard/google/brya/variants/taeko4es/overridetree.cb
M src/mainboard/google/brya/variants/taniks/overridetree.cb
M src/mainboard/google/brya/variants/vell/overridetree.cb
M src/mainboard/google/brya/variants/volmar/overridetree.cb
25 files changed, 29 insertions(+), 29 deletions(-)
Approvals:
Won Chung: Looks good to me, but someone else must approve
Martin L Roth: Looks good to me, approved
build bot (Jenkins): Verified
Felix Singer: Looks good to me, approved
Eric Lai: Looks good to me, approved
diff --git a/src/mainboard/google/brya/variants/anahera/overridetree.cb b/src/mainboard/google/brya/variants/anahera/overridetree.cb
index 1961e09..352a7d1 100644
--- a/src/mainboard/google/brya/variants/anahera/overridetree.cb
+++ b/src/mainboard/google/brya/variants/anahera/overridetree.cb
@@ -89,7 +89,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Use ChromeOS privacy screen _HID
register "device[0].hid" = ""GOOG0010""
# Internal panel on the first port of the graphics chip
@@ -117,7 +117,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/anahera4es/overridetree.cb b/src/mainboard/google/brya/variants/anahera4es/overridetree.cb
index c7cce88..6973854 100644
--- a/src/mainboard/google/brya/variants/anahera4es/overridetree.cb
+++ b/src/mainboard/google/brya/variants/anahera4es/overridetree.cb
@@ -71,7 +71,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Use ChromeOS privacy screen _HID
register "device[0].hid" = ""GOOG0010""
# Internal panel on the first port of the graphics chip
@@ -99,7 +99,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/anraggar/overridetree.cb b/src/mainboard/google/brya/variants/anraggar/overridetree.cb
index 0c584ee..5ea8747 100644
--- a/src/mainboard/google/brya/variants/anraggar/overridetree.cb
+++ b/src/mainboard/google/brya/variants/anraggar/overridetree.cb
@@ -191,7 +191,7 @@
chip drivers/gfx/generic
register "device_count" = "4"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/banshee/overridetree.cb b/src/mainboard/google/brya/variants/banshee/overridetree.cb
index 38c4528..6f66bce 100644
--- a/src/mainboard/google/brya/variants/banshee/overridetree.cb
+++ b/src/mainboard/google/brya/variants/banshee/overridetree.cb
@@ -98,7 +98,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/brya0/overridetree.cb b/src/mainboard/google/brya/variants/brya0/overridetree.cb
index a4a0ae5..876e874 100644
--- a/src/mainboard/google/brya/variants/brya0/overridetree.cb
+++ b/src/mainboard/google/brya/variants/brya0/overridetree.cb
@@ -122,7 +122,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/crota/overridetree.cb b/src/mainboard/google/brya/variants/crota/overridetree.cb
index 8b671e1..69f78c1 100644
--- a/src/mainboard/google/brya/variants/crota/overridetree.cb
+++ b/src/mainboard/google/brya/variants/crota/overridetree.cb
@@ -111,7 +111,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/dochi/overridetree.cb b/src/mainboard/google/brya/variants/dochi/overridetree.cb
index 880b7bc..461a7ad 100644
--- a/src/mainboard/google/brya/variants/dochi/overridetree.cb
+++ b/src/mainboard/google/brya/variants/dochi/overridetree.cb
@@ -91,7 +91,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/felwinter/overridetree.cb b/src/mainboard/google/brya/variants/felwinter/overridetree.cb
index 74f2114..28e0974 100644
--- a/src/mainboard/google/brya/variants/felwinter/overridetree.cb
+++ b/src/mainboard/google/brya/variants/felwinter/overridetree.cb
@@ -97,7 +97,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/gimble/overridetree.cb b/src/mainboard/google/brya/variants/gimble/overridetree.cb
index 0de70e5..ed8027d 100644
--- a/src/mainboard/google/brya/variants/gimble/overridetree.cb
+++ b/src/mainboard/google/brya/variants/gimble/overridetree.cb
@@ -78,7 +78,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/gimble4es/overridetree.cb b/src/mainboard/google/brya/variants/gimble4es/overridetree.cb
index 6351248..881c1a1 100644
--- a/src/mainboard/google/brya/variants/gimble4es/overridetree.cb
+++ b/src/mainboard/google/brya/variants/gimble4es/overridetree.cb
@@ -43,7 +43,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/kano/overridetree.cb b/src/mainboard/google/brya/variants/kano/overridetree.cb
index cbce022..aeb8ef2 100644
--- a/src/mainboard/google/brya/variants/kano/overridetree.cb
+++ b/src/mainboard/google/brya/variants/kano/overridetree.cb
@@ -100,7 +100,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/marasov/overridetree.cb b/src/mainboard/google/brya/variants/marasov/overridetree.cb
index 64ca6a7..5a266dd 100644
--- a/src/mainboard/google/brya/variants/marasov/overridetree.cb
+++ b/src/mainboard/google/brya/variants/marasov/overridetree.cb
@@ -145,7 +145,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/mithrax/overridetree.cb b/src/mainboard/google/brya/variants/mithrax/overridetree.cb
index 6df9b60..55026ae 100644
--- a/src/mainboard/google/brya/variants/mithrax/overridetree.cb
+++ b/src/mainboard/google/brya/variants/mithrax/overridetree.cb
@@ -95,7 +95,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/omnigul/overridetree.cb b/src/mainboard/google/brya/variants/omnigul/overridetree.cb
index 1801672..efe56a7 100644
--- a/src/mainboard/google/brya/variants/omnigul/overridetree.cb
+++ b/src/mainboard/google/brya/variants/omnigul/overridetree.cb
@@ -134,7 +134,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/osiris/overridetree.cb b/src/mainboard/google/brya/variants/osiris/overridetree.cb
index 0c21a61..72981cf 100644
--- a/src/mainboard/google/brya/variants/osiris/overridetree.cb
+++ b/src/mainboard/google/brya/variants/osiris/overridetree.cb
@@ -74,7 +74,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/primus/overridetree.cb b/src/mainboard/google/brya/variants/primus/overridetree.cb
index d815587..7dde42f 100644
--- a/src/mainboard/google/brya/variants/primus/overridetree.cb
+++ b/src/mainboard/google/brya/variants/primus/overridetree.cb
@@ -86,7 +86,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/redrix/overridetree.cb b/src/mainboard/google/brya/variants/redrix/overridetree.cb
index f8502aa..1fe1682 100644
--- a/src/mainboard/google/brya/variants/redrix/overridetree.cb
+++ b/src/mainboard/google/brya/variants/redrix/overridetree.cb
@@ -104,7 +104,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Use ChromeOS privacy screen _HID
register "device[0].hid" = ""GOOG0010""
# Internal panel on the first port of the graphics chip
@@ -132,7 +132,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/redrix4es/overridetree.cb b/src/mainboard/google/brya/variants/redrix4es/overridetree.cb
index 6e00215..b68dec2 100644
--- a/src/mainboard/google/brya/variants/redrix4es/overridetree.cb
+++ b/src/mainboard/google/brya/variants/redrix4es/overridetree.cb
@@ -85,7 +85,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Use ChromeOS privacy screen _HID
register "device[0].hid" = ""GOOG0010""
# Internal panel on the first port of the graphics chip
@@ -113,7 +113,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/skolas/overridetree.cb b/src/mainboard/google/brya/variants/skolas/overridetree.cb
index 3f17008..e3879bc 100644
--- a/src/mainboard/google/brya/variants/skolas/overridetree.cb
+++ b/src/mainboard/google/brya/variants/skolas/overridetree.cb
@@ -121,7 +121,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/skolas4es/overridetree.cb b/src/mainboard/google/brya/variants/skolas4es/overridetree.cb
index 326c675..7826ea8 100644
--- a/src/mainboard/google/brya/variants/skolas4es/overridetree.cb
+++ b/src/mainboard/google/brya/variants/skolas4es/overridetree.cb
@@ -116,7 +116,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
diff --git a/src/mainboard/google/brya/variants/taeko/overridetree.cb b/src/mainboard/google/brya/variants/taeko/overridetree.cb
index 27584cd..d6ffb7f 100644
--- a/src/mainboard/google/brya/variants/taeko/overridetree.cb
+++ b/src/mainboard/google/brya/variants/taeko/overridetree.cb
@@ -141,7 +141,7 @@
chip drivers/gfx/generic
register "device_count" = "3"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB is unused and HDMI is not enumerated in the kernel, so no GFX device is added for DDIB
diff --git a/src/mainboard/google/brya/variants/taeko4es/overridetree.cb b/src/mainboard/google/brya/variants/taeko4es/overridetree.cb
index 22b3ca7..753e7ba 100644
--- a/src/mainboard/google/brya/variants/taeko4es/overridetree.cb
+++ b/src/mainboard/google/brya/variants/taeko4es/overridetree.cb
@@ -122,7 +122,7 @@
chip drivers/gfx/generic
register "device_count" = "3"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB is unused and HDMI is not enumerated in the kernel, so no GFX device is added for DDIB
diff --git a/src/mainboard/google/brya/variants/taniks/overridetree.cb b/src/mainboard/google/brya/variants/taniks/overridetree.cb
index 1e0101a..a2d9512 100644
--- a/src/mainboard/google/brya/variants/taniks/overridetree.cb
+++ b/src/mainboard/google/brya/variants/taniks/overridetree.cb
@@ -118,7 +118,7 @@
chip drivers/gfx/generic
register "device_count" = "3"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB is unused and HDMI is not enumerated in the kernel, so no GFX device is added for DDIB
diff --git a/src/mainboard/google/brya/variants/vell/overridetree.cb b/src/mainboard/google/brya/variants/vell/overridetree.cb
index 6956312..459f782 100644
--- a/src/mainboard/google/brya/variants/vell/overridetree.cb
+++ b/src/mainboard/google/brya/variants/vell/overridetree.cb
@@ -97,7 +97,7 @@
chip drivers/gfx/generic
register "device_count" = "5"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB is unused and HDMI is not enumerated in the kernel, so no GFX device is added for DDIB
diff --git a/src/mainboard/google/brya/variants/volmar/overridetree.cb b/src/mainboard/google/brya/variants/volmar/overridetree.cb
index 1de6626..ef2da0a 100644
--- a/src/mainboard/google/brya/variants/volmar/overridetree.cb
+++ b/src/mainboard/google/brya/variants/volmar/overridetree.cb
@@ -92,7 +92,7 @@
chip drivers/gfx/generic
register "device_count" = "6"
# DDIA for eDP
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
# DDIB for HDMI
--
To view, visit https://review.coreboot.org/c/coreboot/+/80174?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I389553b2ddc5b09d165229e2d8066cacf852b82c
Gerrit-Change-Number: 80174
Gerrit-PatchSet: 5
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Won Chung <wonchung(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Kapil Porwal, Matt DeVillier, Nick Vaccaro, Subrata Banik.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80174?usp=email )
Change subject: mb/google/brya/var/*: Use name 'LCD0' for internal panel output
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80174?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I389553b2ddc5b09d165229e2d8066cacf852b82c
Gerrit-Change-Number: 80174
Gerrit-PatchSet: 4
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Won Chung <wonchung(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Comment-Date: Tue, 13 Feb 2024 19:04:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80176?usp=email )
Change subject: mb/google/drallion: Drop GMA default panel
......................................................................
mb/google/drallion: Drop GMA default panel
Redundant when generic gfx driver is used
Change-Id: I8ed1eede05f531f4c76e7fa168c2b92fae7e45cb
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80176
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Eric Lai <ericllai(a)google.com>
Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
---
M src/mainboard/google/drallion/variants/drallion/devicetree.cb
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Eric Lai: Looks good to me, approved
Felix Singer: Looks good to me, approved
build bot (Jenkins): Verified
diff --git a/src/mainboard/google/drallion/variants/drallion/devicetree.cb b/src/mainboard/google/drallion/variants/drallion/devicetree.cb
index 9fe0a69..eecdc00 100644
--- a/src/mainboard/google/drallion/variants/drallion/devicetree.cb
+++ b/src/mainboard/google/drallion/variants/drallion/devicetree.cb
@@ -220,7 +220,6 @@
device domain 0 on
device pci 00.0 on end # Host Bridge
device pci 02.0 on
- register "gfx" = "GMA_DEFAULT_PANEL(0)"
chip drivers/gfx/generic
register "device_count" = "1"
register "device[0].name" = ""LCD0""
--
To view, visit https://review.coreboot.org/c/coreboot/+/80176?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8ed1eede05f531f4c76e7fa168c2b92fae7e45cb
Gerrit-Change-Number: 80176
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Matt DeVillier.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80176?usp=email )
Change subject: mb/google/drallion: Drop GMA default panel
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80176?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8ed1eede05f531f4c76e7fa168c2b92fae7e45cb
Gerrit-Change-Number: 80176
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Comment-Date: Tue, 13 Feb 2024 19:03:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80175?usp=email )
Change subject: mb/google/drallion: Use name 'LCD0' for internal panel output
......................................................................
mb/google/drallion: Use name 'LCD0' for internal panel output
The GMA driver generates the brightness controls expecting the name
LCD0, so we need to use it here as well so that the DSDT and SSDT parts
match.
TEST=build/boot Win11 on google/drallion, verify brightness controls are
functional.
Change-Id: I6fbdd0c5606ec8f2c497e85bf46d388957f15fa5
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80175
Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Eric Lai <ericllai(a)google.com>
---
M src/mainboard/google/drallion/variants/drallion/devicetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
build bot (Jenkins): Verified
Felix Singer: Looks good to me, approved
Eric Lai: Looks good to me, approved
diff --git a/src/mainboard/google/drallion/variants/drallion/devicetree.cb b/src/mainboard/google/drallion/variants/drallion/devicetree.cb
index 950dab9..9fe0a69 100644
--- a/src/mainboard/google/drallion/variants/drallion/devicetree.cb
+++ b/src/mainboard/google/drallion/variants/drallion/devicetree.cb
@@ -223,7 +223,7 @@
register "gfx" = "GMA_DEFAULT_PANEL(0)"
chip drivers/gfx/generic
register "device_count" = "1"
- register "device[0].name" = ""LCD""
+ register "device[0].name" = ""LCD0""
# Address is set following the ACPI spec section A.3.2
# for an internal panel on the first port of the graphics chip
register "device[0].addr" = "0x80010400"
--
To view, visit https://review.coreboot.org/c/coreboot/+/80175?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6fbdd0c5606ec8f2c497e85bf46d388957f15fa5
Gerrit-Change-Number: 80175
Gerrit-PatchSet: 3
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Matt DeVillier.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80175?usp=email )
Change subject: mb/google/drallion: Use name 'LCD0' for internal panel output
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/80175?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6fbdd0c5606ec8f2c497e85bf46d388957f15fa5
Gerrit-Change-Number: 80175
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Eric Lai <ericllai(a)google.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Comment-Date: Tue, 13 Feb 2024 19:02:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: CoolStar, Matt DeVillier, Subrata Banik.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78040?usp=email )
Change subject: mb/google/puff: Hide LSPCON device from Windows
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/78040?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib646e01a337b8d7baf20a886c49a8cb64d6408f3
Gerrit-Change-Number: 78040
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: CoolStar <coolstarorganization(a)gmail.com>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: CoolStar <coolstarorganization(a)gmail.com>
Gerrit-Comment-Date: Tue, 13 Feb 2024 19:01:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Felix Singer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/80183?usp=email )
Change subject: mb/google/volteer/drobit: Add a board-specific VBT file
......................................................................
mb/google/volteer/drobit: Add a board-specific VBT file
Add a board-specific VBT file compatible with the latest FSP release
(requires VBT version 250).
TODO: Update all other volteer VBTs to v250 from v240.
TEST=build/boot google/volteer (drobit) with edk2 payload
Change-Id: Ie25a77be5204dfc8b888082492a285973843037c
Signed-off-by: Matt DeVillier <matt.devillier(a)gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/80183
Reviewed-by: Martin L Roth <gaumless(a)gmail.com>
Reviewed-by: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Nico Huber <nico.h(a)gmx.de>
---
M src/mainboard/google/volteer/Kconfig
A src/mainboard/google/volteer/variants/drobit/data.vbt
2 files changed, 2 insertions(+), 1 deletion(-)
Approvals:
Martin L Roth: Looks good to me, approved
build bot (Jenkins): Verified
Nico Huber: Looks good to me, but someone else must approve
Felix Singer: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/Kconfig b/src/mainboard/google/volteer/Kconfig
index 202d8f1..d1d5df0 100644
--- a/src/mainboard/google/volteer/Kconfig
+++ b/src/mainboard/google/volteer/Kconfig
@@ -180,7 +180,8 @@
config INTEL_GMA_VBT_FILE
default "src/mainboard/\$(MAINBOARDDIR)/variants/\$(VARIANT_DIR)/data.vbt" \
- if BOARD_GOOGLE_ELEMI || BOARD_GOOGLE_LINDAR || BOARD_GOOGLE_VOEMA
+ if BOARD_GOOGLE_ELEMI || BOARD_GOOGLE_LINDAR || \
+ BOARD_GOOGLE_VOEMA || BOARD_GOOGLE_DROBIT
default "src/mainboard/\$(MAINBOARDDIR)/variants/baseboard/data.vbt" if INTEL_GMA_HAVE_VBT
config MAINBOARD_DIR
diff --git a/src/mainboard/google/volteer/variants/drobit/data.vbt b/src/mainboard/google/volteer/variants/drobit/data.vbt
new file mode 100644
index 0000000..f066fbd
--- /dev/null
+++ b/src/mainboard/google/volteer/variants/drobit/data.vbt
Binary files differ
--
To view, visit https://review.coreboot.org/c/coreboot/+/80183?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie25a77be5204dfc8b888082492a285973843037c
Gerrit-Change-Number: 80183
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Singer <service+coreboot-gerrit(a)felixsinger.de>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged