- flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[main]: ichspi: Add RaptorPoint PCH support
by Michał Żygowski (Code Review) 05 Sep '24

05 Sep '24

Attention is currently required from: Anastasia Klimchuk, Krystian Hebel, Maciej Pijanowski, Michał Kopeć, Sergii Dmytruk. Michał Żygowski has uploaded a new patch set (#5) to the change originally created by Maciej Pijanowski. ( https://review.coreboot.org/c/flashrom/+/83854?usp=email ) Change subject: ichspi: Add RaptorPoint PCH support ...................................................................... ichspi: Add RaptorPoint PCH support Based on public Intel 700 Series PCH datasheet, DOC 743835 rev 004. The IDs of IoT chipset SKUs (ending with E) can only be found in "12th Gen Intel® Core™ Processors Family (Formerly Known as Alder Lake -S) for IoT Platforms External Design Specification (EDS) Addendum" DOC 634528 rev 2.7 (NDA). TEST=Probe flash on Z790 chipset. Run the ich_descriptors_tool and check output is correct as expected. Change-Id: I13ac52d5400c0e2260e12d605077fc2182c379ef Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> --- M chipset_enable.c M doc/release_notes/devel.rst M ich_descriptors.c M ichspi.c M include/programmer.h M util/ich_descriptors_tool/ich_descriptors_tool.c 6 files changed, 45 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/54/83854/5 -- To view, visit https://review.coreboot.org/c/flashrom/+/83854?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I13ac52d5400c0e2260e12d605077fc2182c379ef Gerrit-Change-Number: 83854 Gerrit-PatchSet: 5 Gerrit-Owner: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Filip Gołaś <filip.golas(a)3mdeb.com> Gerrit-CC: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>

1 0

[S] Change in flashrom[main]: ichspi: Add RaptorPoint PCH support
by Michał Żygowski (Code Review) 05 Sep '24

05 Sep '24

Attention is currently required from: Anastasia Klimchuk, Krystian Hebel, Maciej Pijanowski, Michał Kopeć, Sergii Dmytruk. Michał Żygowski has posted comments on this change by Maciej Pijanowski. ( https://review.coreboot.org/c/flashrom/+/83854?usp=email ) Change subject: ichspi: Add RaptorPoint PCH support ...................................................................... Patch Set 4: (1 comment) File chipset_enable.c: https://review.coreboot.org/c/flashrom/+/83854/comment/c9686b0d_d4ab1bc3?us… : PS4, Line 2209: {0x8086, 0x7a90, B_S, NT, "Intel", "R680E", enable_flash_pch600}, : {0x8086, 0x7a91, B_S, NT, "Intel", "Q670E", enable_flash_pch600}, : {0x8086, 0x7a92, B_S, NT, "Intel", "H610E", enable_flash_pch600} > Thanks for ref to the doc! I found one https://cdrdv2-public.intel.com/743835/743835-004.pdf […] The chipsets ending with 'E' are IoT SKUs. There is a different datasheet (or specification update) for them. Could not find the IDs in public datasheets (only chipset names are mentioned there withotu IDs). The IDs can be found only in "12th Gen Intel® Core™ Processors Family (Formerly Known as Alder Lake -S) for IoT Platforms External Design Specification (EDS) Addendum" DOC 634528 rev 2.7 (NDA) -- To view, visit https://review.coreboot.org/c/flashrom/+/83854?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I13ac52d5400c0e2260e12d605077fc2182c379ef Gerrit-Change-Number: 83854 Gerrit-PatchSet: 4 Gerrit-Owner: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Filip Gołaś <filip.golas(a)3mdeb.com> Gerrit-CC: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Thu, 05 Sep 2024 09:02:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: ichspi: Add RaptorPoint PCH support
by Anastasia Klimchuk (Code Review) 05 Sep '24

05 Sep '24

Attention is currently required from: Krystian Hebel, Maciej Pijanowski, Michał Kopeć, Michał Żygowski, Sergii Dmytruk. Anastasia Klimchuk has posted comments on this change by Maciej Pijanowski. ( https://review.coreboot.org/c/flashrom/+/83854?usp=email ) Change subject: ichspi: Add RaptorPoint PCH support ...................................................................... Patch Set 4: (4 comments) Patchset: PS3: > Added the relevant datasheet to the commit message. […] Done PS3: > Added Done File chipset_enable.c: https://review.coreboot.org/c/flashrom/+/83854/comment/1f2f6713_7a968aa5?us… : PS4, Line 2209: {0x8086, 0x7a90, B_S, NT, "Intel", "R680E", enable_flash_pch600}, : {0x8086, 0x7a91, B_S, NT, "Intel", "Q670E", enable_flash_pch600}, : {0x8086, 0x7a92, B_S, NT, "Intel", "H610E", enable_flash_pch600} Thanks for ref to the doc! I found one https://cdrdv2-public.intel.com/743835/743835-004.pdf I found all the device IDs there, but except of first 3 (0x7a90, 0x7a91, 0x7a92). But the doc says "volume 1 of 2", maybe they are in the volume 2? It's fine to add from a doc which is not fully public, if you have such doc. If you can check that IDs still exist (since you mentioned in the other one that 0x7a8a was cancelled and later reused). File util/ich_descriptors_tool/ich_descriptors_tool.c: https://review.coreboot.org/c/flashrom/+/83854/comment/0951b79d_5c913e7d?us… : PS3, Line 142: "\t- \"600\" or \"alder\" for Intel's 600 series chipsets.\n" Oh sorry, I said it in a confusing way! No, you don't need to add the output of the tool to commit message. I meant to add something like this in commit message: > Updated ich_descriptors_tool to handle chipset name raptor, run the tool, output is correct as expected The tool has its own build file, and can be run separately, so I wanted to mention in commit message that you did it and it works. -- To view, visit https://review.coreboot.org/c/flashrom/+/83854?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I13ac52d5400c0e2260e12d605077fc2182c379ef Gerrit-Change-Number: 83854 Gerrit-PatchSet: 4 Gerrit-Owner: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Filip Gołaś <filip.golas(a)3mdeb.com> Gerrit-CC: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Thu, 05 Sep 2024 07:07:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[M] Change in flashrom[main]: Ensure verify operation completed in full if chip memory modified
by Peter Marheine (Code Review) 04 Sep '24

04 Sep '24

Attention is currently required from: Aarya, Anastasia Klimchuk. Peter Marheine has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/84078?usp=email ) Change subject: Ensure verify operation completed in full if chip memory modified ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Patchset: PS3: I'm very pleased that this found a bug that we can fix! -- To view, visit https://review.coreboot.org/c/flashrom/+/84078?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I3c5d55a0deb20f23f4072caac8c0dce04cc98fd4 Gerrit-Change-Number: 84078 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Wed, 04 Sep 2024 23:30:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in flashrom[main]: ichspi: Add RaptorPoint PCH support
by Michał Żygowski (Code Review) 04 Sep '24

04 Sep '24

Attention is currently required from: Anastasia Klimchuk, Krystian Hebel, Maciej Pijanowski, Michał Kopeć, Sergii Dmytruk. Michał Żygowski has posted comments on this change by Maciej Pijanowski. ( https://review.coreboot.org/c/flashrom/+/83854?usp=email ) Change subject: ichspi: Add RaptorPoint PCH support ...................................................................... Patch Set 4: (1 comment) File util/ich_descriptors_tool/ich_descriptors_tool.c: https://review.coreboot.org/c/flashrom/+/83854/comment/4ba31611_8a68a87e?us… : PS3, Line 142: "\t- \"600\" or \"alder\" for Intel's 600 series chipsets.\n" > Added the missing raptor. The result from ich_descriptors_tool is quite long. Should I really put it into commit message? ./ich_descriptors_tool -f ~/msi_ms7e06_v0.9.1_ddr5.rom -c 700 The flash image has a size of 33554432 [0x2000000] bytes. === Content Section === FLVALSIG 0x0ff0a55a FLMAP0 0x00040003 FLMAP1 0x73100208 FLMAP2 0x00140170 --- Details --- NR (Number of Regions): 16 FRBA (Flash Region Base Address): 0x040 NC (Number of Components): 1 FCBA (Flash Component Base Address): 0x030 ISL (ICH/PCH/SoC Strap Length): 115 FISBA/FPSBA (Flash ICH/PCH/SoC Strap Base Addr): 0x100 NM (Number of Masters): 2 FMBA (Flash Master Base Address): 0x080 MSL/PSL (MCH/PROC Strap Length): 1 FMSBA (Flash MCH/PROC Strap Base Address): 0x700 === Component Section === FLCOMP 0x0930f0f6 FLILL 0x00000000 FLILL1 0x00000000 --- Details --- Component 1 density: 32 MB Component 2 is not used. Read Clock Frequency: 100 MHz Read ID and Status Clock Freq.: 50 MHz Write and Erase Clock Freq.: 50 MHz Fast Read is supported. Fast Read Clock Frequency: 50 MHz Dual Output Fast Read Support: disabled No forbidden opcodes. === Region Section === FLREG0 0x00000000 FLREG1 0x1fff1000 FLREG2 0x03d80001 FLREG3 0x00007fff FLREG4 0x00007fff FLREG5 0x00007fff FLREG6 0x00007fff FLREG7 0x00007fff FLREG8 0x00007fff FLREG9 0x0fff03d9 FLREG10 0x00007fff FLREG11 0x00007fff FLREG12 0x00007fff FLREG13 0x00007fff FLREG14 0x00007fff FLREG15 0x00007fff --- Details --- Region 0 (Descr. ) 0x00000000 - 0x00000fff Region 1 (BIOS ) 0x01000000 - 0x01ffffff Region 2 (ME ) 0x00001000 - 0x003d8fff Region 3 (GbE ) is unused. Region 4 (Platf. ) is unused. Region 5 (DevExp ) is unused. Region 6 (BIOS2 ) is unused. Region 7 (unknown) is unused. Region 8 (EC/BMC ) is unused. Region 9 (unknown) 0x003d9000 - 0x00ffffff Region 10 (IE ) is unused. Region 11 (10GbE0 ) is unused. Region 12 (10GbE1 ) is unused. Region 13 (unknown) is unused. Region 14 (unknown) is unused. Region 15 (PTT ) is unused. === Master Section === FLMSTR1 0xffffff00 FLMSTR2 0xffffff00 --- Details --- FD BIOS ME GbE Pltf DE BIOS2 Reg7 EC DE2 IE 10GbE0 10GbE1 RegD RegE PTT BIOS rw rw rw rw rw rw rw rw rw rw rw rw ME rw rw rw rw rw rw rw rw rw rw rw rw === Upper Map Section === FLUMAP1 0xc0ff02df --- Details --- VTL (length in DWORDS) = 2 VTBA (base address) = 0x000df0 VSCC Table: 1 entries JID0 = 0x0000471f VSCC0 = 0x20152015 Manufacturer ID 0x1f, Device ID 0x4700 BES=0x1, WG=1, WSR=0, WEWS=1, EO=0x20 === Softstraps === --- North/MCH/PROC (1 entries) --- STRP0 = 0xffffffff ISL (115) is greater than the current maximum of 23 entries. Only the first 23 entries will be printed. --- South/ICH/PCH (23 entries) --- STRP0 = 0x1ff00000 STRP1 = 0x1ff00000 STRP2 = 0x1ff00000 STRP3 = 0x1ff00000 STRP4 = 0x1ff00000 STRP5 = 0x1ff00000 STRP6 = 0x10000000 STRP7 = 0x00f000f0 STRP8 = 0x00f000f0 STRP9 = 0x00f000f0 STRP10 = 0x00000000 STRP11 = 0x00000001 STRP12 = 0x00000000 STRP13 = 0x00000000 STRP14 = 0x00000050 STRP15 = 0x00000010 STRP16 = 0x00000004 STRP17 = 0x00000000 STRP18 = 0x000003c0 STRP19 = 0x22222200 STRP20 = 0x22222022 STRP21 = 0x22222222 STRP22 = 0x03fc0022 The meaning of the descriptor straps are unknown yet. -- To view, visit https://review.coreboot.org/c/flashrom/+/83854?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I13ac52d5400c0e2260e12d605077fc2182c379ef Gerrit-Change-Number: 83854 Gerrit-PatchSet: 4 Gerrit-Owner: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Filip Gołaś <filip.golas(a)3mdeb.com> Gerrit-CC: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Wed, 04 Sep 2024 12:35:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: ichspi: Add RaptorPoint PCH support
by Michał Żygowski (Code Review) 04 Sep '24

04 Sep '24

Attention is currently required from: Anastasia Klimchuk, Krystian Hebel, Maciej Pijanowski, Michał Kopeć, Sergii Dmytruk. Michał Żygowski has posted comments on this change by Maciej Pijanowski. ( https://review.coreboot.org/c/flashrom/+/83854?usp=email ) Change subject: ichspi: Add RaptorPoint PCH support ...................................................................... Patch Set 4: (3 comments) Patchset: PS3: > Could you please add this to document `/release_notes/devel. […] Added PS3: > Thank you for adding support! […] Added the relevant datasheet to the commit message. Yes, we have been flashing SPI on Z790 chipset for quite some time, no problems detected. File util/ich_descriptors_tool/ich_descriptors_tool.c: https://review.coreboot.org/c/flashrom/+/83854/comment/44876621_4f1d6ce4?us… : PS3, Line 142: "\t- \"600\" or \"alder\" for Intel's 600 series chipsets.\n" > Could you please add raptor here? And then run the tool, select this new option, and add the result […] Added the missing raptor. -- To view, visit https://review.coreboot.org/c/flashrom/+/83854?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I13ac52d5400c0e2260e12d605077fc2182c379ef Gerrit-Change-Number: 83854 Gerrit-PatchSet: 4 Gerrit-Owner: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Filip Gołaś <filip.golas(a)3mdeb.com> Gerrit-CC: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Wed, 04 Sep 2024 12:31:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: ichspi: Add RaptorPoint PCH support
by Michał Żygowski (Code Review) 04 Sep '24

04 Sep '24

Attention is currently required from: Krystian Hebel, Maciej Pijanowski, Michał Kopeć, Sergii Dmytruk. Michał Żygowski has uploaded a new patch set (#4) to the change originally created by Maciej Pijanowski. ( https://review.coreboot.org/c/flashrom/+/83854?usp=email ) The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: ichspi: Add RaptorPoint PCH support ...................................................................... ichspi: Add RaptorPoint PCH support Based on public Intel 700 Series PCH datasheet, DOC 743835 rev 004. TEST=Probe flash on Z790 chipset Change-Id: I13ac52d5400c0e2260e12d605077fc2182c379ef Signed-off-by: Michał Żygowski <michal.zygowski(a)3mdeb.com> --- M chipset_enable.c M doc/release_notes/devel.rst M ich_descriptors.c M ichspi.c M include/programmer.h M util/ich_descriptors_tool/ich_descriptors_tool.c 6 files changed, 45 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/54/83854/4 -- To view, visit https://review.coreboot.org/c/flashrom/+/83854?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I13ac52d5400c0e2260e12d605077fc2182c379ef Gerrit-Change-Number: 83854 Gerrit-PatchSet: 4 Gerrit-Owner: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Filip Gołaś <filip.golas(a)3mdeb.com> Gerrit-CC: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com>

1 0

[M] Change in flashrom[main]: Ensure verify operation completed in full if chip memory modified
by Anastasia Klimchuk (Code Review) 04 Sep '24

04 Sep '24

Attention is currently required from: Aarya, Peter Marheine. Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/84078?usp=email ) Change subject: Ensure verify operation completed in full if chip memory modified ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: I made all the tests work! This is ready for review! To handle test case #19 , setup_chip now returns the end boundary (offset) of how far we need to do verification. Which is in most cases 16 bytes (size of mock chip), however #19 has logical layout which does not cover the full chip. We only go as far as logical layout is configured. -- To view, visit https://review.coreboot.org/c/flashrom/+/84078?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I3c5d55a0deb20f23f4072caac8c0dce04cc98fd4 Gerrit-Change-Number: 84078 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Comment-Date: Wed, 04 Sep 2024 12:22:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in flashrom[main]: Ensure verify operation completed in full if chip memory modified
by Anastasia Klimchuk (Code Review) 04 Sep '24

04 Sep '24

Attention is currently required from: Aarya, Anastasia Klimchuk, Peter Marheine. Hello Aarya, Peter Marheine, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/84078?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by build bot (Jenkins) Change subject: Ensure verify operation completed in full if chip memory modified ...................................................................... Ensure verify operation completed in full if chip memory modified The patch adds new functionality to the test: tracking the areas of chip memory that were modified (i.e. by erase or write operation), and then checking those areas were completely covered by verify operation. The test operates over the mock chip memory of 16 bytes, so it is possible to track each byte which was modified, and assert that is has been verified afterwards. Adding the test found a bug which is fixed in this commit: Post-cleanup after processing unaligned region for the case when end region needs to be extended to align with erase block. Writing was done correctly, but post-processing of newcontents could cause one-off offset at the end of the region, which would make verification appear false-negative (see test cases #16-19). Change-Id: I3c5d55a0deb20f23f4072caac8c0dce04cc98fd4 Signed-off-by: Anastasia Klimchuk <aklm(a)flashrom.org> --- M erasure_layout.c M tests/erase_func_algo.c 2 files changed, 138 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/78/84078/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/84078?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I3c5d55a0deb20f23f4072caac8c0dce04cc98fd4 Gerrit-Change-Number: 84078 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Aarya <aarya.chaumal(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org>

1 0

[S] Change in flashrom[main]: ichspi: Add RaptorPoint PCH support
by Filip Gołaś (Code Review) 04 Sep '24

04 Sep '24

Attention is currently required from: Krystian Hebel, Maciej Pijanowski, Michał Kopeć, Sergii Dmytruk. Filip Gołaś has posted comments on this change by Maciej Pijanowski. ( https://review.coreboot.org/c/flashrom/+/83854?usp=email ) Change subject: ichspi: Add RaptorPoint PCH support ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: Add reviewers -- To view, visit https://review.coreboot.org/c/flashrom/+/83854?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I13ac52d5400c0e2260e12d605077fc2182c379ef Gerrit-Change-Number: 83854 Gerrit-PatchSet: 3 Gerrit-Owner: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Filip Gołaś <filip.golas(a)3mdeb.com> Gerrit-CC: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Maciej Pijanowski <maciej.pijanowski(a)3mdeb.com> Gerrit-Attention: Michał Kopeć <michal.kopec(a)3mdeb.com> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Sergii Dmytruk <sergii.dmytruk(a)3mdeb.com> Gerrit-Comment-Date: Wed, 04 Sep 2024 10:46:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit