[M] Change in flashrom[main]: Ensure verify operation completed in full if chip memory modified
Attention is currently required from: Aarya, Peter Marheine. Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/84078?usp=email ) Change subject: Ensure verify operation completed in full if chip memory modified ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: I made all the tests work! This is ready for review! To handle test case #19 , setup_chip now returns the end boundary (offset) of how far we need to do verification. Which is in most cases 16 bytes (size of mock chip), however #19 has logical layout which does not cover the full chip. We only go as far as logical layout is configured. -- To view, visit https://review.coreboot.org/c/flashrom/+/84078?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I3c5d55a0deb20f23f4072caac8c0dce04cc98fd4 Gerrit-Change-Number: 84078 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Reviewer: Aarya <aarya.chaumal@gmail.com> Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Attention: Aarya <aarya.chaumal@gmail.com> Gerrit-Attention: Peter Marheine <pmarheine@chromium.org> Gerrit-Comment-Date: Wed, 04 Sep 2024 12:22:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
participants (1)
-
Anastasia Klimchuk (Code Review)