[S] Change in flashrom[main]: ichspi: Add RaptorPoint PCH support

[Anastasia Klimchuk (Code Review)]

Attention is currently required from: Krystian Hebel, Maciej Pijanowski, Michał Kopeć, Michał Żygowski, Sergii Dmytruk.

Anastasia Klimchuk has posted comments on this change by Maciej Pijanowski. ( https://review.coreboot.org/c/flashrom/+/83854?usp=email )

Change subject: ichspi: Add RaptorPoint PCH support
......................................................................


Patch Set 4:

(4 comments)

Patchset:

PS3:
> Added the relevant datasheet to the commit message. […]
> Done

PS3:
> Added
> Done

File chipset_enable.c:

https://review.coreboot.org/c/flashrom/+/83854/comment/1f2f6713_7a968aa5?usp... :
PS4, Line 2209: 	{0x8086, 0x7a90, B_S,    NT,  "Intel", "R680E",				enable_flash_pch600},
              : 	{0x8086, 0x7a91, B_S,    NT,  "Intel", "Q670E",				enable_flash_pch600},
              : 	{0x8086, 0x7a92, B_S,    NT,  "Intel", "H610E",				enable_flash_pch600}
Thanks for ref to the doc! I found one https://cdrdv2-public.intel.com/743835/743835-004.pdf

I found all the device IDs there, but except of first 3 (0x7a90, 0x7a91, 0x7a92). But the doc says "volume 1 of 2", maybe they are in the volume 2?
It's fine to add from a doc which is not fully public, if you have such doc. If you can check that IDs still exist (since you mentioned in the other one that 0x7a8a was cancelled and later reused).


File util/ich_descriptors_tool/ich_descriptors_tool.c:

https://review.coreboot.org/c/flashrom/+/83854/comment/0951b79d_5c913e7d?usp... :
PS3, Line 142: "\t- \"600\" or \"alder\" for Intel's 600 series chipsets.\n"
Oh sorry, I said it in a confusing way! No, you don't need to add the output of the tool to commit message.
I meant to add something like this in commit message:
> Updated ich_descriptors_tool to handle chipset name raptor, run the tool, output is correct as expected

The tool has its own build file, and can be run separately, so I wanted to mention in commit message that you did it and it works.



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/83854?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I13ac52d5400c0e2260e12d605077fc2182c379ef
Gerrit-Change-Number: 83854
Gerrit-PatchSet: 4
Gerrit-Owner: Maciej Pijanowski <[e-mail]>
Gerrit-Reviewer: Anastasia Klimchuk <[e-mail]>
Gerrit-Reviewer: Krystian Hebel <[e-mail]>
Gerrit-Reviewer: Michał Żygowski <[e-mail]>
Gerrit-Reviewer: Sergii Dmytruk <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Filip Gołaś <[e-mail]>
Gerrit-CC: Michał Kopeć <[e-mail]>
Gerrit-Attention: Michał Żygowski <[e-mail]>
Gerrit-Attention: Maciej Pijanowski <[e-mail]>
Gerrit-Attention: Michał Kopeć <[e-mail]>
Gerrit-Attention: Krystian Hebel <[e-mail]>
Gerrit-Attention: Sergii Dmytruk <[e-mail]>
Gerrit-Comment-Date: Thu, 05 Sep 2024 07:07:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski <[e-mail]>
Comment-In-Reply-To: Anastasia Klimchuk <[e-mail]>