- flashrom-gerrit - mail.coreboot.org

Change in flashrom[staging]: fixup! chipset_enable: Add support for Intel Skylake
by Nico Huber (Code Review) 23 Mar '17

23 Mar '17

Nico Huber has uploaded a new change for review. ( https://review.coreboot.org/18956 ) Change subject: fixup! chipset_enable: Add support for Intel Skylake ...................................................................... fixup! chipset_enable: Add support for Intel Skylake Change-Id: Ie2f6944c2556641420cf343cc7aad4023299c677 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- M chipset_enable.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/56/18956/1 diff --git a/chipset_enable.c b/chipset_enable.c index 7bd651d..a0199d9 100644 --- a/chipset_enable.c +++ b/chipset_enable.c @@ -859,8 +859,8 @@ if (ret_bc == ERROR_FATAL) goto _freepci_ret; - const uint32_t phys_spibar = pci_read_long(spi_dev, 0x10) & 0xfffff000; - void *const spibar = rphysmap("SPIBAR", phys_spibar, 0x4000); + const uint32_t phys_spibar = pci_read_long(spi_dev, PCI_BASE_ADDRESS_0) & 0xfffff000; + void *const spibar = rphysmap("SPIBAR", phys_spibar, 0x1000); if (spibar == ERROR_PTR) goto _freepci_ret; msg_pdbg("SPIBAR = 0x%0*" PRIxPTR " (phys = 0x%08x)\n", PRIxPTR_WIDTH, (uintptr_t)spibar, phys_spibar); -- To view, visit https://review.coreboot.org/18956 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie2f6944c2556641420cf343cc7aad4023299c677 Gerrit-PatchSet: 1 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>

1 0

Change in flashrom[staging]: fixup! flashrom: Add Skylake platform support
by Nico Huber (Code Review) 23 Mar '17

23 Mar '17

Hello Paul Menzel, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/18937 to look at the new patch set (#2). Change subject: fixup! flashrom: Add Skylake platform support ...................................................................... fixup! flashrom: Add Skylake platform support ichspi: Consolidate copy-pasta hwseq code Change-Id: I79d0c6284397ca382ce8e531c6f9490c74d31cc1 Signed-off-by: Nico Huber <nico.huber(a)secunet.com> --- M ichspi.c 1 file changed, 41 insertions(+), 242 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/37/18937/2 -- To view, visit https://review.coreboot.org/18937 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I79d0c6284397ca382ce8e531c6f9490c74d31cc1 Gerrit-PatchSet: 2 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in flashrom[staging]: Add iMac5, 2 to board_enable
by build bot (Jenkins) (Code Review) 22 Mar '17

22 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18943 ) Change subject: Add iMac5,2 to board_enable ...................................................................... Patch Set 4: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/38/ : SUCCESS -- To view, visit https://review.coreboot.org/18943 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e4daaa67f98a47e237cd73962776da369c8f0b5 Gerrit-PatchSet: 4 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Add iMac5, 2 to board_enable
by Arthur Heymans (Code Review) 22 Mar '17

22 Mar '17

Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/18943 to look at the new patch set (#4). Change subject: Add iMac5,2 to board_enable ...................................................................... Add iMac5,2 to board_enable When running coreboot everything works, while on vendor bios it fails to erase anything until the 3th erase function of a SST25VF016B is tried. Change-Id: I5e4daaa67f98a47e237cd73962776da369c8f0b5 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M board_enable.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/43/18943/4 -- To view, visit https://review.coreboot.org/18943 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5e4daaa67f98a47e237cd73962776da369c8f0b5 Gerrit-PatchSet: 4 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in flashrom[staging]: Add iMAC5, 2 to board_enable
by build bot (Jenkins) (Code Review) 22 Mar '17

22 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18943 ) Change subject: Add iMAC5,2 to board_enable ...................................................................... Patch Set 3: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/37/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/54/ : SUCCESS -- To view, visit https://review.coreboot.org/18943 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e4daaa67f98a47e237cd73962776da369c8f0b5 Gerrit-PatchSet: 3 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Add iMAC5, 2 to board_enable
by Arthur Heymans (Code Review) 22 Mar '17

22 Mar '17

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/18943 ) Change subject: Add iMAC5,2 to board_enable ...................................................................... Patch Set 2: > (1 comment) > > Please send a log (taken with `-o logfile`) of a run with `-w` > where > something changes (i.e. read/erase/write) to the ML. I don't own this board but this was the output the owner gave me: https://www.flashrom.org/pipermail/flashrom/2016-September/014823.html -- To view, visit https://review.coreboot.org/18943 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e4daaa67f98a47e237cd73962776da369c8f0b5 Gerrit-PatchSet: 2 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Add iMAC5, 2 to board_enable
by Arthur Heymans (Code Review) 22 Mar '17

22 Mar '17

Hello build bot (Jenkins), Nico Huber, I'd like you to reexamine a change. Please visit https://review.coreboot.org/18943 to look at the new patch set (#3). Change subject: Add iMAC5,2 to board_enable ...................................................................... Add iMAC5,2 to board_enable When running coreboot everything works, while on vendor bios it fails to erase anything until the 3th erase function of a SST25VF016B is tried. Change-Id: I5e4daaa67f98a47e237cd73962776da369c8f0b5 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M board_enable.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/43/18943/3 -- To view, visit https://review.coreboot.org/18943 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I5e4daaa67f98a47e237cd73962776da369c8f0b5 Gerrit-PatchSet: 3 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins)

1 0

Change in flashrom[staging]: Add iMAC5, 2 to board_enable
by Nico Huber (Code Review) 22 Mar '17

22 Mar '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/18943 ) Change subject: Add iMAC5,2 to board_enable ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Please send a log (taken with `-o logfile`) of a run with `-w` where something changes (i.e. read/erase/write) to the ML. https://review.coreboot.org/#/c/18943/2/board_enable.c File board_enable.c: PS2, Line 2328: NULL, NULL, Please fix the alignment of the double `NULL`. -- To view, visit https://review.coreboot.org/18943 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e4daaa67f98a47e237cd73962776da369c8f0b5 Gerrit-PatchSet: 2 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: Yes

1 0

Change in flashrom[staging]: Add iMAC5, 2 to board_enable
by build bot (Jenkins) (Code Review) 22 Mar '17

22 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18943 ) Change subject: Add iMAC5,2 to board_enable ...................................................................... Patch Set 2: Verified+1 Build Successful https://qa.coreboot.org/job/flashrom-customrules/36/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/53/ : SUCCESS -- To view, visit https://review.coreboot.org/18943 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e4daaa67f98a47e237cd73962776da369c8f0b5 Gerrit-PatchSet: 2 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Add iMAC5, 2 to board_enable
by build bot (Jenkins) (Code Review) 22 Mar '17

22 Mar '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18943 ) Change subject: Add iMAC5,2 to board_enable ...................................................................... Patch Set 1: Verified-1 Build Failed https://qa.coreboot.org/job/flashrom_gerrit/52/ : FAILURE https://qa.coreboot.org/job/flashrom-customrules/35/ : SUCCESS -- To view, visit https://review.coreboot.org/18943 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5e4daaa67f98a47e237cd73962776da369c8f0b5 Gerrit-PatchSet: 1 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit