- flashrom-gerrit - mail.coreboot.org

Change in flashrom[staging]: Add option to read ROM layout from IFD
by Nico Huber (Code Review) 22 Apr '17

22 Apr '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/17953 ) Change subject: Add option to read ROM layout from IFD ...................................................................... Patch Set 9: (2 comments) I'm haven't tested if it builds now on non-x86. It should try at least :) https://review.coreboot.org/#/c/17953/7/cli_classic.c File cli_classic.c: PS7, Line 60: " --ifd > Since we only have a few useful single letters available for short opts, I Done PS7, Line 574: fl_layout_release(layout); : > Hm, it would be nice if this could be called unconditionally, or perhaps ju Done -- To view, visit https://review.coreboot.org/17953 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifafff2bf6d5c5e62283416b3269723f81fdc0fa3 Gerrit-PatchSet: 9 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: Yes

1 0

Change in flashrom[staging]: cli_classic: Add option (-A, --noverify-all)
by Nico Huber (Code Review) 22 Apr '17

22 Apr '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/17950 ) Change subject: cli_classic: Add option (-A, --noverify-all) ...................................................................... Patch Set 9: (1 comment) https://review.coreboot.org/#/c/17950/7/cli_classic.c File cli_classic.c: PS7, Line 58: A > I guess I'd prefer 'V' for "verify included". Might be worth asking a few o Well, 'V' is already taken, obviously. Any other suggestions? -- To view, visit https://review.coreboot.org/17950 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40b5983f56d62821d17b827b88b73d1d41a30bd7 Gerrit-PatchSet: 9 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: Yes

1 0

Change in flashrom[staging]: Add a convenient libflashrom interface
by Nico Huber (Code Review) 22 Apr '17

22 Apr '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/17946 ) Change subject: Add a convenient libflashrom interface ...................................................................... Patch Set 7: (5 comments) https://review.coreboot.org/#/c/17946/6/flashrom.c File flashrom.c: Line 2507: return 1; > Would it make sense to add a wrapper function that calls unmap_flash() and Done It only contains unmap_flash() for now, since this was also the only cleanup done before. PS6, Line 2610: : } > "containing" might be a better word for this Done Line 2696: } > Style nit: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.g Done https://review.coreboot.org/#/c/17946/6/libflashrom.c File libflashrom.c: PS6, Line 42: fl_ > I had originally thought fl_ was used when describing flash layout stuff th I used it for the library interface originally. `struct fl_layout` is part of it. I can't remember why I used it for the layout internal parts too. I dropped the fl_ prefix from the layout parts beside `struct fl_layout` for now. At least until we have an official prefix for the library. Line 301: return 1; > How about adding: Done -- To view, visit https://review.coreboot.org/17946 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00f169990830aa17b7dfae5eb74010d40c476181 Gerrit-PatchSet: 7 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: Yes

1 0

Change in flashrom[staging]: Add functions to read/erase/write/verify by layout
by Nico Huber (Code Review) 22 Apr '17

22 Apr '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/17945 ) Change subject: Add functions to read/erase/write/verify by layout ...................................................................... Patch Set 8: -Code-Review -- To view, visit https://review.coreboot.org/17945 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6194cea4c4c430e0cf9d586052508a865b09c86 Gerrit-PatchSet: 8 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Simple, clumsy script to test layout handling
by build bot (Jenkins) (Code Review) 22 Apr '17

22 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/19352 ) Change subject: Simple, clumsy script to test layout handling ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/flashrom-customrules/208/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/220/ : SUCCESS -- To view, visit https://review.coreboot.org/19352 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37124455071bf3395384a58ad236c998f738c418 Gerrit-PatchSet: 3 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Enable writes with active ME
by build bot (Jenkins) (Code Review) 22 Apr '17

22 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18740 ) Change subject: Enable writes with active ME ...................................................................... Patch Set 8: Build Successful https://qa.coreboot.org/job/flashrom-customrules/207/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/219/ : SUCCESS -- To view, visit https://review.coreboot.org/18740 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94a5e7074b845c227e43d76d04dd1a71082a1cef Gerrit-PatchSet: 8 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Whitelist Roda/RV11 laptop
by build bot (Jenkins) (Code Review) 22 Apr '17

22 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18739 ) Change subject: Whitelist Roda/RV11 laptop ...................................................................... Patch Set 8: Build Successful https://qa.coreboot.org/job/flashrom-customrules/206/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/218/ : SUCCESS -- To view, visit https://review.coreboot.org/18739 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I036c1f8cb914c8e3cca9d17eb221b582d7414ae9 Gerrit-PatchSet: 8 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Add option to read ROM layout from IFD
by build bot (Jenkins) (Code Review) 22 Apr '17

22 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/17953 ) Change subject: Add option to read ROM layout from IFD ...................................................................... Patch Set 9: Build Successful https://qa.coreboot.org/job/flashrom-customrules/204/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/216/ : SUCCESS -- To view, visit https://review.coreboot.org/17953 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifafff2bf6d5c5e62283416b3269723f81fdc0fa3 Gerrit-PatchSet: 9 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Make read_ich_descriptors_from_dump() available in flashrom
by build bot (Jenkins) (Code Review) 22 Apr '17

22 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/17952 ) Change subject: Make read_ich_descriptors_from_dump() available in flashrom ...................................................................... Patch Set 9: Build Successful https://qa.coreboot.org/job/flashrom-customrules/203/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/215/ : SUCCESS -- To view, visit https://review.coreboot.org/17952 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib3d38a622a581afee87b49777e775942cc901fc8 Gerrit-PatchSet: 9 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Fix linking with libpayload
by build bot (Jenkins) (Code Review) 22 Apr '17

22 Apr '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/18738 ) Change subject: Fix linking with libpayload ...................................................................... Patch Set 8: Build Successful https://qa.coreboot.org/job/flashrom-customrules/205/ : SUCCESS https://qa.coreboot.org/job/flashrom_gerrit/217/ : SUCCESS -- To view, visit https://review.coreboot.org/18738 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I561135209b819361d125eeaeef9ff886d6bae987 Gerrit-PatchSet: 8 Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) Gerrit-HasComments: No

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit