- flashrom-gerrit - mail.coreboot.org

Change in flashrom[staging]: spi25: Enable direct 4BA read and write using feature bits
by David Hendricks (Code Review) 17 Oct '17

17 Oct '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/22021 ) Change subject: spi25: Enable direct 4BA read and write using feature bits ...................................................................... Patch Set 1: Code-Review-1 (2 comments) https://review.coreboot.org/#/c/22021/1/spi25.c File spi25.c: https://review.coreboot.org/#/c/22021/1/spi25.c@582 PS1, Line 582: JEDEC_BYTE_PROGRAM_4BA So this will use a native 4BA instruction whether or not you use the extended address register. Maybe I'm missing something? https://review.coreboot.org/#/c/22021/1/spi25.c@592 PS1, Line 592: JEDEC_READ_4BA same comment as above -- To view, visit https://review.coreboot.org/22021 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I2f6817ca198bf923671a7aa67e956e5477d71848 Gerrit-Change-Number: 22021 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 17 Oct 2017 03:26:07 +0000 Gerrit-HasComments: Yes

1 0

Change in flashrom[staging]: spi25: Add native 4BA support
by David Hendricks (Code Review) 17 Oct '17

17 Oct '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/22020 ) Change subject: spi25: Add native 4BA support ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/22020 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I644600beaab9a571b97b67f7516abe571d3460c1 Gerrit-Change-Number: 22020 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 17 Oct 2017 01:20:46 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: spi25: Use common code for nbyte read/write and erase
by David Hendricks (Code Review) 17 Oct '17

17 Oct '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/22019 ) Change subject: spi25: Use common code for nbyte read/write and erase ...................................................................... Patch Set 1: Code-Review-1 (6 comments) Mostly looks good, just a few minor things. https://review.coreboot.org/#/c/22019/1//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/22019/1//COMMIT_MSG@9 PS1, Line 9: spi_write_command spi_write_cmd https://review.coreboot.org/#/c/22019/1//COMMIT_MSG@10 PS1, Line 10: erase block erase, since it doesn't apply to chip erase functions https://review.coreboot.org/#/c/22019/1//COMMIT_MSG@12 PS1, Line 12: spi_write_command spi_write_cmd https://review.coreboot.org/#/c/22019/1/spi25.c File spi25.c: https://review.coreboot.org/#/c/22019/1/spi25.c@326 PS1, Line 326: spi_write_status spi_poll_status? https://review.coreboot.org/#/c/22019/1/spi25.c@377 PS1, Line 377: JEDEC_WREN Hmmm, what do we do about chips that only use EWSR? I know this patch is only intended to replace the old functions, but maybe in a follow-up we can add some logic to check the feature bits to see which enable opcode we should use. https://review.coreboot.org/#/c/22019/1/spi25.c@383 PS1, Line 383: Check if out_len < 1? -- To view, visit https://review.coreboot.org/22019 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Ibc1ae48acbfbd427a30bcd64bdc080dc3dc20503 Gerrit-Change-Number: 22019 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 17 Oct 2017 00:24:32 +0000 Gerrit-HasComments: Yes

1 0

Change in flashrom[staging]: spi25: Introduce spi_simple_write_cmd()
by David Hendricks (Code Review) 17 Oct '17

17 Oct '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/22018 ) Change subject: spi25: Introduce spi_simple_write_cmd() ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Just a little bikeshedding, otherwise LGTM. https://review.coreboot.org/#/c/22018/1/spi25.c File spi25.c: https://review.coreboot.org/#/c/22018/1/spi25.c@326 PS1, Line 326: spi_simple_write_cmd Is there anything other than chip erase commands that this applies to? I think this should be called "spi_erase_cmd" or something more specific to its purpose since it doesn't handle data or addresses. -- To view, visit https://review.coreboot.org/22018 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Ib244356fa471e15863b52e6037899d19113cb4a9 Gerrit-Change-Number: 22018 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 16 Oct 2017 22:19:38 +0000 Gerrit-HasComments: Yes

1 0

Change in flashrom[staging]: spi25_statusreg: Return defined value on failed RDSR
by David Hendricks (Code Review) 17 Oct '17

17 Oct '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/22017 ) Change subject: spi25_statusreg: Return defined value on failed RDSR ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/22017 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I714b20001a5443bba665c2e0061ca14069777581 Gerrit-Change-Number: 22017 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 16 Oct 2017 21:55:09 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Fix serprog on FreeBSD
by Urja Rannikko (Code Review) 16 Oct '17

16 Oct '17

Urja Rannikko has posted comments on this change. ( https://review.coreboot.org/21919 ) Change subject: Fix serprog on FreeBSD ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/21919 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: I7aa6a283d523c544d9b8923cd4c622bf08c0fb3f Gerrit-Change-Number: 21919 Gerrit-PatchSet: 1 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Urja Rannikko <urjaman(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 16 Oct 2017 17:11:43 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: spi25: Remove now obsolete `four_bytes_addr_funcs` path
by Nico Huber (Code Review) 16 Oct '17

16 Oct '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/22022 ) Change subject: spi25: Remove now obsolete `four_bytes_addr_funcs` path ...................................................................... Patch Set 1: (2 comments) https://review.coreboot.org/#/c/22022/1/spi25.c File spi25.c: https://review.coreboot.org/#/c/22022/1/spi25.c@682 PS1, Line 682: while (spi_read_status_register(flash) & SPI_SR_WIP) : programmer_delay(10); remove https://review.coreboot.org/#/c/22022/1/spi25.c@708 PS1, Line 708: while (spi_read_status_register(flash) & SPI_SR_WIP) : programmer_delay(10); remove -- To view, visit https://review.coreboot.org/22022 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Idb7c576cb159630da2268813388b497cb5f46b43 Gerrit-Change-Number: 22022 Gerrit-PatchSet: 1 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 16 Oct 2017 17:06:24 +0000 Gerrit-HasComments: Yes

1 0

Change in flashrom[staging]: spi: Add valid_addr_offset() to spi_master
by Nico Huber (Code Review) 16 Oct '17

16 Oct '17

Nico Huber has posted comments on this change. ( https://review.coreboot.org/19418 ) Change subject: spi: Add valid_addr_offset() to spi_master ...................................................................... Patch Set 3: Code-Review-1 The patch is fine, but doesn't solve the real problem: spi_get_valid_read_addr() shouldn't exist. We are testing something programmer specific right before giving control to the programmer driver... ichspi should just test this. -- To view, visit https://review.coreboot.org/19418 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Icbac513c5339e8aff624870252133284ef85ab73 Gerrit-Change-Number: 19418 Gerrit-PatchSet: 3 Gerrit-Owner: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 16 Oct 2017 17:03:14 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: make args for -r/-w/-v non-positional and optional
by David Hendricks (Code Review) 16 Oct '17

16 Oct '17

David Hendricks has posted comments on this change. ( https://review.coreboot.org/19387 ) Change subject: make args for -r/-w/-v non-positional and optional ...................................................................... Patch Set 7: Sure - I'll see if I can untangle it. -- To view, visit https://review.coreboot.org/19387 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Iefbcb7dc4fefe26f5afd1292dfd5c1687fa62803 Gerrit-Change-Number: 19387 Gerrit-PatchSet: 7 Gerrit-Owner: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: David Hendricks <david.hendricks(a)gmail.com> Gerrit-Reviewer: Louis Yung-Chieh Lo <yjlou(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 16 Oct 2017 16:55:32 +0000 Gerrit-HasComments: No

1 0

Change in flashrom[staging]: Fix ID of ST M25P05
by build bot (Jenkins) (Code Review) 16 Oct '17

16 Oct '17

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/21920 ) Change subject: Fix ID of ST M25P05 ...................................................................... Patch Set 3: Build Successful https://qa.coreboot.org/job/flashrom-customrules/792/ : SUCCESS -- To view, visit https://review.coreboot.org/21920 To unsubscribe, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: staging Gerrit-MessageType: comment Gerrit-Change-Id: Idc75f8cb98e7ef0c47c4527cedcc4da3723bd779 Gerrit-Change-Number: 21920 Gerrit-PatchSet: 3 Gerrit-Owner: Stefan Tauner <stefan.tauner(a)gmx.at> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 16 Oct 2017 16:37:06 +0000 Gerrit-HasComments: No

1 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit