Change in flashrom[staging]: spi25: Enable direct 4BA read and write using feature bits

[David Hendricks (Code Review)]

David Hendricks has posted comments on this change. ( https://review.coreboot.org/22021 )

Change subject: spi25: Enable direct 4BA read and write using feature bits
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://review.coreboot.org/#/c/22021/1/spi25.c
File spi25.c:

https://review.coreboot.org/#/c/22021/1/spi25.c@582
PS1, Line 582: JEDEC_BYTE_PROGRAM_4BA
So this will use a native 4BA instruction whether or not you use the extended address register. Maybe I'm missing something?


https://review.coreboot.org/#/c/22021/1/spi25.c@592
PS1, Line 592: JEDEC_READ_4BA
same comment as above



-- 
To view, visit https://review.coreboot.org/22021
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: I2f6817ca198bf923671a7aa67e956e5477d71848
Gerrit-Change-Number: 22021
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <[e-mail]>
Gerrit-Reviewer: David Hendricks <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Tue, 17 Oct 2017 03:26:07 +0000
Gerrit-HasComments: Yes