Change in flashrom[staging]: spi25: Introduce spi_simple_write_cmd() - flashrom-gerrit

17 Oct 2017


      David Hendricks has posted comments on this change. ( https://review.coreboot.org/22018 )
Change subject: spi25: Introduce spi_simple_write_cmd()
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Just a little bikeshedding, otherwise LGTM.
https://review.coreboot.org/#/c/22018/1/spi25.c
File spi25.c:
https://review.coreboot.org/#/c/22018/1/spi25.c@326
PS1, Line 326: spi_simple_write_cmd
Is there anything other than chip erase commands that this applies to? I think this should be called "spi_erase_cmd" or something more specific to its purpose since it doesn't handle data or addresses.
-- 
To view, visit https://review.coreboot.org/22018
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib244356fa471e15863b52e6037899d19113cb4a9
Gerrit-Change-Number: 22018
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 16 Oct 2017 22:19:38 +0000
Gerrit-HasComments: Yes