July 2024 - flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[main]: flashchips: Add Support for XMC XM25QH32C/XM25QH32D
by Ssunk (Code Review) 03 Jul '24

03 Jul '24

Attention is currently required from: Nikolai Artemiev, Stefan Reinauer. Ssunk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83235?usp=email ) Change subject: flashchips: Add Support for XMC XM25QH32C/XM25QH32D ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Wait until the tag v1.4.0 done and after that the patch can be submitted. ETA 26 July. […] Got it, thanks! -- To view, visit https://review.coreboot.org/c/flashrom/+/83235?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib201ac28384b8db6539e2a82e6f90462d1393208 Gerrit-Change-Number: 83235 Gerrit-PatchSet: 1 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Wed, 03 Jul 2024 11:28:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: flashchips: Add Support for XMC XM25QU16C
by Ssunk (Code Review) 03 Jul '24

03 Jul '24

Attention is currently required from: Nikolai Artemiev, Stefan Reinauer. Ssunk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83234?usp=email ) Change subject: flashchips: Add Support for XMC XM25QU16C ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Wait until the tag v1.4.0 done and after that the patch can be submitted. ETA 26 July. […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/83234?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I0989b5dd239dd32f93e1a338a70e5d7279127d8d Gerrit-Change-Number: 83234 Gerrit-PatchSet: 1 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Wed, 03 Jul 2024 11:27:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: flashchips: Add Support for XMC XM25QU32C
by Ssunk (Code Review) 03 Jul '24

03 Jul '24

Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer. Ssunk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83236?usp=email ) Change subject: flashchips: Add Support for XMC XM25QU32C ...................................................................... Patch Set 2: (1 comment) File include/flashchips.h: https://review.coreboot.org/c/flashrom/+/83236/comment/0bace367_c49ea88e?us… : PS1, Line 853: XMC_XM25QU32C > Let's put it after QH (like the other entries, QH and then QU) […] Got it, -- To view, visit https://review.coreboot.org/c/flashrom/+/83236?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ida0ab895309ef83dcc6b3f03c032a16f9b1f923a Gerrit-Change-Number: 83236 Gerrit-PatchSet: 2 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Wed, 03 Jul 2024 11:27:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: flashchips: Add Support for XMC XM25QU32C
by Ssunk (Code Review) 03 Jul '24

03 Jul '24

Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer. Hello Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/83236?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: flashchips: Add Support for XMC XM25QU32C ...................................................................... flashchips: Add Support for XMC XM25QU32C Add initial support for the SPI flash chip XM25QU32C Datasheet link: https://www.xmcwh.com/uploads/233/XM25QU32C_Ver2.1.pdf Tested with ch341a programmer: probe, read, write, erase Change-Id: Ida0ab895309ef83dcc6b3f03c032a16f9b1f923a Signed-off-by: Kan Sun <ssunkkan(a)gmail.com> --- M flashchips.c M include/flashchips.h 2 files changed, 39 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/36/83236/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/83236?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ida0ab895309ef83dcc6b3f03c032a16f9b1f923a Gerrit-Change-Number: 83236 Gerrit-PatchSet: 2 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Ssunk <ssunkkan(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>

1 0

[S] Change in flashrom[main]: flashchips: Add Support for XMC XM25QU32C
by Anastasia Klimchuk (Code Review) 03 Jul '24

03 Jul '24

Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83236?usp=email ) Change subject: flashchips: Add Support for XMC XM25QU32C ...................................................................... Patch Set 1: (1 comment) File include/flashchips.h: https://review.coreboot.org/c/flashrom/+/83236/comment/18b14b4f_6dc8f180?us… : PS1, Line 853: XMC_XM25QU32C Let's put it after QH (like the other entries, QH and then QU) So basically, just swap lines 853 and 854 -- To view, visit https://review.coreboot.org/c/flashrom/+/83236?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ida0ab895309ef83dcc6b3f03c032a16f9b1f923a Gerrit-Change-Number: 83236 Gerrit-PatchSet: 1 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Ssunk <ssunkkan(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Wed, 03 Jul 2024 06:22:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in flashrom[main]: flashchips: Add Support for XMC XM25QH32C/XM25QH32D
by Anastasia Klimchuk (Code Review) 03 Jul '24

03 Jul '24

Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83235?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: flashchips: Add Support for XMC XM25QH32C/XM25QH32D ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Wait until the tag v1.4.0 done and after that the patch can be submitted. ETA 26 July. https://mail.coreboot.org/hyperkitty/list/flashrom@flashrom.org/thread/UUDQ… -- To view, visit https://review.coreboot.org/c/flashrom/+/83235?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib201ac28384b8db6539e2a82e6f90462d1393208 Gerrit-Change-Number: 83235 Gerrit-PatchSet: 1 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Ssunk <ssunkkan(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Wed, 03 Jul 2024 06:06:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in flashrom[main]: flashchips: Add Support for XMC XM25QH32C/XM25QH32D
by Anastasia Klimchuk (Code Review) 03 Jul '24

03 Jul '24

Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83235?usp=email ) Change subject: flashchips: Add Support for XMC XM25QH32C/XM25QH32D ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/83235?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib201ac28384b8db6539e2a82e6f90462d1393208 Gerrit-Change-Number: 83235 Gerrit-PatchSet: 1 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Ssunk <ssunkkan(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Wed, 03 Jul 2024 06:06:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in flashrom[main]: flashchips: Add chip models GD25LB256F/GD25LR256F
by Victor Lim (Code Review) 03 Jul '24

03 Jul '24

Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer. Victor Lim has posted comments on this change by Victor Lim. ( https://review.coreboot.org/c/flashrom/+/83254?usp=email ) Change subject: flashchips: Add chip models GD25LB256F/GD25LR256F ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/83254/comment/a50fc565_93f952f9?us… : PS1, Line 13: https://www.gigadevice.com/message-board?cid=39&id=3171&file_type=Datasheet… > I went by the link, but it opens "Contact Us" page, not the datasheet? […] Hi, Anastasia, datasheet has been sent via email -- To view, visit https://review.coreboot.org/c/flashrom/+/83254?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I0fbd270a57999d4131816c48470588bb7ec22d37 Gerrit-Change-Number: 83254 Gerrit-PatchSet: 1 Gerrit-Owner: Victor Lim <vlim(a)gigadevice.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Wed, 03 Jul 2024 01:40:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[XS] Change in flashrom[main]: libflashrom.map: remove non-existent functions
by Fabian Groffen (Code Review) 02 Jul '24

02 Jul '24

Fabian Groffen has posted comments on this change by Fabian Groffen. ( https://review.coreboot.org/c/flashrom/+/83261?usp=email ) Change subject: libflashrom.map: remove non-existent functions ...................................................................... Patch Set 2: (2 comments) Patchset: PS2: > Fabian I also noticed, from the bug you linked, what does it mean flashrom-1.3.0-r2 ? […] -r2 is just a Gentoo (distro-specific) revision, you can ignore it. I made this fix on HEAD, searching for the functions there. I didn't use the 1.3.0 codebase. I just backported the patch for Gentoo. I'm waiting for 1.4.0 release to package it in Gentoo. Commit Message: https://review.coreboot.org/c/flashrom/+/83261/comment/58abf05f_a5f00dba?us… : PS1, Line 7: non-existant > non-existent (typo) Done -- To view, visit https://review.coreboot.org/c/flashrom/+/83261?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I30bab842d9cbd2daaa9902fd3223f47145cb0e7f Gerrit-Change-Number: 83261 Gerrit-PatchSet: 2 Gerrit-Owner: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Tue, 02 Jul 2024 17:19:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[XL] Change in flashrom[main]: [RFC] flashchips: Begin splitting flashchips by vendor
by Angel Pons (Code Review) 02 Jul '24

02 Jul '24

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/83307?usp=email ) Change subject: [RFC] flashchips: Begin splitting flashchips by vendor ...................................................................... [RFC] flashchips: Begin splitting flashchips by vendor To make the flashchips "database" easier to manage, split it by vendor into several smaller files. This commit transfers the bulk of the data to separate files and includes them from `flashchips.c`. Although this is ugly (.c includes are usually frowned upon), it is a necessary evil to make this commit reproducible. TODO: Test reproducibility. Change-Id: I3a9ebb0575e2700c5871d16875495d9c8943b30b Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M flashchips.c A flashchips/amd.c A flashchips/amic.c A flashchips/atmel.c A flashchips/boya_bohong.c A flashchips/bright.c A flashchips/catalyst.c A flashchips/ene.c A flashchips/eon.c A flashchips/esi.c A flashchips/esmt.c A flashchips/fudan.c A flashchips/fujitsu.c A flashchips/gigadevice.c A flashchips/hyundai.c A flashchips/intel.c A flashchips/issi.c A flashchips/macronix.c A flashchips/micron.c A flashchips/micron_numonyx_st.c A flashchips/mosel_vitelic.c A flashchips/nantronics.c A flashchips/pmc.c A flashchips/puya.c A flashchips/sanyo.c A flashchips/sharp.c A flashchips/spansion.c A flashchips/sst.c A flashchips/st.c A flashchips/syncmos_mosel_vitelic.c A flashchips/ti.c A flashchips/winbond.c A flashchips/xmc.c A flashchips/xtx.c A flashchips/zetta.c 35 files changed, 23,174 insertions(+), 22,490 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/07/83307/1 -- To view, visit https://review.coreboot.org/c/flashrom/+/83307?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I3a9ebb0575e2700c5871d16875495d9c8943b30b Gerrit-Change-Number: 83307 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit July 2024