July 2024 - flashrom-gerrit - mail.coreboot.org

[M] Change in flashrom[main]: flashchips: Add chip models GD25LB256F/GD25LR256F
by Victor Lim (Code Review) 04 Jul '24

04 Jul '24

Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer. Hello Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/83254?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins) Change subject: flashchips: Add chip models GD25LB256F/GD25LR256F ...................................................................... flashchips: Add chip models GD25LB256F/GD25LR256F GD25LB256F: 1.8V 256Mbit https://www.gigadevice.com.cn/Public/Uploads/uploadfile/files/20230926/DS-0… GD25LR256F: 1.8V 256Mbit with RPMC. https://www.gigadevice.com/message-board?cid=39&id=3171&file_type=Datasheet… Tested Erase, write, read, and protection. Change-Id: I0fbd270a57999d4131816c48470588bb7ec22d37 Signed-off-by: Victor <vlim(a)gigadevice.com> --- M flashchips.c 1 file changed, 57 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/54/83254/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/83254?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I0fbd270a57999d4131816c48470588bb7ec22d37 Gerrit-Change-Number: 83254 Gerrit-PatchSet: 3 Gerrit-Owner: Victor Lim <vlim(a)gigadevice.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com>

1 0

[M] Change in flashrom[main]: flashchips: Add chip models GD25LB256F/GD25LR256F
by Victor Lim (Code Review) 04 Jul '24

04 Jul '24

Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer. Victor Lim has posted comments on this change by Victor Lim. ( https://review.coreboot.org/c/flashrom/+/83254?usp=email ) Change subject: flashchips: Add chip models GD25LB256F/GD25LR256F ...................................................................... Patch Set 2: (1 comment) File flashchips.c: https://review.coreboot.org/c/flashrom/+/83254/comment/36c82d29_1a7a0f7a?us… : PS1, Line 7006: BP4 > Thanks, will change it and upload again Done -- To view, visit https://review.coreboot.org/c/flashrom/+/83254?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I0fbd270a57999d4131816c48470588bb7ec22d37 Gerrit-Change-Number: 83254 Gerrit-PatchSet: 2 Gerrit-Owner: Victor Lim <vlim(a)gigadevice.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Thu, 04 Jul 2024 07:04:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Victor Lim <vlim(a)gigadevice.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[M] Change in flashrom[main]: flashchips: Add chip models GD25LB256F/GD25LR256F
by Victor Lim (Code Review) 04 Jul '24

04 Jul '24

Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer. Victor Lim has posted comments on this change by Victor Lim. ( https://review.coreboot.org/c/flashrom/+/83254?usp=email ) Change subject: flashchips: Add chip models GD25LB256F/GD25LR256F ...................................................................... Patch Set 1: (1 comment) File flashchips.c: https://review.coreboot.org/c/flashrom/+/83254/comment/f076f3b8_32671c42?us… : PS1, Line 7006: BP4 > We usually add the full comment, as you can see in other chips […] Thanks, will change it and upload again -- To view, visit https://review.coreboot.org/c/flashrom/+/83254?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I0fbd270a57999d4131816c48470588bb7ec22d37 Gerrit-Change-Number: 83254 Gerrit-PatchSet: 1 Gerrit-Owner: Victor Lim <vlim(a)gigadevice.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Thu, 04 Jul 2024 06:47:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[M] Change in flashrom[main]: flashchips: Add chip models GD25LB256F/GD25LR256F
by Victor Lim (Code Review) 04 Jul '24

04 Jul '24

Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer. Victor Lim has posted comments on this change by Victor Lim. ( https://review.coreboot.org/c/flashrom/+/83254?usp=email ) Change subject: flashchips: Add chip models GD25LB256F/GD25LR256F ...................................................................... Patch Set 1: (1 comment) File flashchips.c: https://review.coreboot.org/c/flashrom/+/83254/comment/e2b33af2_b73d7293?us… : PS1, Line 6963: OTP: 1024B total, 256B reserved > Maybe you will help me, how do I find this info in datasheet? I found the commands, but not the size […] It is on the feature page which is at around page 5. (very first page of the datasheet) -- To view, visit https://review.coreboot.org/c/flashrom/+/83254?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I0fbd270a57999d4131816c48470588bb7ec22d37 Gerrit-Change-Number: 83254 Gerrit-PatchSet: 1 Gerrit-Owner: Victor Lim <vlim(a)gigadevice.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Thu, 04 Jul 2024 06:47:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[XS] Change in flashrom[main]: flashchips: Add Support for XMC XM25QH64D
by Anastasia Klimchuk (Code Review) 04 Jul '24

04 Jul '24

Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83237?usp=email ) Change subject: flashchips: Add Support for XMC XM25QH64D ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: Wait until the tag v1.4.0 done and after that the patch can be submitted. ETA 26 July. https://mail.coreboot.org/hyperkitty/list/flashrom@flashrom.org/thread/UUDQ… -- To view, visit https://review.coreboot.org/c/flashrom/+/83237?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ia3357cb2c30cbe34dcf0e06fd037064304b4c0c4 Gerrit-Change-Number: 83237 Gerrit-PatchSet: 2 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Ssunk <ssunkkan(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Thu, 04 Jul 2024 04:29:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in flashrom[main]: flashchips: Add Support for XMC XM25QU32C
by Anastasia Klimchuk (Code Review) 04 Jul '24

04 Jul '24

Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83236?usp=email ) Change subject: flashchips: Add Support for XMC XM25QU32C ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: Wait until the tag v1.4.0 done and after that the patch can be submitted. ETA 26 July. https://mail.coreboot.org/hyperkitty/list/flashrom@flashrom.org/thread/UUDQ… -- To view, visit https://review.coreboot.org/c/flashrom/+/83236?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ida0ab895309ef83dcc6b3f03c032a16f9b1f923a Gerrit-Change-Number: 83236 Gerrit-PatchSet: 2 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Ssunk <ssunkkan(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Thu, 04 Jul 2024 04:27:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in flashrom[main]: flashchips: Add Support for XMC XM25QU16C
by Ssunk (Code Review) 04 Jul '24

04 Jul '24

Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer. Ssunk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83234?usp=email ) Change subject: flashchips: Add Support for XMC XM25QU16C ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > But this is one is not done :) I marked the comment unresolved on purpose. […] Ok, I know,thanks -- To view, visit https://review.coreboot.org/c/flashrom/+/83234?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I0989b5dd239dd32f93e1a338a70e5d7279127d8d Gerrit-Change-Number: 83234 Gerrit-PatchSet: 1 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Thu, 04 Jul 2024 01:15:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Ssunk <ssunkkan(a)gmail.com>

1 0

[M] Change in flashrom[main]: flashchips: Add chip models GD25LB256F/GD25LR256F
by Anastasia Klimchuk (Code Review) 03 Jul '24

03 Jul '24

Attention is currently required from: Nikolai Artemiev, Stefan Reinauer, Victor Lim. Anastasia Klimchuk has posted comments on this change by Victor Lim. ( https://review.coreboot.org/c/flashrom/+/83254?usp=email ) Change subject: flashchips: Add chip models GD25LB256F/GD25LR256F ...................................................................... Patch Set 1: (2 comments) File flashchips.c: https://review.coreboot.org/c/flashrom/+/83254/comment/dc3ec86d_65feeb85?us… : PS1, Line 6963: OTP: 1024B total, 256B reserved Maybe you will help me, how do I find this info in datasheet? I found the commands, but not the size. Maybe you can point me to the section in the doc. Thank you! https://review.coreboot.org/c/flashrom/+/83254/comment/da150636_86570ac5?us… : PS1, Line 7006: BP4 We usually add the full comment, as you can see in other chips > Called BP4 in datasheet, acts like TB -- To view, visit https://review.coreboot.org/c/flashrom/+/83254?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I0fbd270a57999d4131816c48470588bb7ec22d37 Gerrit-Change-Number: 83254 Gerrit-PatchSet: 1 Gerrit-Owner: Victor Lim <vlim(a)gigadevice.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Victor Lim <vlim(a)gigadevice.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Wed, 03 Jul 2024 13:03:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in flashrom[main]: flashchips: Add Support for XMC XM25QH32C/XM25QH32D
by Anastasia Klimchuk (Code Review) 03 Jul '24

03 Jul '24

Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83235?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: flashchips: Add Support for XMC XM25QH32C/XM25QH32D ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Got it, thanks! I will mark this unresolved, this is a comment so that no one accidentally submits before the tag. -- To view, visit https://review.coreboot.org/c/flashrom/+/83235?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: Ib201ac28384b8db6539e2a82e6f90462d1393208 Gerrit-Change-Number: 83235 Gerrit-PatchSet: 1 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Ssunk <ssunkkan(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Wed, 03 Jul 2024 11:47:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ssunk <ssunkkan(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

[S] Change in flashrom[main]: flashchips: Add Support for XMC XM25QU16C
by Anastasia Klimchuk (Code Review) 03 Jul '24

03 Jul '24

Attention is currently required from: Nikolai Artemiev, Ssunk, Stefan Reinauer. Anastasia Klimchuk has posted comments on this change by Ssunk. ( https://review.coreboot.org/c/flashrom/+/83234?usp=email ) The change is no longer submittable: All-Comments-Resolved is unsatisfied now. Change subject: flashchips: Add Support for XMC XM25QU16C ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Done But this is one is not done :) I marked the comment unresolved on purpose. It will be done when we put a tag v1.4.0 and this is estimated on 26 July. -- To view, visit https://review.coreboot.org/c/flashrom/+/83234?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I0989b5dd239dd32f93e1a338a70e5d7279127d8d Gerrit-Change-Number: 83234 Gerrit-PatchSet: 1 Gerrit-Owner: Ssunk <ssunkkan(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Ssunk <ssunkkan(a)gmail.com> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Wed, 03 Jul 2024 11:46:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Ssunk <ssunkkan(a)gmail.com> Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org>

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit July 2024