flashrom-gerrit July 2024

flashrom-gerrit@flashrom.org

1 participants
183 discussions

[XS] Change in flashrom[main]: libflashrom.map: remove non-existant functions
by Anastasia Klimchuk (Code Review) 02 Jul '24

02 Jul '24

Attention is currently required from: Fabian Groffen, Peter Marheine. Anastasia Klimchuk has posted comments on this change by Fabian Groffen. ( https://review.coreboot.org/c/flashrom/+/83261?usp=email ) Change subject: libflashrom.map: remove non-existant functions ...................................................................... Patch Set 1: Code-Review+2 (2 comments) Patchset: PS1: Fabian, thank you for the patch! Commit Message: https://review.coreboot.org/c/flashrom/+/83261/comment/3b2c2b21_481d664b?us… : PS1, Line 7: non-existant non-existent (typo) -- To view, visit https://review.coreboot.org/c/flashrom/+/83261?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: I30bab842d9cbd2daaa9902fd3223f47145cb0e7f Gerrit-Change-Number: 83261 Gerrit-PatchSet: 1 Gerrit-Owner: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Attention: Fabian Groffen <grobian(a)gentoo.org> Gerrit-Comment-Date: Tue, 02 Jul 2024 03:06:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in flashrom[main]: ch347_spi: Add spi clock frequency selection
by ZhiYuanNJ (Code Review) 02 Jul '24

02 Jul '24

1 0

[S] Change in flashrom[main]: ch347_spi: Add spi clock frequency selection
by ZhiYuanNJ (Code Review) 01 Jul '24

01 Jul '24

Attention is currently required from: Anastasia Klimchuk, Nicholas Chin. ZhiYuanNJ has posted comments on this change by ZhiYuanNJ. ( https://review.coreboot.org/c/flashrom/+/82776?usp=email ) Change subject: ch347_spi: Add spi clock frequency selection ...................................................................... Patch Set 7: (4 comments) File ch347_spi.c: https://review.coreboot.org/c/flashrom/+/82776/comment/a8b52623_5481dab5?us… : PS7, Line 357: index = 0 > Let's use different variable name, index is already used for indexing the device table. […] Done https://review.coreboot.org/c/flashrom/+/82776/comment/cfc81251_9587a9e8?us… : PS7, Line 365: 30MHz > I don't mind changing the default if it generally works at 30 MHz. […] What is the CH347T device revision that can reproduce this phenomenon? https://review.coreboot.org/c/flashrom/+/82776/comment/309c527c_1c462d2e?us… : PS7, Line 365: Invalid SPI speed > It would be invalid value if you would throw an error and exit, however you do not, but instead cont […] Done https://review.coreboot.org/c/flashrom/+/82776/comment/ca2bf3af_a5217846?us… : PS7, Line 372: clock spi > "clock spi" is redundant here as clock is already mentioned earlier. […] Done -- To view, visit https://review.coreboot.org/c/flashrom/+/82776?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: flashrom Gerrit-Branch: main Gerrit-Change-Id: If2be48929db540a6598ac0b60b37e64597156db7 Gerrit-Change-Number: 82776 Gerrit-PatchSet: 7 Gerrit-Owner: ZhiYuanNJ Gerrit-Reviewer: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Nicholas Chin <nic.c3.14(a)gmail.com> Gerrit-Comment-Date: Mon, 01 Jul 2024 06:34:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Nicholas Chin <nic.c3.14(a)gmail.com>

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit July 2024