April 2023 - flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[master]: dummyflasher: Add ul parsing function for spi_status parameter
by Anastasia Klimchuk (Code Review) 21 Apr '23

21 Apr '23

Anastasia Klimchuk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/65933 ) Change subject: dummyflasher: Add ul parsing function for spi_status parameter ...................................................................... Abandoned The project was discontinued in mid-2022. It might be re-started again later, but that would be a fresh start. -- To view, visit https://review.coreboot.org/c/flashrom/+/65933 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I01e552b559e32f136bdb0540d0b364ef754252b1 Gerrit-Change-Number: 65933 Gerrit-PatchSet: 4 Gerrit-Owner: Chinmay Lonkar <chinmay20220(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[master]: dummyflasher: Add ul parsing function for spi_write_256_chunksize
by Anastasia Klimchuk (Code Review) 21 Apr '23

21 Apr '23

Anastasia Klimchuk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/65748 ) Change subject: dummyflasher: Add ul parsing function for spi_write_256_chunksize ...................................................................... Abandoned The project was discontinued in mid-2022. It might be re-started again later, but that would be a fresh start. -- To view, visit https://review.coreboot.org/c/flashrom/+/65748 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7132562a166df9ac75a8f916cf7699ed96bfc936 Gerrit-Change-Number: 65748 Gerrit-PatchSet: 12 Gerrit-Owner: Chinmay Lonkar <chinmay20220(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[master]: linux_spi: Add type-aware parsing function for spispeed
by Anastasia Klimchuk (Code Review) 21 Apr '23

21 Apr '23

Anastasia Klimchuk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/65791 ) Change subject: linux_spi: Add type-aware parsing function for spispeed ...................................................................... Abandoned The project was discontinued in mid-2022. It might be re-started again later, but that would be a fresh start. -- To view, visit https://review.coreboot.org/c/flashrom/+/65791 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ideb536dc45404a1a0b4ab6dfd9cdd04e118bdafd Gerrit-Change-Number: 65791 Gerrit-PatchSet: 12 Gerrit-Owner: Chinmay Lonkar <chinmay20220(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[master]: flashrom: Allow converting programmer parameters to uint
by Anastasia Klimchuk (Code Review) 21 Apr '23

21 Apr '23

Anastasia Klimchuk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/65078 ) Change subject: flashrom: Allow converting programmer parameters to uint ...................................................................... Abandoned The project was discontinued in mid-2022. It might be re-started again later, but that would be a fresh start. -- To view, visit https://review.coreboot.org/c/flashrom/+/65078 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I27de49412785556ff525c6d3fc917a74dca4fdc8 Gerrit-Change-Number: 65078 Gerrit-PatchSet: 33 Gerrit-Owner: Chinmay Lonkar <chinmay20220(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[refs/meta/config]: Grant "flashrom reviewers" group -1..+2 code review permissions
by Anastasia Klimchuk (Code Review) 21 Apr '23

21 Apr '23

Attention is currently required from: Anastasia Klimchuk. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/74631 to look at the new patch set (#3). Change subject: Grant "flashrom reviewers" group -1..+2 code review permissions ...................................................................... Grant "flashrom reviewers" group -1..+2 code review permissions Change-Id: I37dab0e85570c70c820354e2d0889ee7656751da --- M groups M project.config 2 files changed, 12 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/31/74631/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/74631 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: I37dab0e85570c70c820354e2d0889ee7656751da Gerrit-Change-Number: 74631 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[refs/meta/config]: Grant "flashrom reviewers" group +2 / -1 code review permissions
by Anastasia Klimchuk (Code Review) 21 Apr '23

21 Apr '23

Attention is currently required from: Anastasia Klimchuk. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/74631 to look at the new patch set (#2). Change subject: Grant "flashrom reviewers" group +2 / -1 code review permissions ...................................................................... Grant "flashrom reviewers" group +2 / -1 code review permissions Change-Id: I37dab0e85570c70c820354e2d0889ee7656751da --- M groups M project.config 2 files changed, 12 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/31/74631/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/74631 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: I37dab0e85570c70c820354e2d0889ee7656751da Gerrit-Change-Number: 74631 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[refs/meta/config]: Review access change
by Anastasia Klimchuk (Code Review) 21 Apr '23

21 Apr '23

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/74631 ) Change subject: Review access change ...................................................................... Review access change Change-Id: I37dab0e85570c70c820354e2d0889ee7656751da --- M groups M project.config 2 files changed, 12 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/31/74631/1 diff --git a/groups b/groups index 579c63c..6f6cb78 100644 --- a/groups +++ b/groups @@ -1,5 +1,6 @@ # UUID Group Name # +25cadc351dd0492fd2a2a1b1a8e5bb08c29e411f flashrom reviewers db95ce11b379445ac8c5806ea0b61195555b338d flashrom developers global:Project-Owners Project Owners user:Th3Fanbus user/Angel Pons (Th3Fanbus) diff --git a/project.config b/project.config index 57c54c8..1b4989b 100644 --- a/project.config +++ b/project.config @@ -46,7 +46,7 @@ owner = group user/David Hendricks (dhendrix) owner = group user/build bot (Jenkins) (jenkins) [access "refs/heads/*"] - exclusiveGroupPermissions = create delete submit + exclusiveGroupPermissions = create delete label-Code-Review submit create = group user/Anastasia Klimchuk (aklm) create = group user/Angel Pons (Th3Fanbus) create = group user/David Hendricks (dhendrix) @@ -55,6 +55,7 @@ delete = group user/David Hendricks (dhendrix) submit = group flashrom developers label-Code-Review = -2..+2 group flashrom developers + label-Code-Review = -1..+2 group flashrom reviewers label-Verified = -1..+1 group flashrom developers [access "refs/for/refs/heads/stable"] exclusiveGroupPermissions = push -- To view, visit https://review.coreboot.org/c/flashrom/+/74631 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: I37dab0e85570c70c820354e2d0889ee7656751da Gerrit-Change-Number: 74631 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: cli_classic: move version output outside of parsing
by Alexander Goncharov (Code Review) 20 Apr '23

20 Apr '23

Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk. Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66535 ) Change subject: cli_classic: move version output outside of parsing ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://review.coreboot.org/c/flashrom/+/66535 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I1e6849a734480deed030191fa5e7066b1da4f23a Gerrit-Change-Number: 66535 Gerrit-PatchSet: 2 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 20 Apr 2023 12:48:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: cli_classic: move usage output outside of parsing
by Alexander Goncharov (Code Review) 20 Apr '23

20 Apr '23

Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk. Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66534 ) Change subject: cli_classic: move usage output outside of parsing ...................................................................... Patch Set 2: This change is ready for review. -- To view, visit https://review.coreboot.org/c/flashrom/+/66534 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie1159b3efd8130fdc409a8908dc61102fa8b3fd1 Gerrit-Change-Number: 66534 Gerrit-PatchSet: 2 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Thu, 20 Apr 2023 12:47:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: Makefile: do not generate man page when building sources
by Alexander Goncharov (Code Review) 20 Apr '23

20 Apr '23

Alexander Goncharov has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/74510 ) Change subject: Makefile: do not generate man page when building sources ...................................................................... Abandoned CB:74519 -- To view, visit https://review.coreboot.org/c/flashrom/+/74510 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9882445de2a0996f237470a73b6a1eb7eafce808 Gerrit-Change-Number: 74510 Gerrit-PatchSet: 1 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2023