April 2023 - flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[refs/meta/config]: Grant "flashrom reviewers" group -1..+2 code review permissions
by Stefan Reinauer (Code Review) 21 Apr '23

21 Apr '23

Attention is currently required from: Martin L Roth, Thomas Heijligen, Angel Pons, Anastasia Klimchuk. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74631 ) Change subject: Grant "flashrom reviewers" group -1..+2 code review permissions ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/74631 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: I37dab0e85570c70c820354e2d0889ee7656751da Gerrit-Change-Number: 74631 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 21 Apr 2023 14:14:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in flashrom[master]: flaschips.c: Fix building with CONFIG_DUMMY=no
by Arthur Heymans (Code Review) 21 Apr '23

21 Apr '23

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/47166 ) Change subject: flaschips.c: Fix building with CONFIG_DUMMY=no ...................................................................... flaschips.c: Fix building with CONFIG_DUMMY=no With CONFIG_DUMMY=yes dummuflasher.c is not linked in so there is definition of probe_variable_size. Change-Id: Ib9bae93fadc55cf133e837e63419da104a6298be Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M flashchips.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/66/47166/1 diff --git a/flashchips.c b/flashchips.c index 48efb85..1681f42 100644 --- a/flashchips.c +++ b/flashchips.c @@ -19081,3 +19081,7 @@ }; const unsigned int flashchips_size = ARRAY_SIZE(flashchips); + +#if !CONFIG_DUMMY +int probe_variable_size(struct flashctx *flash) { return 0; }; +#endif -- To view, visit https://review.coreboot.org/c/flashrom/+/47166 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ib9bae93fadc55cf133e837e63419da104a6298be Gerrit-Change-Number: 47166 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newchange

5 12

[M] Change in flashrom[master]: flashchips: Add support for IS25WP016
by Anastasia Klimchuk (Code Review) 21 Apr '23

21 Apr '23

Attention is currently required from: Angel Pons, Alex Mikhalev. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70140 ) Change subject: flashchips: Add support for IS25WP016 ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Hello Alex, sorry for delay: are you still here? (hopefully :) ) I see there are just two comments for the patch? I will also have a look. -- To view, visit https://review.coreboot.org/c/flashrom/+/70140 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I2b8caea229ffda72f1b04183c31715faccb64ad5 Gerrit-Change-Number: 70140 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Mikhalev <alex(a)corvus-robotics.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Alex Mikhalev <alex(a)corvus-robotics.com> Gerrit-Comment-Date: Fri, 21 Apr 2023 10:17:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: flashrom: rewrite flashbuses_to_text()
by Anastasia Klimchuk (Code Review) 21 Apr '23

21 Apr '23

Attention is currently required from: Edward O'Callaghan, Angel Pons, Alexander Goncharov. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73039 ) Change subject: flashrom: rewrite flashbuses_to_text() ...................................................................... Patch Set 7: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/73039/comment/5923dd85_53f8eb51 PS6, Line 17: `printf()` > Oh, my bad. I just tested it on my GNU implementation, which produces fancy `(null)` output. […] I am fine with `?` -- To view, visit https://review.coreboot.org/c/flashrom/+/73039 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I59b9044c99b4ba6c00d8c97f1e91af09d70dce2c Gerrit-Change-Number: 73039 Gerrit-PatchSet: 7 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Fri, 21 Apr 2023 10:12:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Comment-In-Reply-To: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[refs/meta/config]: Grant "flashrom reviewers" group -1..+2 code review permissions
by Anastasia Klimchuk (Code Review) 21 Apr '23

21 Apr '23

Attention is currently required from: Martin L Roth, Stefan Reinauer, Thomas Heijligen, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74631 ) Change subject: Grant "flashrom reviewers" group -1..+2 code review permissions ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: I don't fully understand why jenkins gave -1 https://qa.coreboot.org/job/flashrom_gerrit/10950/console doesn't seem related to the patch? -- To view, visit https://review.coreboot.org/c/flashrom/+/74631 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: I37dab0e85570c70c820354e2d0889ee7656751da Gerrit-Change-Number: 74631 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 21 Apr 2023 10:00:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: dummyflasher: Add function for parsing hex values
by Anastasia Klimchuk (Code Review) 21 Apr '23

21 Apr '23

Anastasia Klimchuk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/65927 ) Change subject: dummyflasher: Add function for parsing hex values ...................................................................... Abandoned The project was discontinued in mid-2022. It might be re-started again later, but that would be a fresh start. -- To view, visit https://review.coreboot.org/c/flashrom/+/65927 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3a7db9067186f77740ef1ea68f76ed8df35d2bc6 Gerrit-Change-Number: 65927 Gerrit-PatchSet: 3 Gerrit-Owner: Chinmay Lonkar <chinmay20220(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[M] Change in flashrom[master]: flashrom.c: Add function for parsing hex values from str
by Anastasia Klimchuk (Code Review) 21 Apr '23

21 Apr '23

Anastasia Klimchuk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/65925 ) Change subject: flashrom.c: Add function for parsing hex values from str ...................................................................... Abandoned The project was discontinued in mid-2022. It might be re-started again later, but that would be a fresh start. -- To view, visit https://review.coreboot.org/c/flashrom/+/65925 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I589a69b652a2649c2afc8aa197a6abded437eb3b Gerrit-Change-Number: 65925 Gerrit-PatchSet: 8 Gerrit-Owner: Chinmay Lonkar <chinmay20220(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[master]: dummyflasher: Add ul parsing function for spi_status parameter
by Anastasia Klimchuk (Code Review) 21 Apr '23

21 Apr '23

Anastasia Klimchuk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/65933 ) Change subject: dummyflasher: Add ul parsing function for spi_status parameter ...................................................................... Abandoned The project was discontinued in mid-2022. It might be re-started again later, but that would be a fresh start. -- To view, visit https://review.coreboot.org/c/flashrom/+/65933 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I01e552b559e32f136bdb0540d0b364ef754252b1 Gerrit-Change-Number: 65933 Gerrit-PatchSet: 4 Gerrit-Owner: Chinmay Lonkar <chinmay20220(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[master]: dummyflasher: Add ul parsing function for spi_write_256_chunksize
by Anastasia Klimchuk (Code Review) 21 Apr '23

21 Apr '23

Anastasia Klimchuk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/65748 ) Change subject: dummyflasher: Add ul parsing function for spi_write_256_chunksize ...................................................................... Abandoned The project was discontinued in mid-2022. It might be re-started again later, but that would be a fresh start. -- To view, visit https://review.coreboot.org/c/flashrom/+/65748 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I7132562a166df9ac75a8f916cf7699ed96bfc936 Gerrit-Change-Number: 65748 Gerrit-PatchSet: 12 Gerrit-Owner: Chinmay Lonkar <chinmay20220(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[master]: linux_spi: Add type-aware parsing function for spispeed
by Anastasia Klimchuk (Code Review) 21 Apr '23

21 Apr '23

Anastasia Klimchuk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/65791 ) Change subject: linux_spi: Add type-aware parsing function for spispeed ...................................................................... Abandoned The project was discontinued in mid-2022. It might be re-started again later, but that would be a fresh start. -- To view, visit https://review.coreboot.org/c/flashrom/+/65791 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ideb536dc45404a1a0b4ab6dfd9cdd04e118bdafd Gerrit-Change-Number: 65791 Gerrit-PatchSet: 12 Gerrit-Owner: Chinmay Lonkar <chinmay20220(a)gmail.com> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: abandon

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2023