Change in flashrom[master]: flaschips.c: Fix building with CONFIG_DUMMY=no

[Arthur Heymans (Code Review)]

Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/47166 )


Change subject: flaschips.c: Fix building with CONFIG_DUMMY=no
......................................................................

flaschips.c: Fix building with CONFIG_DUMMY=no

With CONFIG_DUMMY=yes dummuflasher.c is not linked in so there is
definition of probe_variable_size.

Change-Id: Ib9bae93fadc55cf133e837e63419da104a6298be
Signed-off-by: Arthur Heymans <[e-mail]>
---
M flashchips.c
1 file changed, 4 insertions(+), 0 deletions(-)



  git pull ssh://review.coreboot.org:29418/flashrom refs/changes/66/47166/1

diff --git a/flashchips.c b/flashchips.c
index 48efb85..1681f42 100644
--- a/flashchips.c
+++ b/flashchips.c
@@ -19081,3 +19081,7 @@
 };
 
 const unsigned int flashchips_size = ARRAY_SIZE(flashchips);
+
+#if !CONFIG_DUMMY
+int probe_variable_size(struct flashctx *flash) { return 0; };
+#endif

-- 
To view, visit https://review.coreboot.org/c/flashrom/+/47166
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib9bae93fadc55cf133e837e63419da104a6298be
Gerrit-Change-Number: 47166
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <[e-mail]>
Gerrit-MessageType: newchange

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47166 )

Change subject: flaschips.c: Fix building with CONFIG_DUMMY=no
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/c/flashrom/+/47166/1/flashchips.c 
File flashchips.c:

https://review.coreboot.org/c/flashrom/+/47166/1/flashchips.c@19086 
PS1, Line 19086: int probe_variable_size(struct flashctx *flash) { return 0; };
declaration is in chipdrivers.h, maybe place this definition there as static inline?



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/47166
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib9bae93fadc55cf133e837e63419da104a6298be
Gerrit-Change-Number: 47166
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Comment-Date: Tue, 03 Nov 2020 14:21:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47166 )

Change subject: flaschips.c: Fix building with CONFIG_DUMMY=no
......................................................................


Patch Set 1:

(1 comment)

https://review.coreboot.org/c/flashrom/+/47166/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/flashrom/+/47166/1//COMMIT_MSG@9 
PS1, Line 9: is
           : definition
is *no* definition



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/47166
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib9bae93fadc55cf133e837e63419da104a6298be
Gerrit-Change-Number: 47166
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Comment-Date: Tue, 03 Nov 2020 14:24:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[Nikolai Artemiev (Code Review)]

Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev.
Nikolai Artemiev has uploaded a new patch set (#2) to the change originally created by Arthur Heymans. ( https://review.coreboot.org/c/flashrom/+/47166 )

Change subject: flaschips.c: Fix building with CONFIG_DUMMY=no
......................................................................

flaschips.c: Fix building with CONFIG_DUMMY=no

With CONFIG_DUMMY=yes dummuflasher.c is not linked in so there is
definition of probe_variable_size.

BUG=none
BRANCH=none
TEST=CONFIG_DUMMY=0 make && CONFIG_DUMMY=1 make

Change-Id: Ib9bae93fadc55cf133e837e63419da104a6298be
Signed-off-by: Arthur Heymans <[e-mail]>
Signed-off-by: Nikolai Artemiev <[e-mail]>
Co-authored-by: Nikolai Artemiev <[e-mail]>
---
M chipdrivers.h
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://review.coreboot.org:29418/flashrom refs/changes/66/47166/2
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/47166
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib9bae93fadc55cf133e837e63419da104a6298be
Gerrit-Change-Number: 47166
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Nikolai Artemiev <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Attention: Edward O'Callaghan <[e-mail]>
Gerrit-Attention: Nikolai Artemiev <[e-mail]>
Gerrit-MessageType: newpatchset

[Nikolai Artemiev (Code Review)]

Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev.
Nikolai Artemiev has uploaded a new patch set (#3) to the change originally created by Arthur Heymans. ( https://review.coreboot.org/c/flashrom/+/47166 )

Change subject: flaschips.c: Fix building with CONFIG_DUMMY=no
......................................................................

flaschips.c: Fix building with CONFIG_DUMMY=no

With CONFIG_DUMMY=yes dummuflasher.c is not linked in so there is no
definition of probe_variable_size.

BUG=none
BRANCH=none
TEST=CONFIG_DUMMY=0 make && CONFIG_DUMMY=1 make

Change-Id: Ib9bae93fadc55cf133e837e63419da104a6298be
Signed-off-by: Arthur Heymans <[e-mail]>
Signed-off-by: Nikolai Artemiev <[e-mail]>
Co-authored-by: Nikolai Artemiev <[e-mail]>
---
M include/chipdrivers.h
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://review.coreboot.org:29418/flashrom refs/changes/66/47166/3
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/47166
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib9bae93fadc55cf133e837e63419da104a6298be
Gerrit-Change-Number: 47166
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Nikolai Artemiev <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Attention: Edward O'Callaghan <[e-mail]>
Gerrit-Attention: Nikolai Artemiev <[e-mail]>
Gerrit-MessageType: newpatchset

[Nikolai Artemiev (Code Review)]

Attention is currently required from: Edward O'Callaghan, Angel Pons, Arthur Heymans.
Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47166 )

Change subject: flaschips.c: Fix building with CONFIG_DUMMY=no
......................................................................


Patch Set 3:

(3 comments)

Commit Message:

https://review.coreboot.org/c/flashrom/+/47166/comment/3ee0683c_0ce1ec8c 
PS1, Line 9: is
           : definition
> is *no* definition
> Done

Patchset:

PS3: 
Saw this waiting around in my gerrit dashboard, decided to resolve comments.


File flashchips.c:

https://review.coreboot.org/c/flashrom/+/47166/comment/8962e73a_c51d198d 
PS1, Line 19086: int probe_variable_size(struct flashctx *flash) { return 0; };
> declaration is in chipdrivers. […]
> Done

[Felix Singer (Code Review)]

Attention is currently required from: Edward O'Callaghan, Angel Pons, Arthur Heymans, Nikolai Artemiev.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47166 )

Change subject: flaschips.c: Fix building with CONFIG_DUMMY=no
......................................................................


Patch Set 3: Code-Review+2

(1 comment)

Commit Message:

https://review.coreboot.org/c/flashrom/+/47166/comment/c44bc3fd_023486c9 
PS3, Line 7: flaschips
flas*h*chips.c



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/47166
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib9bae93fadc55cf133e837e63419da104a6298be
Gerrit-Change-Number: 47166
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Felix Singer <[e-mail]>
Gerrit-Reviewer: Nikolai Artemiev <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Attention: Edward O'Callaghan <[e-mail]>
Gerrit-Attention: Angel Pons <[e-mail]>
Gerrit-Attention: Arthur Heymans <[e-mail]>
Gerrit-Attention: Nikolai Artemiev <[e-mail]>
Gerrit-Comment-Date: Thu, 19 May 2022 22:48:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

[Anastasia Klimchuk (Code Review)]

Attention is currently required from: Edward O'Callaghan, Angel Pons, Arthur Heymans, Nikolai Artemiev.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47166 )

Change subject: flaschips.c: Fix building with CONFIG_DUMMY=no
......................................................................


Patch Set 3:

(1 comment)

Patchset:

PS3: 
Oh wait I have a fix https://review.coreboot.org/c/flashrom/+/64488 ! Please review my fix :)



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/47166
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib9bae93fadc55cf133e837e63419da104a6298be
Gerrit-Change-Number: 47166
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Felix Singer <[e-mail]>
Gerrit-Reviewer: Nikolai Artemiev <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Anastasia Klimchuk <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-Attention: Edward O'Callaghan <[e-mail]>
Gerrit-Attention: Angel Pons <[e-mail]>
Gerrit-Attention: Arthur Heymans <[e-mail]>
Gerrit-Attention: Nikolai Artemiev <[e-mail]>
Gerrit-Comment-Date: Fri, 20 May 2022 01:22:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

[Anastasia Klimchuk (Code Review)]

Attention is currently required from: Edward O'Callaghan, Angel Pons, Arthur Heymans, Nikolai Artemiev.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47166 )

Change subject: flaschips.c: Fix building with CONFIG_DUMMY=no
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

Patchset:

PS3:
> Oh wait I have a fix https://review.coreboot. […]
> Just to be clear what I meant to say: I prefer CB:64488 instead of this patch, because I prefer to fix the issue in a proper way.
> This patch looks like a workaround and not a fix.
> I hope you won't get upset of -1 !

[Felix Singer (Code Review)]

Attention is currently required from: Edward O'Callaghan, Angel Pons, Arthur Heymans, Anastasia Klimchuk, Nikolai Artemiev.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47166 )

Change subject: flaschips.c: Fix building with CONFIG_DUMMY=no
......................................................................


Patch Set 3: -Code-Review

(1 comment)

Patchset:

PS3:
> Just to be clear what I meant to say: I prefer CB:64488 instead of this patch, because I prefer to f […]
> Awesome! Of course not 😊 Removing my +2.

[Nikolai Artemiev (Code Review)]

Attention is currently required from: Felix Singer, Edward O'Callaghan, Angel Pons, Arthur Heymans, Anastasia Klimchuk.
Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47166 )

Change subject: flaschips.c: Fix building with CONFIG_DUMMY=no
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

Patchset:

PS3:
> Awesome! Of course not 😊 Removing my +2.
> +1, we should use CB:64488 instead

[S] Change in flashrom[master]: flaschips.c: Fix building with CONFIG_DUMMY=no

[Anastasia Klimchuk (Code Review)]

Attention is currently required from: Edward O'Callaghan, Angel Pons, Arthur Heymans, Nikolai Artemiev.

Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/47166 )

Change subject: flaschips.c: Fix building with CONFIG_DUMMY=no
......................................................................


Patch Set 3:

(1 comment)

Patchset:

PS3:
> Hello Arthur! Building without dummy got fixed in CB:64488 and the fix is merged. […]
> Arthur I think I will abandon the patch , I have a button now. Original issue fixed in CB:64488 and it's better to abandon to avoid confusion. Hope you are fine with this !

[S] Change in flashrom[master]: flaschips.c: Fix building with CONFIG_DUMMY=no

[Anastasia Klimchuk (Code Review)]

Anastasia Klimchuk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/47166 )

Change subject: flaschips.c: Fix building with CONFIG_DUMMY=no
......................................................................


Abandoned

fixed in CB:64488
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/47166
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib9bae93fadc55cf133e837e63419da104a6298be
Gerrit-Change-Number: 47166
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans <[e-mail]>
Gerrit-Reviewer: Anastasia Klimchuk <[e-mail]>
Gerrit-Reviewer: Angel Pons <[e-mail]>
Gerrit-Reviewer: Edward O'Callaghan <[e-mail]>
Gerrit-Reviewer: Nikolai Artemiev <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-CC: Paul Menzel <[e-mail]>
Gerrit-MessageType: abandon