April 2023 - flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[refs/meta/config]: Grant "flashrom reviewers" group -1..+2 code review permissions
by Anastasia Klimchuk (Code Review) 22 Apr '23

22 Apr '23

Anastasia Klimchuk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/74631 ) Change subject: Grant "flashrom reviewers" group -1..+2 code review permissions ...................................................................... Abandoned found a mistake, CB:74691 is the correct patch -- To view, visit https://review.coreboot.org/c/flashrom/+/74631 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: I37dab0e85570c70c820354e2d0889ee7656751da Gerrit-Change-Number: 74631 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[refs/meta/config]: Grant "flashrom reviewers" group -1..+2 for code review
by Stefan Reinauer (Code Review) 21 Apr '23

21 Apr '23

Attention is currently required from: Martin L Roth, Thomas Heijligen, Angel Pons, Anastasia Klimchuk. Stefan Reinauer has removed a vote from this change. ( https://review.coreboot.org/c/flashrom/+/74691 ) Change subject: Grant "flashrom reviewers" group -1..+2 for code review ...................................................................... Removed Verified-1 by build bot (Jenkins) <no-reply(a)coreboot.org> -- To view, visit https://review.coreboot.org/c/flashrom/+/74691 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: Idd8aba708d0d9b8d93f4a2893dafc407d5b77de1 Gerrit-Change-Number: 74691 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: deleteVote

1 0

[S] Change in flashrom[refs/meta/config]: Grant "flashrom reviewers" group -1..+2 for code review
by Stefan Reinauer (Code Review) 21 Apr '23

21 Apr '23

Attention is currently required from: Martin L Roth, Thomas Heijligen, Angel Pons, Anastasia Klimchuk. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74691 ) Change subject: Grant "flashrom reviewers" group -1..+2 for code review ...................................................................... Patch Set 2: Verified+1 Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/74691 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: Idd8aba708d0d9b8d93f4a2893dafc407d5b77de1 Gerrit-Change-Number: 74691 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 21 Apr 2023 23:47:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[refs/meta/config]: Grant "flashrom reviewers" group -1..+2 code review permissions
by Anastasia Klimchuk (Code Review) 21 Apr '23

21 Apr '23

Attention is currently required from: Martin L Roth, Thomas Heijligen, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74631 ) Change subject: Grant "flashrom reviewers" group -1..+2 code review permissions ...................................................................... Patch Set 3: Code-Review-1 (1 comment) Patchset: PS3: I apologise, I made a mistake in this patch, only realised just now! Code review config needs to have -1..+1 for all registered users set explicitly, because now code review becomes exclusive. I created CB:74691 which should be correct. Stefan thank you so much for your help! -- To view, visit https://review.coreboot.org/c/flashrom/+/74631 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: I37dab0e85570c70c820354e2d0889ee7656751da Gerrit-Change-Number: 74631 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 21 Apr 2023 23:41:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[refs/meta/config]: Grant "flashrom reviewers" group -1..+2 for code review
by Anastasia Klimchuk (Code Review) 21 Apr '23

21 Apr '23

Attention is currently required from: Anastasia Klimchuk. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/74691 to look at the new patch set (#2). Change subject: Grant "flashrom reviewers" group -1..+2 for code review ...................................................................... Grant "flashrom reviewers" group -1..+2 for code review The goal is to have the following config: -2..+2 flashrom developers (same as it is) -1..+2 flashrom reviewers -1..+1 all registered users Change-Id: Idd8aba708d0d9b8d93f4a2893dafc407d5b77de1 --- M groups M project.config 2 files changed, 19 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/91/74691/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/74691 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: Idd8aba708d0d9b8d93f4a2893dafc407d5b77de1 Gerrit-Change-Number: 74691 Gerrit-PatchSet: 2 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[refs/meta/config]: Review access change
by Anastasia Klimchuk (Code Review) 21 Apr '23

21 Apr '23

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/74691 ) Change subject: Review access change ...................................................................... Review access change Change-Id: Idd8aba708d0d9b8d93f4a2893dafc407d5b77de1 --- M groups M project.config 2 files changed, 14 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/91/74691/1 diff --git a/groups b/groups index 579c63c..ca8045d 100644 --- a/groups +++ b/groups @@ -1,7 +1,9 @@ # UUID Group Name # +25cadc351dd0492fd2a2a1b1a8e5bb08c29e411f flashrom reviewers db95ce11b379445ac8c5806ea0b61195555b338d flashrom developers global:Project-Owners Project Owners +global:Registered-Users Registered Users user:Th3Fanbus user/Angel Pons (Th3Fanbus) user:aklm user/Anastasia Klimchuk (aklm) user:dhendrix user/David Hendricks (dhendrix) diff --git a/project.config b/project.config index 57c54c8..8c30ea3 100644 --- a/project.config +++ b/project.config @@ -46,7 +46,7 @@ owner = group user/David Hendricks (dhendrix) owner = group user/build bot (Jenkins) (jenkins) [access "refs/heads/*"] - exclusiveGroupPermissions = create delete submit + exclusiveGroupPermissions = create delete label-Code-Review submit create = group user/Anastasia Klimchuk (aklm) create = group user/Angel Pons (Th3Fanbus) create = group user/David Hendricks (dhendrix) @@ -55,6 +55,8 @@ delete = group user/David Hendricks (dhendrix) submit = group flashrom developers label-Code-Review = -2..+2 group flashrom developers + label-Code-Review = -1..+2 group flashrom reviewers + label-Code-Review = -1..+1 group Registered Users label-Verified = -1..+1 group flashrom developers [access "refs/for/refs/heads/stable"] exclusiveGroupPermissions = push -- To view, visit https://review.coreboot.org/c/flashrom/+/74691 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: Idd8aba708d0d9b8d93f4a2893dafc407d5b77de1 Gerrit-Change-Number: 74691 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[refs/meta/config]: Review access change
by Anastasia Klimchuk (Code Review) 21 Apr '23

21 Apr '23

Anastasia Klimchuk has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/74690 ) Change subject: Review access change ...................................................................... Abandoned forgot to set "exclusive" for code reviews -- To view, visit https://review.coreboot.org/c/flashrom/+/74690 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: I8aee995f061a63ade9828f53f094d6915f8d3f9e Gerrit-Change-Number: 74690 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

[S] Change in flashrom[refs/meta/config]: Review access change
by Anastasia Klimchuk (Code Review) 21 Apr '23

21 Apr '23

Anastasia Klimchuk has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/74690 ) Change subject: Review access change ...................................................................... Review access change Change-Id: I8aee995f061a63ade9828f53f094d6915f8d3f9e --- M groups M project.config 2 files changed, 13 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/90/74690/1 diff --git a/groups b/groups index 579c63c..ca8045d 100644 --- a/groups +++ b/groups @@ -1,7 +1,9 @@ # UUID Group Name # +25cadc351dd0492fd2a2a1b1a8e5bb08c29e411f flashrom reviewers db95ce11b379445ac8c5806ea0b61195555b338d flashrom developers global:Project-Owners Project Owners +global:Registered-Users Registered Users user:Th3Fanbus user/Angel Pons (Th3Fanbus) user:aklm user/Anastasia Klimchuk (aklm) user:dhendrix user/David Hendricks (dhendrix) diff --git a/project.config b/project.config index 57c54c8..2c80197 100644 --- a/project.config +++ b/project.config @@ -55,6 +55,8 @@ delete = group user/David Hendricks (dhendrix) submit = group flashrom developers label-Code-Review = -2..+2 group flashrom developers + label-Code-Review = -1..+2 group flashrom reviewers + label-Code-Review = -1..+1 group Registered Users label-Verified = -1..+1 group flashrom developers [access "refs/for/refs/heads/stable"] exclusiveGroupPermissions = push -- To view, visit https://review.coreboot.org/c/flashrom/+/74690 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: I8aee995f061a63ade9828f53f094d6915f8d3f9e Gerrit-Change-Number: 74690 Gerrit-PatchSet: 1 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[refs/meta/config]: Grant "flashrom reviewers" group -1..+2 code review permissions
by Stefan Reinauer (Code Review) 21 Apr '23

21 Apr '23

Attention is currently required from: Martin L Roth, Thomas Heijligen, Angel Pons, Anastasia Klimchuk. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74631 ) Change subject: Grant "flashrom reviewers" group -1..+2 code review permissions ...................................................................... Patch Set 3: Verified+1 (1 comment) Patchset: PS3: > I don't fully understand why jenkins gave -1 https://qa.coreboot. […] Formally this meta data lands in the flashrom git repository. I think we do a catch-all to build flashrom for all changes to that repository. That's great to get branches build tested automatically but in this case there is no flashrom source code checked out and things fail. I will manually override Verified. -- To view, visit https://review.coreboot.org/c/flashrom/+/74631 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: I37dab0e85570c70c820354e2d0889ee7656751da Gerrit-Change-Number: 74631 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Fri, 21 Apr 2023 14:26:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[refs/meta/config]: Grant "flashrom reviewers" group -1..+2 code review permissions
by Stefan Reinauer (Code Review) 21 Apr '23

21 Apr '23

Attention is currently required from: Martin L Roth, Thomas Heijligen, Angel Pons, Anastasia Klimchuk. Stefan Reinauer has removed a vote from this change. ( https://review.coreboot.org/c/flashrom/+/74631 ) Change subject: Grant "flashrom reviewers" group -1..+2 code review permissions ...................................................................... Removed Verified-1 by build bot (Jenkins) <no-reply(a)coreboot.org> -- To view, visit https://review.coreboot.org/c/flashrom/+/74631 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: refs/meta/config Gerrit-Change-Id: I37dab0e85570c70c820354e2d0889ee7656751da Gerrit-Change-Number: 74631 Gerrit-PatchSet: 3 Gerrit-Owner: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: deleteVote

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2023