April 2023 - flashrom-gerrit - mail.coreboot.org

[S] Change in flashrom[master]: usb_device.c: remove LIBUSB() wrapper around call that may fail
by Nikolai Artemiev (Code Review) 19 Apr '23

19 Apr '23

Attention is currently required from: Edward O'Callaghan. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74537 ) Change subject: usb_device.c: remove LIBUSB() wrapper around call that may fail ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Note: this is an alternate fix to the revert: https://review.coreboot.org/c/flashrom/+/67073 -- To view, visit https://review.coreboot.org/c/flashrom/+/74537 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I38e4642bcbddaf3f37821093f6b919806134ed7b Gerrit-Change-Number: 74537 Gerrit-PatchSet: 1 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Wed, 19 Apr 2023 07:28:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: usb_device.c: remove LIBUSB() wrapper around call that may fail
by Nikolai Artemiev (Code Review) 19 Apr '23

19 Apr '23

Nikolai Artemiev has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/74537 ) Change subject: usb_device.c: remove LIBUSB() wrapper around call that may fail ...................................................................... usb_device.c: remove LIBUSB() wrapper around call that may fail The libusb_detach_kernel_driver() call may return LIBUSB_ERROR_NOT_FOUND, which should not be treated as an error. Wrapping the call in LIBUSB() caused the error code to be transformed by LIBUSB_ERROR(), so LIBUSB_ERROR_NOT_FOUND was not recognized at the call site and was treated as a real error. BUG=b:278635575 TEST=flashrom -p raiden_debug_spi:target=AP BRANCH=none Change-Id: I38e4642bcbddaf3f37821093f6b919806134ed7b Signed-off-by: Nikolai Artemiev <nartemiev(a)google.com> --- M usb_device.c 1 file changed, 23 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/37/74537/1 diff --git a/usb_device.c b/usb_device.c index c9c8d92..0c8e3e2 100644 --- a/usb_device.c +++ b/usb_device.c @@ -342,8 +342,8 @@ } } - ret = LIBUSB(libusb_detach_kernel_driver(device->handle, - device->interface_descriptor->bInterfaceNumber)); + ret = libusb_detach_kernel_driver(device->handle, + device->interface_descriptor->bInterfaceNumber); if (ret != 0 && ret != LIBUSB_ERROR_NOT_FOUND && ret != LIBUSB_ERROR_NOT_SUPPORTED) { msg_perr("Cannot detach the existing usb driver. %s\n", libusb_error_name(ret)); -- To view, visit https://review.coreboot.org/c/flashrom/+/74537 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I38e4642bcbddaf3f37821093f6b919806134ed7b Gerrit-Change-Number: 74537 Gerrit-PatchSet: 1 Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: newchange

1 0

[M] Change in flashrom[master]: linux_mtd.c: Split linux_mtd_init() into sub-functions
by Nikolai Artemiev (Code Review) 19 Apr '23

19 Apr '23

Attention is currently required from: Edward O'Callaghan. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73494 ) Change subject: linux_mtd.c: Split linux_mtd_init() into sub-functions ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/73494 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic81068adbc7da8b28de07a161b5cec2fff0fce49 Gerrit-Change-Number: 73494 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Wed, 19 Apr 2023 06:47:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: linux_mtd.c: Factor out detection phases from setup func
by Nikolai Artemiev (Code Review) 19 Apr '23

19 Apr '23

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73495 ) Change subject: linux_mtd.c: Factor out detection phases from setup func ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Can you split this chain in independent ones? It is quite hard to keep track of every change in it. +1, maybe add a patch that moves linux_mtd_setup to its current location, then apply this patch on top, that should be easier to follow -- To view, visit https://review.coreboot.org/c/flashrom/+/73495 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I15915b71e1a030548c5f082cde78c42ece28bb37 Gerrit-Change-Number: 73495 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Wed, 19 Apr 2023 06:45:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: util/flashchips_db_parser: Add initial rust flashchip json parser
by Nikolai Artemiev (Code Review) 19 Apr '23

19 Apr '23

Attention is currently required from: Edward O'Callaghan. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74166 ) Change subject: util/flashchips_db_parser: Add initial rust flashchip json parser ...................................................................... Patch Set 2: (2 comments) File util/flashchips_db_parser/src/main.rs: https://review.coreboot.org/c/flashrom/+/74166/comment/ab5d1d52_047ff1ca PS2, Line 4: Copyright (C) 2023 Google Australia. I believe this should be `Copyright 2023 Google LLC` ditto in other files File util/flashchips_db_parser/src/parser.rs: https://review.coreboot.org/c/flashrom/+/74166/comment/69278765_9f99c7fa PS2, Line 168: enum test_state I assume u32 is used here because there was some problem with using an enum? Can this be changed back to enum? If not maybe add a comment with the blocker here -- To view, visit https://review.coreboot.org/c/flashrom/+/74166 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I48346a3da5923e614728a1cc0567ed2bb1ba2e2f Gerrit-Change-Number: 74166 Gerrit-PatchSet: 2 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Wed, 19 Apr 2023 06:41:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: cli_classic.c: Use flashrom_flash_getinfo() libflashrom API
by Nikolai Artemiev (Code Review) 19 Apr '23

19 Apr '23

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73287 ) Change subject: cli_classic.c: Use flashrom_flash_getinfo() libflashrom API ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/73287 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I5270c2cc0c1392d95d497fc1fce266ae082843c2 Gerrit-Change-Number: 73287 Gerrit-PatchSet: 3 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Wed, 19 Apr 2023 06:30:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: libflashrom: Allow flashrom_flashchip_info to contain model id's
by Nikolai Artemiev (Code Review) 19 Apr '23

19 Apr '23

Attention is currently required from: Sam McNally, Thomas Heijligen, Edward O'Callaghan. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74210 ) Change subject: libflashrom: Allow flashrom_flashchip_info to contain model id's ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/74210 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9742bbac8424ec9cca4b6e85cd6baa521c3d0f56 Gerrit-Change-Number: 74210 Gerrit-PatchSet: 1 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sam McNally <sammc(a)google.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Wed, 19 Apr 2023 06:29:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: cli_classic.c: Allow ctrl of behaviour with WO and RO regions
by Nikolai Artemiev (Code Review) 19 Apr '23

19 Apr '23

Attention is currently required from: Edward O'Callaghan, Angel Pons. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/70895 ) Change subject: cli_classic.c: Allow ctrl of behaviour with WO and RO regions ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/70895 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iff753b748765410ea38b845613c361db7ad16a61 Gerrit-Change-Number: 70895 Gerrit-PatchSet: 8 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Wed, 19 Apr 2023 06:29:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: libflashrom: Provide flashrom_flash_getinfo() API
by Nikolai Artemiev (Code Review) 19 Apr '23

19 Apr '23

Attention is currently required from: Sam McNally, Thomas Heijligen, Edward O'Callaghan. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73286 ) Change subject: libflashrom: Provide flashrom_flash_getinfo() API ...................................................................... Patch Set 7: Code-Review+1 (1 comment) File libflashrom.c: https://review.coreboot.org/c/flashrom/+/73286/comment/a73251c4_109dff84 PS7, Line 258: info->vendor = flashctx->chip->vendor; > Can we share the copy implementation with `flashrom_supported_flash_chips()`? +1 -- To view, visit https://review.coreboot.org/c/flashrom/+/73286 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I3dc32e261e6d54230d93f06b91f723811792112a Gerrit-Change-Number: 73286 Gerrit-PatchSet: 7 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Sam McNally <sammc(a)google.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Wed, 19 Apr 2023 06:28:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Sam McNally <sammc(a)google.com> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: Makefile: do not generate man page when building sources
by Alexander Goncharov (Code Review) 18 Apr '23

18 Apr '23

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Anastasia Klimchuk. Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74510 ) Change subject: Makefile: do not generate man page when building sources ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Let's give users a chance to use make without Sphinx before we deprecate this build system -- To view, visit https://review.coreboot.org/c/flashrom/+/74510 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9882445de2a0996f237470a73b6a1eb7eafce808 Gerrit-Change-Number: 74510 Gerrit-PatchSet: 1 Gerrit-Owner: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 18 Apr 2023 15:50:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit April 2023