March 2023 - flashrom-gerrit - mail.coreboot.org

[M] Change in flashrom[master]: doc: Add contact page
by Edward O'Callaghan (Code Review) 22 Mar '23

22 Mar '23

Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk, Alexander Goncharov. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73822 ) Change subject: doc: Add contact page ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/73822 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ibfba6a59c5a945b4238d16e07a07584f94159568 Gerrit-Change-Number: 73822 Gerrit-PatchSet: 4 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Wed, 22 Mar 2023 05:39:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: tree/: Convert printlock func ptr into enumerate values
by Nikolai Artemiev (Code Review) 21 Mar '23

21 Mar '23

Attention is currently required from: Edward O'Callaghan. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69934 ) Change subject: tree/: Convert printlock func ptr into enumerate values ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/69934 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9131348f72c1010e2c213dca4dc4b675a8d8681e Gerrit-Change-Number: 69934 Gerrit-PatchSet: 4 Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Sam McNally <sammc(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Comment-Date: Tue, 21 Mar 2023 23:51:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: flashchips: Add Macronix MX25V4035F support
by Thomas Heijligen (Code Review) 21 Mar '23

21 Mar '23

Attention is currently required from: PoroCYon, Angel Pons, Anastasia Klimchuk. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73582 ) Change subject: flashchips: Add Macronix MX25V4035F support ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/73582/comment/6f5fcfde_94a1edd7 PS2, Line 17: PoroCYon > You need to sign-off with your real name, see dev guidelines https://www.flashrom. […] This Guidelines should receive an update based on newer developments and clarifications in the linux kernel contribution guidelines. https://github.com/torvalds/linux/commit/d4563201f33a022fc0353033d9dfeb1606… -- To view, visit https://review.coreboot.org/c/flashrom/+/73582 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8b26926c354b840ca7b14b4c5cb000e3c02f5137 Gerrit-Change-Number: 73582 Gerrit-PatchSet: 2 Gerrit-Owner: PoroCYon <p(a)pcy.be> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: PoroCYon <p(a)pcy.be> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 21 Mar 2023 23:26:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: flashchips: Add Macronix MX25V1635F support
by PoroCYon (Code Review) 21 Mar '23

21 Mar '23

Attention is currently required from: Anastasia Klimchuk. PoroCYon has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73824 ) Change subject: flashchips: Add Macronix MX25V1635F support ...................................................................... Patch Set 2: (1 comment) File flashchips.c: https://review.coreboot.org/c/flashrom/+/73824/comment/b88b60c4_a23d79cd PS1, Line 9657: TEST_OK_PREW > Just checking: commit message says you tested writing and reading, this value marks that erase opera […] Done (I did test it, commit message wasn't clear enough, sorry.) -- To view, visit https://review.coreboot.org/c/flashrom/+/73824 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I58ddaaa96ef410d50dde3aaa20376c5bbf0f370b Gerrit-Change-Number: 73824 Gerrit-PatchSet: 2 Gerrit-Owner: PoroCYon <p(a)pcy.be> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Tue, 21 Mar 2023 22:48:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: flashchips: Add Macronix MX25V1635F support
by PoroCYon (Code Review) 21 Mar '23

21 Mar '23

Attention is currently required from: PoroCYon. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/73824 to look at the new patch set (#2). Change subject: flashchips: Add Macronix MX25V1635F support ...................................................................... flashchips: Add Macronix MX25V1635F support See https://www.mxic.com.tw/Lists/Datasheet/Attachments/8662/MX25V1635F,%202.5V… . I've tested this patch with the MX25V1635F I have here, using serprog and ftdi by (re)writing a few images to the flash and seeing if changes were stored correctly. This also included erasing and rewriting the memory with completely different data, so erase is tested, too. Change-Id: I58ddaaa96ef410d50dde3aaa20376c5bbf0f370b Signed-off-by: PoroCYon <p(a)pcy.be> --- M flashchips.c M include/flashchips.h 2 files changed, 53 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/24/73824/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/73824 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I58ddaaa96ef410d50dde3aaa20376c5bbf0f370b Gerrit-Change-Number: 73824 Gerrit-PatchSet: 2 Gerrit-Owner: PoroCYon <p(a)pcy.be> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: PoroCYon <p(a)pcy.be> Gerrit-MessageType: newpatchset

1 0

[M] Change in flashrom[master]: flashchips: Add Macronix MX25V1635F support
by Anastasia Klimchuk (Code Review) 21 Mar '23

21 Mar '23

Attention is currently required from: PoroCYon. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73824 ) Change subject: flashchips: Add Macronix MX25V1635F support ...................................................................... Patch Set 1: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/73824/comment/3c134522_d103ac16 PS1, Line 16: PoroCYon same as in other patches File flashchips.c: https://review.coreboot.org/c/flashrom/+/73824/comment/e3546884_d4421dfc PS1, Line 9657: TEST_OK_PREW Just checking: commit message says you tested writing and reading, this value marks that erase operation has been tested too. If you did it, can you please mention in commit message? thanks! -- To view, visit https://review.coreboot.org/c/flashrom/+/73824 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I58ddaaa96ef410d50dde3aaa20376c5bbf0f370b Gerrit-Change-Number: 73824 Gerrit-PatchSet: 1 Gerrit-Owner: PoroCYon <p(a)pcy.be> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: PoroCYon <p(a)pcy.be> Gerrit-Comment-Date: Tue, 21 Mar 2023 07:29:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: flashchips: Add Macronix MX25V8035F support
by Anastasia Klimchuk (Code Review) 21 Mar '23

21 Mar '23

Attention is currently required from: PoroCYon. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73823 ) Change subject: flashchips: Add Macronix MX25V8035F support ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/flashrom/+/73823/comment/6dfff70e_8fef17de PS1, Line 17: PoroCYon Same here, you need to sign-off with real name https://www.flashrom.org/Development_Guidelines#Sign-off_Procedure -- To view, visit https://review.coreboot.org/c/flashrom/+/73823 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic5be2da4cfa2a2ff044a519bb6f367f21c15e4b8 Gerrit-Change-Number: 73823 Gerrit-PatchSet: 1 Gerrit-Owner: PoroCYon <p(a)pcy.be> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Attention: PoroCYon <p(a)pcy.be> Gerrit-Comment-Date: Tue, 21 Mar 2023 07:27:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: flashchips: Add Macronix MX25V4035F support
by Anastasia Klimchuk (Code Review) 21 Mar '23

21 Mar '23

Attention is currently required from: PoroCYon, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73582 ) Change subject: flashchips: Add Macronix MX25V4035F support ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/73582/comment/b440b563_34d57d00 PS2, Line 17: PoroCYon You need to sign-off with your real name, see dev guidelines https://www.flashrom.org/Development_Guidelines#Sign-off_Procedure Patchset: PS2: Thank you for the patch! I have one comment -- To view, visit https://review.coreboot.org/c/flashrom/+/73582 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8b26926c354b840ca7b14b4c5cb000e3c02f5137 Gerrit-Change-Number: 73582 Gerrit-PatchSet: 2 Gerrit-Owner: PoroCYon <p(a)pcy.be> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: PoroCYon <p(a)pcy.be> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 21 Mar 2023 07:24:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: chipset_enable: Mark Intel H97 as test_state DEP
by Angel Pons (Code Review) 20 Mar '23

20 Mar '23

Attention is currently required from: Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73581 ) Change subject: chipset_enable: Mark Intel H97 as test_state DEP ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/73581 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iebf83b5b226d961bd5a6b5f53693dbc5f8884898 Gerrit-Change-Number: 73581 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Mon, 20 Mar 2023 21:28:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: atavia: Use a atavia_offset locally to determin offset
by Thomas Heijligen (Code Review) 20 Mar '23

20 Mar '23

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/73825 ) Change subject: atavia: Use a atavia_offset locally to determin offset ...................................................................... atavia: Use a atavia_offset locally to determin offset Use atavia_offset directly in atavia_chip_write / read instead of going the round over a pseudo mapping and flashctx->virtual_memory. Change-Id: Ie0ec85c276f03942d6b9435a746ec329b2b95926 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M atavia.c 1 file changed, 21 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/25/73825/1 diff --git a/atavia.c b/atavia.c index f35771a..d0f2a32 100644 --- a/atavia.c +++ b/atavia.c @@ -54,7 +54,10 @@ {0}, }; -static void *atavia_offset = NULL; +/* The atavia_offset is some kind of magic to get the driver working. + * You can find the correct value in the documentation or by try and error. + */ +static uint32_t atavia_offset = 0; static struct pci_dev *dev = NULL; static void atavia_prettyprint_access(uint8_t access) @@ -101,15 +104,10 @@ return ready; } -static void *atavia_map(const char *descr, uintptr_t phys_addr, size_t len) -{ - return (atavia_offset != 0) ? atavia_offset : (void *)phys_addr; -} - static void atavia_chip_writeb(const struct flashctx *flash, uint8_t val, const chipaddr addr) { msg_pspew("%s: 0x%02x to 0x%*" PRIxPTR ".\n", __func__, val, PRIxPTR_WIDTH, addr); - pci_write_long(dev, BROM_ADDR, (addr & ~3)); + pci_write_long(dev, BROM_ADDR, atavia_offset + (addr & ~3)); pci_write_long(dev, BROM_DATA, val << BYTE_OFFSET(addr)); pci_write_byte(dev, BROM_ACCESS, BROM_TRIGGER | BROM_WRITE | ENABLE_BYTE(addr)); @@ -120,7 +118,7 @@ static uint8_t atavia_chip_readb(const struct flashctx *flash, const chipaddr addr) { - pci_write_long(dev, BROM_ADDR, (addr & ~3)); + pci_write_long(dev, BROM_ADDR, atavia_offset + (addr & ~3)); pci_write_byte(dev, BROM_ACCESS, BROM_TRIGGER | ENABLE_BYTE(addr)); if (!atavia_ready(dev)) { @@ -133,7 +131,6 @@ } static const struct par_master lpc_master_atavia = { - .map_flash_region = atavia_map, .chip_readb = atavia_chip_readb, .chip_writeb = atavia_chip_writeb, }; @@ -148,13 +145,13 @@ return ERROR_FLASHROM_FATAL; } char *endptr; - atavia_offset = (void *)strtoul(arg, &endptr, 0); + atavia_offset = (uint32_t)strtoul(arg, &endptr, 0); if (*endptr) { msg_perr("Error: Invalid offset specified: \"%s\".\n", arg); free(arg); return ERROR_FLASHROM_FATAL; } - msg_pinfo("Mapping addresses to base %p.\n", atavia_offset); + msg_pinfo("Using %#"PRIx32" as base.\n", atavia_offset); } free(arg); -- To view, visit https://review.coreboot.org/c/flashrom/+/73825 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie0ec85c276f03942d6b9435a746ec329b2b95926 Gerrit-Change-Number: 73825 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit March 2023