March 2023 - flashrom-gerrit - mail.coreboot.org

[M] Change in flashrom[master]: flashchips: Add Macronix MX25V4035F support
by Anastasia Klimchuk (Code Review) 21 Mar '23

21 Mar '23

Attention is currently required from: PoroCYon, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73582 ) Change subject: flashchips: Add Macronix MX25V4035F support ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/73582/comment/b440b563_34d57d00 PS2, Line 17: PoroCYon You need to sign-off with your real name, see dev guidelines https://www.flashrom.org/Development_Guidelines#Sign-off_Procedure Patchset: PS2: Thank you for the patch! I have one comment -- To view, visit https://review.coreboot.org/c/flashrom/+/73582 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8b26926c354b840ca7b14b4c5cb000e3c02f5137 Gerrit-Change-Number: 73582 Gerrit-PatchSet: 2 Gerrit-Owner: PoroCYon <p(a)pcy.be> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: PoroCYon <p(a)pcy.be> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Tue, 21 Mar 2023 07:24:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: chipset_enable: Mark Intel H97 as test_state DEP
by Angel Pons (Code Review) 20 Mar '23

20 Mar '23

Attention is currently required from: Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73581 ) Change subject: chipset_enable: Mark Intel H97 as test_state DEP ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/73581 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iebf83b5b226d961bd5a6b5f53693dbc5f8884898 Gerrit-Change-Number: 73581 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Mon, 20 Mar 2023 21:28:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: atavia: Use a atavia_offset locally to determin offset
by Thomas Heijligen (Code Review) 20 Mar '23

20 Mar '23

Thomas Heijligen has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/73825 ) Change subject: atavia: Use a atavia_offset locally to determin offset ...................................................................... atavia: Use a atavia_offset locally to determin offset Use atavia_offset directly in atavia_chip_write / read instead of going the round over a pseudo mapping and flashctx->virtual_memory. Change-Id: Ie0ec85c276f03942d6b9435a746ec329b2b95926 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M atavia.c 1 file changed, 21 insertions(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/25/73825/1 diff --git a/atavia.c b/atavia.c index f35771a..d0f2a32 100644 --- a/atavia.c +++ b/atavia.c @@ -54,7 +54,10 @@ {0}, }; -static void *atavia_offset = NULL; +/* The atavia_offset is some kind of magic to get the driver working. + * You can find the correct value in the documentation or by try and error. + */ +static uint32_t atavia_offset = 0; static struct pci_dev *dev = NULL; static void atavia_prettyprint_access(uint8_t access) @@ -101,15 +104,10 @@ return ready; } -static void *atavia_map(const char *descr, uintptr_t phys_addr, size_t len) -{ - return (atavia_offset != 0) ? atavia_offset : (void *)phys_addr; -} - static void atavia_chip_writeb(const struct flashctx *flash, uint8_t val, const chipaddr addr) { msg_pspew("%s: 0x%02x to 0x%*" PRIxPTR ".\n", __func__, val, PRIxPTR_WIDTH, addr); - pci_write_long(dev, BROM_ADDR, (addr & ~3)); + pci_write_long(dev, BROM_ADDR, atavia_offset + (addr & ~3)); pci_write_long(dev, BROM_DATA, val << BYTE_OFFSET(addr)); pci_write_byte(dev, BROM_ACCESS, BROM_TRIGGER | BROM_WRITE | ENABLE_BYTE(addr)); @@ -120,7 +118,7 @@ static uint8_t atavia_chip_readb(const struct flashctx *flash, const chipaddr addr) { - pci_write_long(dev, BROM_ADDR, (addr & ~3)); + pci_write_long(dev, BROM_ADDR, atavia_offset + (addr & ~3)); pci_write_byte(dev, BROM_ACCESS, BROM_TRIGGER | ENABLE_BYTE(addr)); if (!atavia_ready(dev)) { @@ -133,7 +131,6 @@ } static const struct par_master lpc_master_atavia = { - .map_flash_region = atavia_map, .chip_readb = atavia_chip_readb, .chip_writeb = atavia_chip_writeb, }; @@ -148,13 +145,13 @@ return ERROR_FLASHROM_FATAL; } char *endptr; - atavia_offset = (void *)strtoul(arg, &endptr, 0); + atavia_offset = (uint32_t)strtoul(arg, &endptr, 0); if (*endptr) { msg_perr("Error: Invalid offset specified: \"%s\".\n", arg); free(arg); return ERROR_FLASHROM_FATAL; } - msg_pinfo("Mapping addresses to base %p.\n", atavia_offset); + msg_pinfo("Using %#"PRIx32" as base.\n", atavia_offset); } free(arg); -- To view, visit https://review.coreboot.org/c/flashrom/+/73825 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ie0ec85c276f03942d6b9435a746ec329b2b95926 Gerrit-Change-Number: 73825 Gerrit-PatchSet: 1 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[master]: chipset_enable: Mark Intel H97 as test_state DEP
by Thomas Heijligen (Code Review) 20 Mar '23

20 Mar '23

Attention is currently required from: Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73581 ) Change subject: chipset_enable: Mark Intel H97 as test_state DEP ...................................................................... Patch Set 3: (1 comment) File chipset_enable.c: https://review.coreboot.org/c/flashrom/+/73581/comment/5d13e2da_2db81a08 PS2, Line 2023: OK > DEP, see CB:28817 for example. Done -- To view, visit https://review.coreboot.org/c/flashrom/+/73581 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iebf83b5b226d961bd5a6b5f53693dbc5f8884898 Gerrit-Change-Number: 73581 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 20 Mar 2023 14:41:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: chipset_enable: Mark Intel H97 as test_state DEP
by Thomas Heijligen (Code Review) 20 Mar '23

20 Mar '23

Attention is currently required from: Thomas Heijligen. Hello build bot (Jenkins), Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/73581 to look at the new patch set (#3). Change subject: chipset_enable: Mark Intel H97 as test_state DEP ...................................................................... chipset_enable: Mark Intel H97 as test_state DEP An user reported on the mailing list [0] a successfull update of an MSI MS-7850 mainboard with an Intel H97 chipset. All ME-enable chipsets are marked as DEP instead of OK, so follow this rule. [0] https://mail.coreboot.org/hyperkitty/list/flashrom@flashrom.org/message/MYU… Change-Id: Iebf83b5b226d961bd5a6b5f53693dbc5f8884898 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M chipset_enable.c 1 file changed, 18 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/81/73581/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/73581 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Iebf83b5b226d961bd5a6b5f53693dbc5f8884898 Gerrit-Change-Number: 73581 Gerrit-PatchSet: 3 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: Revert "pcidev: remove pcidev_getdevfn() function"
by Thomas Heijligen (Code Review) 20 Mar '23

20 Mar '23

Thomas Heijligen has submitted this change. ( https://review.coreboot.org/c/flashrom/+/73730 ) Change subject: Revert "pcidev: remove pcidev_getdevfn() function" ...................................................................... Revert "pcidev: remove pcidev_getdevfn() function" As Edward pointed out correctly this function does more than abstracting the different versions of `pci_get_dev()`. It also hide the usage of the global `struct pci_access pacc` from the caller. This reverts commit 0e8902f1ff2b927bb91a5e89e4fde3d8d71f6692. Change-Id: I0cd2f54cb6a6e35dc353476e0f5e502cbbd06cba Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/73730 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Edward O'Callaghan <quasisec(a)chromium.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M board_enable.c M include/programmer.h M pcidev.c 3 files changed, 30 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Edward O'Callaghan: Looks good to me, approved Anastasia Klimchuk: Looks good to me, approved diff --git a/board_enable.c b/board_enable.c index 3e6a5a7..d35b151 100644 --- a/board_enable.c +++ b/board_enable.c @@ -1095,12 +1095,11 @@ return -1; } - dev = pci_get_dev(pacc, dev->domain, dev->bus, dev->dev, 1); + dev = pcidev_getdevfn(dev, 1); if (!dev) { msg_perr("MCP SMBus controller could not be found\n"); return -1; } - pci_fill_info(dev, PCI_FILL_IDENT); devclass = pci_read_word(dev, PCI_CLASS_DEVICE); if (devclass != 0x0C05) { msg_perr("Unexpected device class %04x for SMBus" diff --git a/include/programmer.h b/include/programmer.h index 9728d8d..d8d8b4a 100644 --- a/include/programmer.h +++ b/include/programmer.h @@ -125,6 +125,7 @@ uintptr_t pcidev_readbar(struct pci_dev *dev, int bar); struct pci_dev *pcidev_init(const struct programmer_cfg *cfg, const struct dev_entry *devs, int bar); struct pci_dev *pcidev_scandev(struct pci_filter *filter, struct pci_dev *start); +struct pci_dev *pcidev_getdevfn(struct pci_dev *dev, const int func); struct pci_dev *pcidev_find_vendorclass(uint16_t vendor, uint16_t devclass); struct pci_dev *pcidev_card_find(uint16_t vendor, uint16_t device, uint16_t card_vendor, uint16_t card_device); struct pci_dev *pcidev_find(uint16_t vendor, uint16_t device); diff --git a/pcidev.c b/pcidev.c index 68da327..696510e 100644 --- a/pcidev.c +++ b/pcidev.c @@ -190,6 +190,14 @@ return pcidev_scandev(&filter, NULL); } +struct pci_dev *pcidev_getdevfn(struct pci_dev *dev, const int func) +{ + struct pci_dev *const new = pci_get_dev(pacc, dev->domain, dev->bus, dev->dev, func); + if (new) + pci_fill_info(new, PCI_FILL_IDENT); + return new; +} + struct pci_dev *pcidev_find_vendorclass(uint16_t vendor, uint16_t devclass) { struct pci_dev *temp = NULL; -- To view, visit https://review.coreboot.org/c/flashrom/+/73730 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0cd2f54cb6a6e35dc353476e0f5e502cbbd06cba Gerrit-Change-Number: 73730 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[M] Change in flashrom[master]: flashchips: Add Macronix MX25V4035F support
by Thomas Heijligen (Code Review) 20 Mar '23

20 Mar '23

Attention is currently required from: PoroCYon, Angel Pons, Anastasia Klimchuk. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73582 ) Change subject: flashchips: Add Macronix MX25V4035F support ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > Hm, wait, this seems to have opened three separate changesets instead of adding the commits to this […] It looks fine this way. In Gerrit each patch has it's own page and you have a relation chain to see the connection. -- To view, visit https://review.coreboot.org/c/flashrom/+/73582 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I8b26926c354b840ca7b14b4c5cb000e3c02f5137 Gerrit-Change-Number: 73582 Gerrit-PatchSet: 2 Gerrit-Owner: PoroCYon <p(a)pcy.be> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: PoroCYon <p(a)pcy.be> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 20 Mar 2023 14:05:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: PoroCYon <p(a)pcy.be> Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: cli_classic: include a fallback inplementation of getopt
by Thomas Heijligen (Code Review) 20 Mar '23

20 Mar '23

Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73102 ) Change subject: cli_classic: include a fallback inplementation of getopt ...................................................................... Patch Set 10: (5 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/73102/comment/e57f1cbc_9a03e13b PS7, Line 12: DJGPP/DOS > I think inline is better: […] Done File cli_getopt.c: https://review.coreboot.org/c/flashrom/+/73102/comment/daf18dbc_a2b70a1a PS7, Line 254: : : > Let's keep 1 line in between functions (in this file, some has 2-3 empty lines break) Done File include/cli_classic.h: https://review.coreboot.org/c/flashrom/+/73102/comment/cfe24afc_e7e34674 PS7, Line 1: # > We need to add a license header? we still have them... Done https://review.coreboot.org/c/flashrom/+/73102/comment/8fc23f3b_f5133188 PS7, Line 3: > 1 line break is enough I think Done File meson.build: https://review.coreboot.org/c/flashrom/+/73102/comment/beb38e6f_9e1dd2a6 PS7, Line 637: cli_srcs = files( : 'cli_classic.c', : 'cli_common.c', : 'cli_output.c' : ) : : if not cc.has_function('getopt_long') : cli_srcs += files('cli_getopt.c') : endif : : > This block should be intended to the right it seems? it is inside if condition? Done -- To view, visit https://review.coreboot.org/c/flashrom/+/73102 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6ebbde075014e3b45b0f9e04b34b72aa969e1197 Gerrit-Change-Number: 73102 Gerrit-PatchSet: 10 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Comment-Date: Mon, 20 Mar 2023 13:57:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: cli_classic: include a fallback inplementation of getopt
by Thomas Heijligen (Code Review) 20 Mar '23

20 Mar '23

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Angel Pons. Hello build bot (Jenkins), Edward O'Callaghan, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/73102 to look at the new patch set (#10). Change subject: cli_classic: include a fallback inplementation of getopt ...................................................................... cli_classic: include a fallback inplementation of getopt Some systems, DJGPP/DOS for now, may not provide getopt and their gnu extensions. So provide a fallback implementation. The code is based on musl libc. Change-Id: I6ebbde075014e3b45b0f9e04b34b72aa969e1197 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M cli_classic.c A cli_getopt.c A include/cli_classic.h M meson.build 4 files changed, 333 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/02/73102/10 -- To view, visit https://review.coreboot.org/c/flashrom/+/73102 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6ebbde075014e3b45b0f9e04b34b72aa969e1197 Gerrit-Change-Number: 73102 Gerrit-PatchSet: 10 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in flashrom[master]: cli_classic: include a fallback inplementation of getopt
by Thomas Heijligen (Code Review) 20 Mar '23

20 Mar '23

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Angel Pons. Hello build bot (Jenkins), Edward O'Callaghan, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/73102 to look at the new patch set (#9). Change subject: cli_classic: include a fallback inplementation of getopt ...................................................................... cli_classic: include a fallback inplementation of getopt Some systems, DJGPP/DOS for now, may not provide getopt and their gnu extensions. So provide a fallback implementation. The code is based on musl libc. Change-Id: I6ebbde075014e3b45b0f9e04b34b72aa969e1197 Signed-off-by: Thomas Heijligen <thomas.heijligen(a)secunet.com> --- M cli_classic.c A cli_getopt.c A include/cli_classic.h M meson.build 4 files changed, 334 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/02/73102/9 -- To view, visit https://review.coreboot.org/c/flashrom/+/73102 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I6ebbde075014e3b45b0f9e04b34b72aa969e1197 Gerrit-Change-Number: 73102 Gerrit-PatchSet: 9 Gerrit-Owner: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit March 2023