September 2022 - flashrom-gerrit

[S] Change in flashrom[1.1.x]: [WIP] Makefile: Fix developerbox spi programmer dependencies
by Felix Singer (Code Review) 29 Sep '22

29 Sep '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/68010 ) Change subject: [WIP] Makefile: Fix developerbox spi programmer dependencies ...................................................................... [WIP] Makefile: Fix developerbox spi programmer dependencies Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I55dd4a0faeb40f1f2cea75796db131c4b3dc2890 --- M Makefile 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/10/68010/1 diff --git a/Makefile b/Makefile index e08a3f6..57a23c5 100644 --- a/Makefile +++ b/Makefile @@ -735,12 +735,16 @@ ifeq ($(CONFIG_OGP_SPI), yes) override CONFIG_BITBANG_SPI = yes else +ifeq ($(CONFIG_DEVELOPERBOX_SPI, yes)) +override CONFIG_BITBANG_SPI = yes +else CONFIG_BITBANG_SPI ?= no endif endif endif endif endif +endif ############################################################################### # Handle CONFIG_* variables that depend on others set (and verified) above. -- To view, visit https://review.coreboot.org/c/flashrom/+/68010 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.1.x Gerrit-Change-Id: I55dd4a0faeb40f1f2cea75796db131c4b3dc2890 Gerrit-Change-Number: 68010 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[1.1.x]: test_build.sh: Use multiple cores if Make is used
by Felix Singer (Code Review) 29 Sep '22

29 Sep '22

Attention is currently required from: Nico Huber, Thomas Heijligen, Angel Pons. Hello build bot (Jenkins), Nico Huber, Thomas Heijligen, Angel Pons, I'd like you to do a code review. Please visit https://review.coreboot.org/c/flashrom/+/68009 to review the following change. Change subject: test_build.sh: Use multiple cores if Make is used ...................................................................... test_build.sh: Use multiple cores if Make is used Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: Ia67e9202e49f1b4bc3301399a8ec741ac01c3ce0 Reviewed-on: https://review.coreboot.org/c/flashrom/+/67244 Reviewed-by: Thomas Heijligen <src(a)posteo.de> Reviewed-by: Nico Huber <nico.h(a)gmx.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M test_build.sh 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/09/68009/1 diff --git a/test_build.sh b/test_build.sh index 7a15c20..9f80de8 100755 --- a/test_build.sh +++ b/test_build.sh @@ -25,5 +25,5 @@ for option in ${make_programmer_opts}; do echo "Building ${option}" make clean - make CONFIG_NOTHING=yes CONFIG_${option}=yes + make -j $(nproc) CONFIG_NOTHING=yes CONFIG_${option}=yes done -- To view, visit https://review.coreboot.org/c/flashrom/+/68009 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.1.x Gerrit-Change-Id: Ia67e9202e49f1b4bc3301399a8ec741ac01c3ce0 Gerrit-Change-Number: 68009 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[1.1.x]: test_build.sh: Improve robustness when dealing with empty $CC
by Felix Singer (Code Review) 29 Sep '22

29 Sep '22

Attention is currently required from: Patrick Georgi. Hello build bot (Jenkins), Patrick Georgi, I'd like you to do a code review. Please visit https://review.coreboot.org/c/flashrom/+/68008 to review the following change. Change subject: test_build.sh: Improve robustness when dealing with empty $CC ...................................................................... test_build.sh: Improve robustness when dealing with empty $CC Add quotes so that = knows what to compare, otherwise the shell complains: ./test_build.sh: 16: [: =: unexpected operator Change-Id: Ia289b31291949f5cbc11484b8f1a7cb7a49bd2bb Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/67740 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> --- M test_build.sh 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/08/68008/1 diff --git a/test_build.sh b/test_build.sh index d6d29ee..7a15c20 100755 --- a/test_build.sh +++ b/test_build.sh @@ -9,7 +9,7 @@ BUSPIRATE_SPI DEDIPROG DEVELOPERBOX_SPI SATAMV LINUX_MTD LINUX_SPI IT8212 \ CH341A_SPI DIGILENT_SPI JLINK_SPI" -if [ $(basename "${CC}") = "ccc-analyzer" ] || [ -n "${COVERITY_OUTPUT}" ]; then +if [ "$(basename "${CC}")" = "ccc-analyzer" ] || [ -n "${COVERITY_OUTPUT}" ]; then is_scan_build_env=1 fi -- To view, visit https://review.coreboot.org/c/flashrom/+/68008 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.1.x Gerrit-Change-Id: Ia289b31291949f5cbc11484b8f1a7cb7a49bd2bb Gerrit-Change-Number: 68008 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[1.1.x]: test_build.sh: Identify runs for Coverity Scan
by Felix Singer (Code Review) 29 Sep '22

29 Sep '22

Attention is currently required from: Patrick Georgi, Anastasia Klimchuk. Hello build bot (Jenkins), Patrick Georgi, Anastasia Klimchuk, I'd like you to do a code review. Please visit https://review.coreboot.org/c/flashrom/+/68007 to review the following change. Change subject: test_build.sh: Identify runs for Coverity Scan ...................................................................... test_build.sh: Identify runs for Coverity Scan For Coverity Scan[0] the same build rules apply as for scan-build. [0] https://scan.coverity.com/projects/flashrom Change-Id: I75147799b1c3213866e343a0384c94d0a1f5c249 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/67739 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M test_build.sh 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/07/68007/1 diff --git a/test_build.sh b/test_build.sh index cf20418..d6d29ee 100755 --- a/test_build.sh +++ b/test_build.sh @@ -9,7 +9,7 @@ BUSPIRATE_SPI DEDIPROG DEVELOPERBOX_SPI SATAMV LINUX_MTD LINUX_SPI IT8212 \ CH341A_SPI DIGILENT_SPI JLINK_SPI" -if [ $(basename "${CC}") = "ccc-analyzer" ]; then +if [ $(basename "${CC}") = "ccc-analyzer" ] || [ -n "${COVERITY_OUTPUT}" ]; then is_scan_build_env=1 fi -- To view, visit https://review.coreboot.org/c/flashrom/+/68007 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.1.x Gerrit-Change-Id: I75147799b1c3213866e343a0384c94d0a1f5c249 Gerrit-Change-Number: 68007 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

[M] Change in flashrom[1.1.x]: test_build.sh: Build all programmers individually using Make
by Felix Singer (Code Review) 29 Sep '22

29 Sep '22

Attention is currently required from: Nico Huber, Thomas Heijligen, Anastasia Klimchuk. Hello build bot (Jenkins), Nico Huber, Thomas Heijligen, Anastasia Klimchuk, I'd like you to do a code review. Please visit https://review.coreboot.org/c/flashrom/+/68006 to review the following change. Change subject: test_build.sh: Build all programmers individually using Make ...................................................................... test_build.sh: Build all programmers individually using Make While testing CB:63724, which reworks the Meson build system, it showed that some programmers have dependency issues, which were invisible since test_build.sh builds flashrom with all programmers enabled and thus all sources are included. Building flashrom with each programmer individually made these issues visible. However, as commit 877b7741fcf9 and commit b6a439e45ef2 show, the Make build system also had some similar issues, which were invisible for the same reason. Thus, in addition to building all programmers at once using the Make build system, build each programmer individually. Also, when clang analyzer is used, it's not needed to run it on each programmer individually. Just return after flashrom was built with all programmers enabled in this case. An equivalent patch for the Meson build system is made separately. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I3bacb3ba9c6708f1e7ef5a111290d0ea3af36f1d Reviewed-on: https://review.coreboot.org/c/flashrom/+/66094 Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Thomas Heijligen <src(a)posteo.de> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M test_build.sh 1 file changed, 58 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/06/68006/1 diff --git a/test_build.sh b/test_build.sh index 6cb902c..cf20418 100755 --- a/test_build.sh +++ b/test_build.sh @@ -1,5 +1,29 @@ #!/bin/sh set -e +is_scan_build_env=0 + +make_programmer_opts="INTERNAL SERPROG RAYER_SPI PONY_SPI NIC3COM GFXNVIDIA SATASII ATAHPT ATAVIA \ + ATAPROMISE FT2232_SPI USBBLASTER_SPI MSTARDDC_SPI PICKIT2_SPI DUMMY \ + DRKAISER NICREALTEK NICNATSEMI NICINTEL NICINTEL_SPI NICINTEL_EEPROM OGP_SPI \ + BUSPIRATE_SPI DEDIPROG DEVELOPERBOX_SPI SATAMV LINUX_MTD LINUX_SPI IT8212 \ + CH341A_SPI DIGILENT_SPI JLINK_SPI" + +if [ $(basename "${CC}") = "ccc-analyzer" ]; then + is_scan_build_env=1 +fi + make clean make CONFIG_EVERYTHING=yes + +# In case of clang analyzer we don't want to run it on +# each programmer individually. Thus, just return here. +if [ ${is_scan_build_env} -eq 1 ]; then + return +fi + +for option in ${make_programmer_opts}; do + echo "Building ${option}" + make clean + make CONFIG_NOTHING=yes CONFIG_${option}=yes +done -- To view, visit https://review.coreboot.org/c/flashrom/+/68006 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.1.x Gerrit-Change-Id: I3bacb3ba9c6708f1e7ef5a111290d0ea3af36f1d Gerrit-Change-Number: 68006 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[1.1.x]: test_build.sh: Allow WARNERROR to be overridden
by Felix Singer (Code Review) 29 Sep '22

29 Sep '22

Attention is currently required from: Nico Huber, Martin L Roth. Hello build bot (Jenkins), Nico Huber, Martin L Roth, I'd like you to do a code review. Please visit https://review.coreboot.org/c/flashrom/+/68005 to review the following change. Change subject: test_build.sh: Allow WARNERROR to be overridden ...................................................................... test_build.sh: Allow WARNERROR to be overridden Currently, WARNERROR is hardcoded to 'yes' which is what we want most of the time, but there are cases (such as when building with -fanalyzer) that we don't want it enabled, so we see the entire output of the build, and it doesn't halt at the first error. Removing the WARNERROR line from the script allows the variable to be overridden from an environment variable. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Iea931e57f2a6992762566dc3dbaae8bb8df5b226 Reviewed-on: https://review.coreboot.org/c/flashrom/+/62745 Reviewed-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-by: Nico Huber <nico.h(a)gmx.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M test_build.sh 1 file changed, 22 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/05/68005/1 diff --git a/test_build.sh b/test_build.sh index 0064c8f..6cb902c 100755 --- a/test_build.sh +++ b/test_build.sh @@ -2,4 +2,4 @@ set -e make clean -make CONFIG_EVERYTHING=yes WARNERROR=yes +make CONFIG_EVERYTHING=yes -- To view, visit https://review.coreboot.org/c/flashrom/+/68005 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.1.x Gerrit-Change-Id: Iea931e57f2a6992762566dc3dbaae8bb8df5b226 Gerrit-Change-Number: 68005 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[1.1.x]: test_build.sh: Run `make clean` before compiling
by Felix Singer (Code Review) 29 Sep '22

29 Sep '22

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/68004 ) Change subject: test_build.sh: Run `make clean` before compiling ...................................................................... test_build.sh: Run `make clean` before compiling Run `make clean` before compiling to make sure the script starts from a clean environment. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I6a6f5a3483941148330b95936e1445f21a34061b --- M test_build.sh 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/04/68004/1 diff --git a/test_build.sh b/test_build.sh index 3ab5319..0064c8f 100755 --- a/test_build.sh +++ b/test_build.sh @@ -1,4 +1,5 @@ #!/bin/sh set -e +make clean make CONFIG_EVERYTHING=yes WARNERROR=yes -- To view, visit https://review.coreboot.org/c/flashrom/+/68004 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.1.x Gerrit-Change-Id: I6a6f5a3483941148330b95936e1445f21a34061b Gerrit-Change-Number: 68004 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: newchange

1 0

[L] Change in flashrom[master]: dirtyjtag: Add DirtyJTAG programmer
by Jean THOMAS (Code Review) 29 Sep '22

29 Sep '22

Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen, Alexander Goncharov. Jean THOMAS has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67878 ) Change subject: dirtyjtag: Add DirtyJTAG programmer ...................................................................... Patch Set 6: (4 comments) Patchset: PS6: > One more style nit I've noticed: we also place a space before the asterisk […] Fixed. PS6: Hi again Nico, here's a new round. File dirtyjtag_spi.c: https://review.coreboot.org/c/flashrom/+/67878/comment/f61c20d8_3e06b7c1 PS5, Line 121: size_t num_xfer = (len + max_xfer_size - 1 ) / max_xfer_size; // ceil(len/max_xfer_size) > > > 1. Lift the `.max_data_*` limits so this function gets called for bigger […] I've seen runs going a little bit faster (4 seconds instead of 6 seconds @ 1Mhz for a 2Mbit flash), but it's not really consistent enough to make any meaningful conclusion. I think the main bottleneck lies in the size of the buffer we're able to send. Being able to max out USB bulk transfers would help a lot. https://review.coreboot.org/c/flashrom/+/67878/comment/84fe2ccb_291e674b PS5, Line 267: } > Minor misunderstanding, I think. I meant this `if` block is all that […] I removed the superfluous if conditions. I only added a check for the upper frequency bound, Frequency = 0 is no big deal, the adapter will use its lowest operating frequency. I added a check for the upper bound though, as it could be misleading to the user. frequency renamed to spiseed. -- To view, visit https://review.coreboot.org/c/flashrom/+/67878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic43e9a014ed7d04e429e73b30c9dcfdde1a78913 Gerrit-Change-Number: 67878 Gerrit-PatchSet: 6 Gerrit-Owner: Jean THOMAS <virgule(a)jeanthomas.me> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Comment-Date: Thu, 29 Sep 2022 22:25:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Jean THOMAS <virgule(a)jeanthomas.me> Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: dirtyjtag: Add DirtyJTAG programmer
by Jean THOMAS (Code Review) 29 Sep '22

29 Sep '22

Attention is currently required from: Felix Singer, Thomas Heijligen, Jean THOMAS, Alexander Goncharov. Hello Felix Singer, build bot (Jenkins), Nico Huber, Thomas Heijligen, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67878 to look at the new patch set (#7). Change subject: dirtyjtag: Add DirtyJTAG programmer ...................................................................... dirtyjtag: Add DirtyJTAG programmer Add a new programmer driver for the DirtyJTAG project (a USB-JTAG firmware for STM32 MCUs). Successfully tested with DirtyJTAG 1.4 running on an Olimex STM32-H103 development board and a SST25VF020B SPI flash chip. Change-Id: Ic43e9a014ed7d04e429e73b30c9dcfdde1a78913 Signed-off-by: Jean THOMAS <virgule(a)jeanthomas.me> --- M Makefile A dirtyjtag_spi.c M flashrom.8.tmpl M include/programmer.h M meson.build M meson_options.txt M programmer_table.c 7 files changed, 365 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/78/67878/7 -- To view, visit https://review.coreboot.org/c/flashrom/+/67878 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ic43e9a014ed7d04e429e73b30c9dcfdde1a78913 Gerrit-Change-Number: 67878 Gerrit-PatchSet: 7 Gerrit-Owner: Jean THOMAS <virgule(a)jeanthomas.me> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Jean THOMAS <virgule(a)jeanthomas.me> Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[1.0.x]: test_build.sh: Improve robustness when dealing with empty $CC
by Felix Singer (Code Review) 29 Sep '22

29 Sep '22

Attention is currently required from: Patrick Georgi. Hello build bot (Jenkins), Patrick Georgi, I'd like you to do a code review. Please visit https://review.coreboot.org/c/flashrom/+/68003 to review the following change. Change subject: test_build.sh: Improve robustness when dealing with empty $CC ...................................................................... test_build.sh: Improve robustness when dealing with empty $CC Add quotes so that = knows what to compare, otherwise the shell complains: ./test_build.sh: 16: [: =: unexpected operator Change-Id: Ia289b31291949f5cbc11484b8f1a7cb7a49bd2bb Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/67740 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> --- M test_build.sh 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/03/68003/1 diff --git a/test_build.sh b/test_build.sh index 6943701..42c647e 100755 --- a/test_build.sh +++ b/test_build.sh @@ -8,7 +8,7 @@ DRKAISER NICREALTEK NICNATSEMI NICINTEL NICINTEL_SPI NICINTEL_EEPROM OGP_SPI \ BUSPIRATE_SPI DEDIPROG SATAMV LINUX_SPI IT8212 CH341A_SPI" -if [ $(basename "${CC}") = "ccc-analyzer" ] || [ -n "${COVERITY_OUTPUT}" ]; then +if [ "$(basename "${CC}")" = "ccc-analyzer" ] || [ -n "${COVERITY_OUTPUT}" ]; then is_scan_build_env=1 fi -- To view, visit https://review.coreboot.org/c/flashrom/+/68003 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-Change-Id: Ia289b31291949f5cbc11484b8f1a7cb7a49bd2bb Gerrit-Change-Number: 68003 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-MessageType: newchange

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2022