Attention is currently required from: Thomas Heijligen, Edward O'Callaghan.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66684 )
Change subject: flashrom.c: create is_internal_programmer() helper
......................................................................
Patch Set 9: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/66684/comment/f7f14464_9027bf72
PS9, Line 9: This has the added benefit of cutting down one some
: pre-processor usage as suggested by Angel Pons as the
: function is always defined.
I find this a bit confusing. Suggestion:
As suggested by Angel Pons, add the function `is_internal_programmer`
and cut down some pre-processor usage by moving them into that new
function.
<empty>
The function checks if the internal programmer is the
selected one. If the internal programmer is not built in, then it
returns just false.
--
To view, visit https://review.coreboot.org/c/flashrom/+/66684
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I43243b990192077583a9a3a95d35844923d9c158
Gerrit-Change-Number: 66684
Gerrit-PatchSet: 9
Gerrit-Owner: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Comment-Date: Fri, 30 Sep 2022 00:49:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Felix Singer has submitted this change. ( https://review.coreboot.org/c/flashrom/+/67725 )
(
6 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: cli_classic.c: Add error messages for invalid --wp-region use
......................................................................
cli_classic.c: Add error messages for invalid --wp-region use
Print errors if --wp-region is used without a layout file or the layout
file doesn't contain the region.
BUG=b:247055486
TEST=builds
Change-Id: Ie606ba7f8a423405099679ca62169c395d994b5d
Signed-off-by: Nikolai Artemiev <nartemiev(a)google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/67725
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Felix Singer <felixsinger(a)posteo.net>
---
M cli_classic.c
1 file changed, 29 insertions(+), 2 deletions(-)
Approvals:
build bot (Jenkins): Verified
Felix Singer: Looks good to me, approved
diff --git a/cli_classic.c b/cli_classic.c
index bac31d1..3de0020 100644
--- a/cli_classic.c
+++ b/cli_classic.c
@@ -1110,9 +1110,17 @@
if (any_wp_op) {
if (set_wp_region && wp_region) {
- ret = flashrom_layout_get_region_range(layout, wp_region, &wp_start, &wp_len);
- if (ret)
+ if (!layout) {
+ msg_gerr("Error: A flash layout must be specified to use --wp-region.\n");
+ ret = 1;
goto out_release;
+ }
+
+ ret = flashrom_layout_get_region_range(layout, wp_region, &wp_start, &wp_len);
+ if (ret) {
+ msg_gerr("Error: Region %s not found in flash layout.\n", wp_region);
+ goto out_release;
+ }
set_wp_range = true;
}
ret = wp_cli(
--
To view, visit https://review.coreboot.org/c/flashrom/+/67725
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie606ba7f8a423405099679ca62169c395d994b5d
Gerrit-Change-Number: 67725
Gerrit-PatchSet: 8
Gerrit-Owner: Nikolai Artemiev <nartemiev(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen, Anastasia Klimchuk.
Hello build bot (Jenkins), Nico Huber, Thomas Heijligen, Anastasia Klimchuk,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/68000
to look at the new patch set (#4).
Change subject: test_build.sh: Build all programmers individually using Make
......................................................................
test_build.sh: Build all programmers individually using Make
Note: This patch was backported from the master branch and it was
modified so that it can be applied on the 1.0.x branch.
While testing CB:63724, which reworks the Meson build system, it showed
that some programmers have dependency issues, which were invisible since
test_build.sh builds flashrom with all programmers enabled and thus all
sources are included. Building flashrom with each programmer
individually made these issues visible.
However, as commit 877b7741fcf9 and commit b6a439e45ef2 show, the Make
build system also had some similar issues, which were invisible for the
same reason.
Thus, in addition to building all programmers at once using the Make
build system, build each programmer individually.
Also, when clang analyzer is used, it's not needed to run it on each
programmer individually. Just return after flashrom was built with all
programmers enabled in this case.
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
Change-Id: I3bacb3ba9c6708f1e7ef5a111290d0ea3af36f1d
Reviewed-on: https://review.coreboot.org/c/flashrom/+/66094
Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Thomas Heijligen <src(a)posteo.de>
Reviewed-by: Nico Huber <nico.h(a)gmx.de>
---
M test_build.sh
1 file changed, 58 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/00/68000/4
--
To view, visit https://review.coreboot.org/c/flashrom/+/68000
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.0.x
Gerrit-Change-Id: I3bacb3ba9c6708f1e7ef5a111290d0ea3af36f1d
Gerrit-Change-Number: 68000
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Anastasia Klimchuk.
Hello build bot (Jenkins), Patrick Georgi, Anastasia Klimchuk,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/68002
to look at the new patch set (#2).
Change subject: test_build.sh: Identify runs for Coverity Scan
......................................................................
test_build.sh: Identify runs for Coverity Scan
For Coverity Scan[0] the same build rules apply as for scan-build.
[0] https://scan.coverity.com/projects/flashrom
Change-Id: I75147799b1c3213866e343a0384c94d0a1f5c249
Signed-off-by: Patrick Georgi <pgeorgi(a)google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/67739
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Felix Singer <felixsinger(a)posteo.net>
Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org>
---
M test_build.sh
1 file changed, 19 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/02/68002/2
--
To view, visit https://review.coreboot.org/c/flashrom/+/68002
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.0.x
Gerrit-Change-Id: I75147799b1c3213866e343a0384c94d0a1f5c249
Gerrit-Change-Number: 68002
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: newpatchset
Hello build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/68003
to look at the new patch set (#2).
Change subject: test_build.sh: Improve robustness when dealing with empty $CC
......................................................................
test_build.sh: Improve robustness when dealing with empty $CC
Add quotes so that = knows what to compare, otherwise the shell
complains:
./test_build.sh: 16: [: =: unexpected operator
Change-Id: Ia289b31291949f5cbc11484b8f1a7cb7a49bd2bb
Signed-off-by: Patrick Georgi <pgeorgi(a)google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/67740
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Felix Singer <felixsinger(a)posteo.net>
---
M test_build.sh
1 file changed, 19 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/03/68003/2
--
To view, visit https://review.coreboot.org/c/flashrom/+/68003
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.0.x
Gerrit-Change-Id: Ia289b31291949f5cbc11484b8f1a7cb7a49bd2bb
Gerrit-Change-Number: 68003
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen, Angel Pons.
Hello build bot (Jenkins), Nico Huber, Thomas Heijligen, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/68001
to look at the new patch set (#4).
Change subject: test_build.sh: Use multiple cores if Make is used
......................................................................
test_build.sh: Use multiple cores if Make is used
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
Change-Id: Ia67e9202e49f1b4bc3301399a8ec741ac01c3ce0
Reviewed-on: https://review.coreboot.org/c/flashrom/+/67244
Reviewed-by: Thomas Heijligen <src(a)posteo.de>
Reviewed-by: Nico Huber <nico.h(a)gmx.de>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Angel Pons <th3fanbus(a)gmail.com>
---
M test_build.sh
1 file changed, 16 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/01/68001/4
--
To view, visit https://review.coreboot.org/c/flashrom/+/68001
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.0.x
Gerrit-Change-Id: Ia67e9202e49f1b4bc3301399a8ec741ac01c3ce0
Gerrit-Change-Number: 68001
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Thomas Heijligen, Angel Pons.
Hello build bot (Jenkins), Thomas Heijligen, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/68011
to look at the new patch set (#3).
Change subject: Makefile: Fix dependencies for developerbox_spi
......................................................................
Makefile: Fix dependencies for developerbox_spi
Note: This patch was backported from the master branch and it was
modified so that it can be applied on the 1.1.x branch.
The developerbox_spi programmer depends on bitbang SPI support. Thus,
fix that.
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
Change-Id: Ic0fe589ffdccede0fbf6360c2bebe58a36654f10
Reviewed-on: https://review.coreboot.org/c/flashrom/+/66096
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Angel Pons <th3fanbus(a)gmail.com>
Reviewed-by: Thomas Heijligen <src(a)posteo.de>
---
M Makefile
M programmer.h
2 files changed, 25 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/11/68011/3
--
To view, visit https://review.coreboot.org/c/flashrom/+/68011
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.1.x
Gerrit-Change-Id: Ic0fe589ffdccede0fbf6360c2bebe58a36654f10
Gerrit-Change-Number: 68011
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen, Anastasia Klimchuk.
Hello build bot (Jenkins), Nico Huber, Thomas Heijligen, Anastasia Klimchuk,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/68006
to look at the new patch set (#8).
Change subject: test_build.sh: Build all programmers individually using Make
......................................................................
test_build.sh: Build all programmers individually using Make
Note: This patch was backported from the master branch and it was
modified so that it can be applied on the 1.1.x branch.
While testing CB:63724, which reworks the Meson build system, it showed
that some programmers have dependency issues, which were invisible since
test_build.sh builds flashrom with all programmers enabled and thus all
sources are included. Building flashrom with each programmer
individually made these issues visible.
However, as commit 877b7741fcf9 and commit b6a439e45ef2 show, the Make
build system also had some similar issues, which were invisible for the
same reason.
Thus, in addition to building all programmers at once using the Make
build system, build each programmer individually.
Also, when clang analyzer is used, it's not needed to run it on each
programmer individually. Just return after flashrom was built with all
programmers enabled in this case.
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
Change-Id: I3bacb3ba9c6708f1e7ef5a111290d0ea3af36f1d
Reviewed-on: https://review.coreboot.org/c/flashrom/+/66094
Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Thomas Heijligen <src(a)posteo.de>
Reviewed-by: Nico Huber <nico.h(a)gmx.de>
---
M test_build.sh
1 file changed, 59 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/06/68006/8
--
To view, visit https://review.coreboot.org/c/flashrom/+/68006
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.1.x
Gerrit-Change-Id: I3bacb3ba9c6708f1e7ef5a111290d0ea3af36f1d
Gerrit-Change-Number: 68006
Gerrit-PatchSet: 8
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Singer, Anastasia Klimchuk.
Hello build bot (Jenkins), Patrick Georgi, Anastasia Klimchuk,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/68007
to look at the new patch set (#8).
Change subject: test_build.sh: Identify runs for Coverity Scan
......................................................................
test_build.sh: Identify runs for Coverity Scan
For Coverity Scan[0] the same build rules apply as for scan-build.
[0] https://scan.coverity.com/projects/flashrom
Change-Id: I75147799b1c3213866e343a0384c94d0a1f5c249
Signed-off-by: Patrick Georgi <pgeorgi(a)google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/67739
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Felix Singer <felixsinger(a)posteo.net>
Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org>
---
M test_build.sh
1 file changed, 19 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/07/68007/8
--
To view, visit https://review.coreboot.org/c/flashrom/+/68007
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.1.x
Gerrit-Change-Id: I75147799b1c3213866e343a0384c94d0a1f5c249
Gerrit-Change-Number: 68007
Gerrit-PatchSet: 8
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Singer.
Hello build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/68008
to look at the new patch set (#8).
Change subject: test_build.sh: Improve robustness when dealing with empty $CC
......................................................................
test_build.sh: Improve robustness when dealing with empty $CC
Add quotes so that = knows what to compare, otherwise the shell
complains:
./test_build.sh: 16: [: =: unexpected operator
Change-Id: Ia289b31291949f5cbc11484b8f1a7cb7a49bd2bb
Signed-off-by: Patrick Georgi <pgeorgi(a)google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/67740
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Felix Singer <felixsinger(a)posteo.net>
---
M test_build.sh
1 file changed, 19 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/08/68008/8
--
To view, visit https://review.coreboot.org/c/flashrom/+/68008
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.1.x
Gerrit-Change-Id: Ia289b31291949f5cbc11484b8f1a7cb7a49bd2bb
Gerrit-Change-Number: 68008
Gerrit-PatchSet: 8
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-MessageType: newpatchset