Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen, Anastasia Klimchuk.
Hello build bot (Jenkins), Nico Huber, Thomas Heijligen, Anastasia Klimchuk,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/68006
to look at the new patch set (#5).
Change subject: test_build.sh: Build all programmers individually using Make
......................................................................
test_build.sh: Build all programmers individually using Make
While testing CB:63724, which reworks the Meson build system, it showed
that some programmers have dependency issues, which were invisible since
test_build.sh builds flashrom with all programmers enabled and thus all
sources are included. Building flashrom with each programmer
individually made these issues visible.
However, as commit 877b7741fcf9 and commit b6a439e45ef2 show, the Make
build system also had some similar issues, which were invisible for the
same reason.
Thus, in addition to building all programmers at once using the Make
build system, build each programmer individually.
Also, when clang analyzer is used, it's not needed to run it on each
programmer individually. Just return after flashrom was built with all
programmers enabled in this case.
An equivalent patch for the Meson build system is made separately.
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
Change-Id: I3bacb3ba9c6708f1e7ef5a111290d0ea3af36f1d
Reviewed-on: https://review.coreboot.org/c/flashrom/+/66094
Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Thomas Heijligen <src(a)posteo.de>
Reviewed-by: Nico Huber <nico.h(a)gmx.de>
---
M test_build.sh
1 file changed, 58 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/06/68006/5
--
To view, visit https://review.coreboot.org/c/flashrom/+/68006
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.1.x
Gerrit-Change-Id: I3bacb3ba9c6708f1e7ef5a111290d0ea3af36f1d
Gerrit-Change-Number: 68006
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Singer, Patrick Georgi, Anastasia Klimchuk.
Hello build bot (Jenkins), Patrick Georgi, Anastasia Klimchuk,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/68007
to look at the new patch set (#5).
Change subject: test_build.sh: Identify runs for Coverity Scan
......................................................................
test_build.sh: Identify runs for Coverity Scan
For Coverity Scan[0] the same build rules apply as for scan-build.
[0] https://scan.coverity.com/projects/flashrom
Change-Id: I75147799b1c3213866e343a0384c94d0a1f5c249
Signed-off-by: Patrick Georgi <pgeorgi(a)google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/67739
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Felix Singer <felixsinger(a)posteo.net>
Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org>
---
M test_build.sh
1 file changed, 19 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/07/68007/5
--
To view, visit https://review.coreboot.org/c/flashrom/+/68007
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.1.x
Gerrit-Change-Id: I75147799b1c3213866e343a0384c94d0a1f5c249
Gerrit-Change-Number: 68007
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Singer, Patrick Georgi.
Hello build bot (Jenkins), Patrick Georgi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/68008
to look at the new patch set (#5).
Change subject: test_build.sh: Improve robustness when dealing with empty $CC
......................................................................
test_build.sh: Improve robustness when dealing with empty $CC
Add quotes so that = knows what to compare, otherwise the shell
complains:
./test_build.sh: 16: [: =: unexpected operator
Change-Id: Ia289b31291949f5cbc11484b8f1a7cb7a49bd2bb
Signed-off-by: Patrick Georgi <pgeorgi(a)google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/67740
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Felix Singer <felixsinger(a)posteo.net>
---
M test_build.sh
1 file changed, 19 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/08/68008/5
--
To view, visit https://review.coreboot.org/c/flashrom/+/68008
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.1.x
Gerrit-Change-Id: Ia289b31291949f5cbc11484b8f1a7cb7a49bd2bb
Gerrit-Change-Number: 68008
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen, Angel Pons.
Hello build bot (Jenkins), Nico Huber, Thomas Heijligen, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/68009
to look at the new patch set (#5).
Change subject: test_build.sh: Use multiple cores if Make is used
......................................................................
test_build.sh: Use multiple cores if Make is used
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
Change-Id: Ia67e9202e49f1b4bc3301399a8ec741ac01c3ce0
Reviewed-on: https://review.coreboot.org/c/flashrom/+/67244
Reviewed-by: Thomas Heijligen <src(a)posteo.de>
Reviewed-by: Nico Huber <nico.h(a)gmx.de>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Angel Pons <th3fanbus(a)gmail.com>
---
M test_build.sh
1 file changed, 16 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/09/68009/5
--
To view, visit https://review.coreboot.org/c/flashrom/+/68009
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.1.x
Gerrit-Change-Id: Ia67e9202e49f1b4bc3301399a8ec741ac01c3ce0
Gerrit-Change-Number: 68009
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Thomas Heijligen.
Hello build bot (Jenkins), Thomas Heijligen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/68010
to look at the new patch set (#3).
Change subject: [WIP] Makefile: Fix developerbox spi programmer dependencies
......................................................................
[WIP] Makefile: Fix developerbox spi programmer dependencies
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
Change-Id: I55dd4a0faeb40f1f2cea75796db131c4b3dc2890
---
M Makefile
M programmer.h
2 files changed, 15 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/10/68010/3
--
To view, visit https://review.coreboot.org/c/flashrom/+/68010
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.1.x
Gerrit-Change-Id: I55dd4a0faeb40f1f2cea75796db131c4b3dc2890
Gerrit-Change-Number: 68010
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Thomas Heijligen.
Hello build bot (Jenkins), Thomas Heijligen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/68010
to look at the new patch set (#2).
Change subject: [WIP] Makefile: Fix developerbox spi programmer dependencies
......................................................................
[WIP] Makefile: Fix developerbox spi programmer dependencies
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
Change-Id: I55dd4a0faeb40f1f2cea75796db131c4b3dc2890
---
M Makefile
1 file changed, 14 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/10/68010/2
--
To view, visit https://review.coreboot.org/c/flashrom/+/68010
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.1.x
Gerrit-Change-Id: I55dd4a0faeb40f1f2cea75796db131c4b3dc2890
Gerrit-Change-Number: 68010
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Patrick Georgi.
Hello build bot (Jenkins), Patrick Georgi,
I'd like you to do a code review.
Please visit
https://review.coreboot.org/c/flashrom/+/68008
to review the following change.
Change subject: test_build.sh: Improve robustness when dealing with empty $CC
......................................................................
test_build.sh: Improve robustness when dealing with empty $CC
Add quotes so that = knows what to compare, otherwise the shell
complains:
./test_build.sh: 16: [: =: unexpected operator
Change-Id: Ia289b31291949f5cbc11484b8f1a7cb7a49bd2bb
Signed-off-by: Patrick Georgi <pgeorgi(a)google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/67740
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Felix Singer <felixsinger(a)posteo.net>
---
M test_build.sh
1 file changed, 19 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/08/68008/1
diff --git a/test_build.sh b/test_build.sh
index d6d29ee..7a15c20 100755
--- a/test_build.sh
+++ b/test_build.sh
@@ -9,7 +9,7 @@
BUSPIRATE_SPI DEDIPROG DEVELOPERBOX_SPI SATAMV LINUX_MTD LINUX_SPI IT8212 \
CH341A_SPI DIGILENT_SPI JLINK_SPI"
-if [ $(basename "${CC}") = "ccc-analyzer" ] || [ -n "${COVERITY_OUTPUT}" ]; then
+if [ "$(basename "${CC}")" = "ccc-analyzer" ] || [ -n "${COVERITY_OUTPUT}" ]; then
is_scan_build_env=1
fi
--
To view, visit https://review.coreboot.org/c/flashrom/+/68008
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.1.x
Gerrit-Change-Id: Ia289b31291949f5cbc11484b8f1a7cb7a49bd2bb
Gerrit-Change-Number: 68008
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-MessageType: newchange
Attention is currently required from: Nico Huber, Thomas Heijligen, Angel Pons.
Hello build bot (Jenkins), Nico Huber, Thomas Heijligen, Angel Pons,
I'd like you to do a code review.
Please visit
https://review.coreboot.org/c/flashrom/+/68009
to review the following change.
Change subject: test_build.sh: Use multiple cores if Make is used
......................................................................
test_build.sh: Use multiple cores if Make is used
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
Change-Id: Ia67e9202e49f1b4bc3301399a8ec741ac01c3ce0
Reviewed-on: https://review.coreboot.org/c/flashrom/+/67244
Reviewed-by: Thomas Heijligen <src(a)posteo.de>
Reviewed-by: Nico Huber <nico.h(a)gmx.de>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Angel Pons <th3fanbus(a)gmail.com>
---
M test_build.sh
1 file changed, 16 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/09/68009/1
diff --git a/test_build.sh b/test_build.sh
index 7a15c20..9f80de8 100755
--- a/test_build.sh
+++ b/test_build.sh
@@ -25,5 +25,5 @@
for option in ${make_programmer_opts}; do
echo "Building ${option}"
make clean
- make CONFIG_NOTHING=yes CONFIG_${option}=yes
+ make -j $(nproc) CONFIG_NOTHING=yes CONFIG_${option}=yes
done
--
To view, visit https://review.coreboot.org/c/flashrom/+/68009
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.1.x
Gerrit-Change-Id: Ia67e9202e49f1b4bc3301399a8ec741ac01c3ce0
Gerrit-Change-Number: 68009
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: newchange