September 2022 - flashrom-gerrit

[S] Change in flashrom[1.0.x]: test_build.sh: Identify runs for Coverity Scan
by Felix Singer (Code Review) 29 Sep '22

29 Sep '22

Attention is currently required from: Patrick Georgi, Anastasia Klimchuk. Hello build bot (Jenkins), Patrick Georgi, Anastasia Klimchuk, I'd like you to do a code review. Please visit https://review.coreboot.org/c/flashrom/+/68002 to review the following change. Change subject: test_build.sh: Identify runs for Coverity Scan ...................................................................... test_build.sh: Identify runs for Coverity Scan For Coverity Scan[0] the same build rules apply as for scan-build. [0] https://scan.coverity.com/projects/flashrom Change-Id: I75147799b1c3213866e343a0384c94d0a1f5c249 Signed-off-by: Patrick Georgi <pgeorgi(a)google.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/67739 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> --- M test_build.sh 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/02/68002/1 diff --git a/test_build.sh b/test_build.sh index 886994f..6943701 100755 --- a/test_build.sh +++ b/test_build.sh @@ -8,7 +8,7 @@ DRKAISER NICREALTEK NICNATSEMI NICINTEL NICINTEL_SPI NICINTEL_EEPROM OGP_SPI \ BUSPIRATE_SPI DEDIPROG SATAMV LINUX_SPI IT8212 CH341A_SPI" -if [ $(basename "${CC}") = "ccc-analyzer" ]; then +if [ $(basename "${CC}") = "ccc-analyzer" ] || [ -n "${COVERITY_OUTPUT}" ]; then is_scan_build_env=1 fi -- To view, visit https://review.coreboot.org/c/flashrom/+/68002 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-Change-Id: I75147799b1c3213866e343a0384c94d0a1f5c249 Gerrit-Change-Number: 68002 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

[M] Change in flashrom[1.0.x]: test_build.sh: Build all programmers individually using Make
by Felix Singer (Code Review) 29 Sep '22

29 Sep '22

Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen, Anastasia Klimchuk. Hello build bot (Jenkins), Nico Huber, Thomas Heijligen, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/68000 to look at the new patch set (#3). Change subject: test_build.sh: Build all programmers individually using Make ...................................................................... test_build.sh: Build all programmers individually using Make While testing CB:63724, which reworks the Meson build system, it showed that some programmers have dependency issues, which were invisible since test_build.sh builds flashrom with all programmers enabled and thus all sources are included. Building flashrom with each programmer individually made these issues visible. However, as commit 877b7741fcf9 and commit b6a439e45ef2 show, the Make build system also had some similar issues, which were invisible for the same reason. Thus, in addition to building all programmers at once using the Make build system, build each programmer individually. Also, when clang analyzer is used, it's not needed to run it on each programmer individually. Just return after flashrom was built with all programmers enabled in this case. An equivalent patch for the Meson build system is made separately. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I3bacb3ba9c6708f1e7ef5a111290d0ea3af36f1d Reviewed-on: https://review.coreboot.org/c/flashrom/+/66094 Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Thomas Heijligen <src(a)posteo.de> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M test_build.sh 1 file changed, 57 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/00/68000/3 -- To view, visit https://review.coreboot.org/c/flashrom/+/68000 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-Change-Id: I3bacb3ba9c6708f1e7ef5a111290d0ea3af36f1d Gerrit-Change-Number: 68000 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[1.0.x]: test_build.sh: Build all programmers individually using Make
by Felix Singer (Code Review) 29 Sep '22

29 Sep '22

Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen, Anastasia Klimchuk. Hello build bot (Jenkins), Nico Huber, Thomas Heijligen, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/68000 to look at the new patch set (#2). Change subject: test_build.sh: Build all programmers individually using Make ...................................................................... test_build.sh: Build all programmers individually using Make While testing CB:63724, which reworks the Meson build system, it showed that some programmers have dependency issues, which were invisible since test_build.sh builds flashrom with all programmers enabled and thus all sources are included. Building flashrom with each programmer individually made these issues visible. However, as commit 877b7741fcf9 and commit b6a439e45ef2 show, the Make build system also had some similar issues, which were invisible for the same reason. Thus, in addition to building all programmers at once using the Make build system, build each programmer individually. Also, when clang analyzer is used, it's not needed to run it on each programmer individually. Just return after flashrom was built with all programmers enabled in this case. An equivalent patch for the Meson build system is made separately. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I3bacb3ba9c6708f1e7ef5a111290d0ea3af36f1d Reviewed-on: https://review.coreboot.org/c/flashrom/+/66094 Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Thomas Heijligen <src(a)posteo.de> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M test_build.sh 1 file changed, 45 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/00/68000/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/68000 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-Change-Id: I3bacb3ba9c6708f1e7ef5a111290d0ea3af36f1d Gerrit-Change-Number: 68000 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[1.0.x]: test_build.sh: Use multiple cores if Make is used
by Felix Singer (Code Review) 29 Sep '22

29 Sep '22

Attention is currently required from: Nico Huber, Thomas Heijligen, Angel Pons. Hello build bot (Jenkins), Nico Huber, Thomas Heijligen, Angel Pons, I'd like you to do a code review. Please visit https://review.coreboot.org/c/flashrom/+/68001 to review the following change. Change subject: test_build.sh: Use multiple cores if Make is used ...................................................................... test_build.sh: Use multiple cores if Make is used Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: Ia67e9202e49f1b4bc3301399a8ec741ac01c3ce0 Reviewed-on: https://review.coreboot.org/c/flashrom/+/67244 Reviewed-by: Thomas Heijligen <src(a)posteo.de> Reviewed-by: Nico Huber <nico.h(a)gmx.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> --- M test_build.sh 1 file changed, 16 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/01/68001/1 diff --git a/test_build.sh b/test_build.sh index f7118e0..48d5fa8 100755 --- a/test_build.sh +++ b/test_build.sh @@ -14,5 +14,5 @@ for option in ${make_programmer_opts}; do echo "Building ${option}" make clean - make CONFIG_NOTHING=yes CONFIG_${option}=yes + make -j $(nproc) CONFIG_NOTHING=yes CONFIG_${option}=yes done -- To view, visit https://review.coreboot.org/c/flashrom/+/68001 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-Change-Id: Ia67e9202e49f1b4bc3301399a8ec741ac01c3ce0 Gerrit-Change-Number: 68001 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[1.0.x]: test_build.sh: Build all programmers individually using Make
by Felix Singer (Code Review) 29 Sep '22

29 Sep '22

Attention is currently required from: Nico Huber, Thomas Heijligen, Anastasia Klimchuk. Hello build bot (Jenkins), Nico Huber, Thomas Heijligen, Anastasia Klimchuk, I'd like you to do a code review. Please visit https://review.coreboot.org/c/flashrom/+/68000 to review the following change. Change subject: test_build.sh: Build all programmers individually using Make ...................................................................... test_build.sh: Build all programmers individually using Make While testing CB:63724, which reworks the Meson build system, it showed that some programmers have dependency issues, which were invisible since test_build.sh builds flashrom with all programmers enabled and thus all sources are included. Building flashrom with each programmer individually made these issues visible. However, as commit 877b7741fcf9 and commit b6a439e45ef2 show, the Make build system also had some similar issues, which were invisible for the same reason. Thus, in addition to building all programmers at once using the Make build system, build each programmer individually. Also, when clang analyzer is used, it's not needed to run it on each programmer individually. Just return after flashrom was built with all programmers enabled in this case. An equivalent patch for the Meson build system is made separately. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I3bacb3ba9c6708f1e7ef5a111290d0ea3af36f1d Reviewed-on: https://review.coreboot.org/c/flashrom/+/66094 Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Thomas Heijligen <src(a)posteo.de> Reviewed-by: Nico Huber <nico.h(a)gmx.de> --- M test_build.sh 1 file changed, 47 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/00/68000/1 diff --git a/test_build.sh b/test_build.sh index 6cb902c..f7118e0 100755 --- a/test_build.sh +++ b/test_build.sh @@ -1,5 +1,18 @@ #!/bin/sh set -e +make_programmer_opts="INTERNAL INTERNAL_X86 SERPROG RAYER_SPI RAIDEN_DEBUG_SPI PONY_SPI NIC3COM \ + GFXNVIDIA SATASII ATAHPT ATAVIA ATAPROMISE FT2232_SPI USBBLASTER_SPI MSTARDDC_SPI \ + PICKIT2_SPI STLINKV3_SPI PARADE_LSPCON MEDIATEK_I2C_SPI REALTEK_MST_I2C_SPI DUMMY \ + DRKAISER NICREALTEK NICNATSEMI NICINTEL NICINTEL_SPI NICINTEL_EEPROM OGP_SPI \ + BUSPIRATE_SPI DEDIPROG DEVELOPERBOX_SPI SATAMV LINUX_MTD LINUX_SPI IT8212 \ + CH341A_SPI DIGILENT_SPI JLINK_SPI" + make clean make CONFIG_EVERYTHING=yes + +for option in ${make_programmer_opts}; do + echo "Building ${option}" + make clean + make CONFIG_NOTHING=yes CONFIG_${option}=yes +done -- To view, visit https://review.coreboot.org/c/flashrom/+/68000 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-Change-Id: I3bacb3ba9c6708f1e7ef5a111290d0ea3af36f1d Gerrit-Change-Number: 68000 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[1.0.x]: test_build.sh: Allow WARNERROR to be overridden
by Felix Singer (Code Review) 29 Sep '22

29 Sep '22

Attention is currently required from: Nico Huber, Martin L Roth. Hello build bot (Jenkins), Nico Huber, Martin L Roth, I'd like you to do a code review. Please visit https://review.coreboot.org/c/flashrom/+/67999 to review the following change. Change subject: test_build.sh: Allow WARNERROR to be overridden ...................................................................... test_build.sh: Allow WARNERROR to be overridden Currently, WARNERROR is hardcoded to 'yes' which is what we want most of the time, but there are cases (such as when building with -fanalyzer) that we don't want it enabled, so we see the entire output of the build, and it doesn't halt at the first error. Removing the WARNERROR line from the script allows the variable to be overridden from an environment variable. Signed-off-by: Martin Roth <gaumless(a)gmail.com> Change-Id: Iea931e57f2a6992762566dc3dbaae8bb8df5b226 Reviewed-on: https://review.coreboot.org/c/flashrom/+/62745 Reviewed-by: Felix Singer <felixsinger(a)posteo.net> Reviewed-by: Nico Huber <nico.h(a)gmx.de> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M test_build.sh 1 file changed, 22 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/99/67999/1 diff --git a/test_build.sh b/test_build.sh index 0064c8f..6cb902c 100755 --- a/test_build.sh +++ b/test_build.sh @@ -2,4 +2,4 @@ set -e make clean -make CONFIG_EVERYTHING=yes WARNERROR=yes +make CONFIG_EVERYTHING=yes -- To view, visit https://review.coreboot.org/c/flashrom/+/67999 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-Change-Id: Iea931e57f2a6992762566dc3dbaae8bb8df5b226 Gerrit-Change-Number: 67999 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in flashrom[1.0.x]: test_build.sh: Run `make clean` before compiling
by Felix Singer (Code Review) 29 Sep '22

29 Sep '22

Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67997 to look at the new patch set (#2). Change subject: test_build.sh: Run `make clean` before compiling ...................................................................... test_build.sh: Run `make clean` before compiling Run `make clean` before compiling to make sure the script starts from a clean environment. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I6a6f5a3483941148330b95936e1445f21a34061b --- M test_build.sh 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/97/67997/2 -- To view, visit https://review.coreboot.org/c/flashrom/+/67997 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: 1.0.x Gerrit-Change-Id: I6a6f5a3483941148330b95936e1445f21a34061b Gerrit-Change-Number: 67997 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[L] Change in flashrom[master]: drivers: Move (un)map_flash_region from programmer to par/spi_master
by Jonathon Hall (Code Review) 29 Sep '22

29 Sep '22

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Nikolai Artemiev. Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67695 ) Change subject: drivers: Move (un)map_flash_region from programmer to par/spi_master ...................................................................... Patch Set 7: (4 comments) Patchset: PS5: > I'll bring back the mappers for the SPI masters. […] I brought back the SPI master mappers, it was pretty straightforward. It looks like physmap is not needed for the other SPI masters (besides sb600 promontory and wbsio), but I left them unchanged since they weren't tested. I found a couple of AMD boards, I will need to check what chipsets they are but I should be able to test some of those next week. I didn't bring back mappers on opaque masters, the only one other than ICH hwseq that had a custom mapper was dummy, and it doesn't look like dummy needs it for opaque. PS5: > Yeah definitely, agree that would make this more incremental which would be great. […] Could you update those with the current master (minor merge conflicts) and separate them from CB:67393? (It looks like 67393 is blocked in review and I think these are independent.) File ichspi.c: https://review.coreboot.org/c/flashrom/+/67695/comment/125f71ed_ae590ce7 PS2, Line 1865: &mapper_phys > I don't think mapping is used here. As far as I know it is only used for the par_master in internal. […] The mapper is back for this SPI master now, I don't think it is needed but I'll leave that to be changed separately when it can be tested. File serprog.c: https://review.coreboot.org/c/flashrom/+/67695/comment/4a8bedaf_437e65cc PS5, Line 919: 1024 > Ack We have `MiB` too apparently! Done -- To view, visit https://review.coreboot.org/c/flashrom/+/67695 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9c3df6ae260bcdb246dfb0cd8e043919609b014b Gerrit-Change-Number: 67695 Gerrit-PatchSet: 7 Gerrit-Owner: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Comment-Date: Thu, 29 Sep 2022 21:37:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Thomas Heijligen <src(a)posteo.de> Comment-In-Reply-To: Edward O'Callaghan <quasisec(a)chromium.org> Comment-In-Reply-To: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-MessageType: comment

1 0

[L] Change in flashrom[master]: drivers: Move (un)map_flash_region from programmer to par/spi_master
by Jonathon Hall (Code Review) 29 Sep '22

29 Sep '22

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Jonathon Hall, Nikolai Artemiev. Hello build bot (Jenkins), Edward O'Callaghan, Angel Pons, Nikolai Artemiev, Peter Marheine, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67695 to look at the new patch set (#7). Change subject: drivers: Move (un)map_flash_region from programmer to par/spi_master ...................................................................... drivers: Move (un)map_flash_region from programmer to par/spi_master Move (un)map_flash_region function pointers from programmer_entry to par_master and spi_master. Some programmers (internal) need to specify different mappers per bus master, and no opaque masters require a mapper. Mapping is closely tied to the way the memory is accessed using the other functions in par_master/spi_master. ICH SPI internal programming now works with flash >16 MB. Previously it would fail due to attempting to mmap 32 MB or more, which is not possible as only the top 16 MB of flash is mapped into the address space. Validate that FWH/LPC programmers provide specialized mapping in register_par_master(); this is needed for chips with FEATURE_REGISTERMAP, which only exist on FWH or LPC buses. dummyflasher.c: Use dummy mapper for parallel buses only. internal.c: Use physmap for parallel and SPI masters only (not opaque master). physmap is needed for parallel masters, promontory SPI, and wbsio SPI. Fallback must be used for ICH opaque master to allow use >16 MB flash. physmap is probably unneeded for other SPI masters but is preserveded since they were not tested. serprog.c: Replace mapper hack for 16 MB limit with max_rom_decode. programmer.c: Update comment in fallback_map(), NULL return is the desired behavior. Change-Id: I9c3df6ae260bcdb246dfb0cd8e043919609b014b Signed-off-by: Jonathon Hall <jonathon.hall(a)puri.sm> --- M atahpt.c M atapromise.c M atavia.c M buspirate_spi.c M ch341a_spi.c M dediprog.c M developerbox_spi.c M digilent_spi.c M drkaiser.c M dummyflasher.c M flashrom.c M ft2232_spi.c M gfxnvidia.c M hwaccess_physmap.c M ichspi.c M include/flash.h M include/hwaccess_physmap.h M include/programmer.h M internal.c M it8212.c M it87spi.c M jlink_spi.c M linux_mtd.c M linux_spi.c M mediatek_i2c_spi.c M mstarddc_spi.c M ni845x_spi.c M nic3com.c M nicintel.c M nicintel_eeprom.c M nicintel_spi.c M nicnatsemi.c M nicrealtek.c M ogp_spi.c M parade_lspcon.c M parallel.c M pickit2_spi.c M pony_spi.c M programmer.c M raiden_debug_spi.c M rayer_spi.c M realtek_mst_i2c_spi.c M satamv.c M satasii.c M sb600spi.c M serprog.c M stlinkv3_spi.c M usbblaster_spi.c M wbsio_spi.c 49 files changed, 143 insertions(+), 116 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/95/67695/7 -- To view, visit https://review.coreboot.org/c/flashrom/+/67695 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9c3df6ae260bcdb246dfb0cd8e043919609b014b Gerrit-Change-Number: 67695 Gerrit-PatchSet: 7 Gerrit-Owner: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: newpatchset

1 0

[L] Change in flashrom[master]: drivers: Move (un)map_flash_region from programmer to par/spi_master
by Jonathon Hall (Code Review) 29 Sep '22

29 Sep '22

Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Nikolai Artemiev. Hello build bot (Jenkins), Edward O'Callaghan, Angel Pons, Nikolai Artemiev, Peter Marheine, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67695 to look at the new patch set (#6). Change subject: drivers: Move (un)map_flash_region from programmer to par/spi_master ...................................................................... drivers: Move (un)map_flash_region from programmer to par/spi_master Move (un)map_flash_region function pointers from programmer_entry to par_master and spi_master. Some programmers (internal) need to specify different mappers per bus master, and no opaque masters require a mapper. Mapping is closely tied to the way the memory is accessed using the other functions in par_master/spi_master. ICH SPI internal programming now works with flash >16 MB. Previously it would fail due to attempting to mmap 32 MB or more, which is not possible as only the top 16 MB of flash is mapped into the address space. Validate that FWH/LPC programmers provide specialized mapping in register_par_master(); this is needed for chips with FEATURE_REGISTERMAP, which only exist on FWH or LPC buses. dummyflasher.c: Use dummy mapper for parallel buses only. internal.c: Use physmap for parallel and SPI masters only (not opaque master). physmap is needed for parallel masters, promontory SPI, and wbsio SPI. Fallback must be used for ICH opaque master to allow use >16 MB flash. physmap is probably unneeded for other SPI masters but is preserveded since they were not tested. serprog.c: Replace mapper hack for 16 MB limit with max_rom_decode. programmer.c: Update comment in fallback_map(), NULL return is the desired behavior. Change-Id: I9c3df6ae260bcdb246dfb0cd8e043919609b014b Signed-off-by: Jonathon Hall <jonathon.hall(a)puri.sm> --- M atahpt.c M atapromise.c M atavia.c M buspirate_spi.c M ch341a_spi.c M dediprog.c M developerbox_spi.c M digilent_spi.c M drkaiser.c M dummyflasher.c M flashrom.c M ft2232_spi.c M gfxnvidia.c M hwaccess_physmap.c M ichspi.c M include/flash.h M include/hwaccess_physmap.h M include/programmer.h M internal.c M it8212.c M it87spi.c M jlink_spi.c M linux_mtd.c M linux_spi.c M mediatek_i2c_spi.c M mstarddc_spi.c M ni845x_spi.c M nic3com.c M nicintel.c M nicintel_eeprom.c M nicintel_spi.c M nicnatsemi.c M nicrealtek.c M ogp_spi.c M parade_lspcon.c M parallel.c M pickit2_spi.c M pony_spi.c M programmer.c M raiden_debug_spi.c M rayer_spi.c M realtek_mst_i2c_spi.c M satamv.c M satasii.c M sb600spi.c M serprog.c M stlinkv3_spi.c M usbblaster_spi.c M wbsio_spi.c 49 files changed, 141 insertions(+), 116 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/95/67695/6 -- To view, visit https://review.coreboot.org/c/flashrom/+/67695 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I9c3df6ae260bcdb246dfb0cd8e043919609b014b Gerrit-Change-Number: 67695 Gerrit-PatchSet: 6 Gerrit-Owner: Jonathon Hall <jonathon.hall(a)puri.sm> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-Reviewer: Peter Marheine <pmarheine(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Nikolai Artemiev <nartemiev(a)google.com> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2022