Felix Singer has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/68005 )
Change subject: test_build.sh: Allow WARNERROR to be overridden
......................................................................
Abandoned
Lost interest. It takes too much effort to get trivial patches in
--
To view, visit https://review.coreboot.org/c/flashrom/+/68005
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.1.x
Gerrit-Change-Id: Iea931e57f2a6992762566dc3dbaae8bb8df5b226
Gerrit-Change-Number: 68005
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: abandon
Felix Singer has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/68004 )
Change subject: test_build.sh: Run `make clean` before compiling
......................................................................
Abandoned
Lost interest. It takes too much effort to get trivial patches in
--
To view, visit https://review.coreboot.org/c/flashrom/+/68004
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.1.x
Gerrit-Change-Id: I6a6f5a3483941148330b95936e1445f21a34061b
Gerrit-Change-Number: 68004
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: abandon
Felix Singer has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/68001 )
Change subject: test_build.sh: Use multiple cores if Make is used
......................................................................
Abandoned
Lost interest. It takes too much effort to get trivial patches in
--
To view, visit https://review.coreboot.org/c/flashrom/+/68001
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.0.x
Gerrit-Change-Id: Ia67e9202e49f1b4bc3301399a8ec741ac01c3ce0
Gerrit-Change-Number: 68001
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: abandon
Felix Singer has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/68003 )
Change subject: test_build.sh: Improve robustness when dealing with empty $CC
......................................................................
Abandoned
Lost interest. It takes too much effort to get trivial patches in
--
To view, visit https://review.coreboot.org/c/flashrom/+/68003
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.0.x
Gerrit-Change-Id: Ia289b31291949f5cbc11484b8f1a7cb7a49bd2bb
Gerrit-Change-Number: 68003
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-MessageType: abandon
Felix Singer has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/68002 )
Change subject: test_build.sh: Identify runs for Coverity Scan
......................................................................
Abandoned
Lost interest. It takes too much effort to get trivial patches in
--
To view, visit https://review.coreboot.org/c/flashrom/+/68002
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.0.x
Gerrit-Change-Id: I75147799b1c3213866e343a0384c94d0a1f5c249
Gerrit-Change-Number: 68002
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-MessageType: abandon
Felix Singer has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/68000 )
Change subject: test_build.sh: Build all programmers individually using Make
......................................................................
Abandoned
Lost interest. It takes too much time to get trivial patches in
--
To view, visit https://review.coreboot.org/c/flashrom/+/68000
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.0.x
Gerrit-Change-Id: I3bacb3ba9c6708f1e7ef5a111290d0ea3af36f1d
Gerrit-Change-Number: 68000
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: abandon
Felix Singer has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67999 )
Change subject: test_build.sh: Allow WARNERROR to be overridden
......................................................................
Abandoned
Lost interest. It takes too much time to get trivial patches in
--
To view, visit https://review.coreboot.org/c/flashrom/+/67999
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.0.x
Gerrit-Change-Id: Iea931e57f2a6992762566dc3dbaae8bb8df5b226
Gerrit-Change-Number: 67999
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: abandon
Felix Singer has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67997 )
Change subject: test_build.sh: Run `make clean` before compiling
......................................................................
Abandoned
Lost interest. It takes too much time to get trivial patches in
--
To view, visit https://review.coreboot.org/c/flashrom/+/67997
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.0.x
Gerrit-Change-Id: I6a6f5a3483941148330b95936e1445f21a34061b
Gerrit-Change-Number: 67997
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: abandon
Attention is currently required from: Felix Singer, Thomas Heijligen, Anastasia Klimchuk.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68000 )
Change subject: test_build.sh: Build all programmers individually using Make
......................................................................
Patch Set 4: Code-Review-1
(1 comment)
Patchset:
PS4:
The question if we should fix anything found this way on an old release branch
aside, we'd only have to run it once. We shouldn't do any changes that could
cause a regression again. So this would just waste processor cycles.
--
To view, visit https://review.coreboot.org/c/flashrom/+/68000
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.0.x
Gerrit-Change-Id: I3bacb3ba9c6708f1e7ef5a111290d0ea3af36f1d
Gerrit-Change-Number: 68000
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Fri, 30 Sep 2022 20:13:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Martin L Roth.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67999 )
Change subject: test_build.sh: Allow WARNERROR to be overridden
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
Will the merge trigger scan-build automatically or is there anything else to do?
--
To view, visit https://review.coreboot.org/c/flashrom/+/67999
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.0.x
Gerrit-Change-Id: Iea931e57f2a6992762566dc3dbaae8bb8df5b226
Gerrit-Change-Number: 67999
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Fri, 30 Sep 2022 20:10:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment