Felix Singer has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/68003 )
Change subject: test_build.sh: Improve robustness when dealing with empty $CC
......................................................................
Abandoned
Lost interest. It takes too much effort to get trivial patches in
--
To view, visit https://review.coreboot.org/c/flashrom/+/68003
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.0.x
Gerrit-Change-Id: Ia289b31291949f5cbc11484b8f1a7cb7a49bd2bb
Gerrit-Change-Number: 68003
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-MessageType: abandon
Felix Singer has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/68002 )
Change subject: test_build.sh: Identify runs for Coverity Scan
......................................................................
Abandoned
Lost interest. It takes too much effort to get trivial patches in
--
To view, visit https://review.coreboot.org/c/flashrom/+/68002
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.0.x
Gerrit-Change-Id: I75147799b1c3213866e343a0384c94d0a1f5c249
Gerrit-Change-Number: 68002
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org>
Gerrit-MessageType: abandon
Felix Singer has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/68000 )
Change subject: test_build.sh: Build all programmers individually using Make
......................................................................
Abandoned
Lost interest. It takes too much time to get trivial patches in
--
To view, visit https://review.coreboot.org/c/flashrom/+/68000
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.0.x
Gerrit-Change-Id: I3bacb3ba9c6708f1e7ef5a111290d0ea3af36f1d
Gerrit-Change-Number: 68000
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: abandon
Felix Singer has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67999 )
Change subject: test_build.sh: Allow WARNERROR to be overridden
......................................................................
Abandoned
Lost interest. It takes too much time to get trivial patches in
--
To view, visit https://review.coreboot.org/c/flashrom/+/67999
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.0.x
Gerrit-Change-Id: Iea931e57f2a6992762566dc3dbaae8bb8df5b226
Gerrit-Change-Number: 67999
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: abandon
Felix Singer has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/67997 )
Change subject: test_build.sh: Run `make clean` before compiling
......................................................................
Abandoned
Lost interest. It takes too much time to get trivial patches in
--
To view, visit https://review.coreboot.org/c/flashrom/+/67997
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.0.x
Gerrit-Change-Id: I6a6f5a3483941148330b95936e1445f21a34061b
Gerrit-Change-Number: 67997
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-MessageType: abandon
Attention is currently required from: Felix Singer, Thomas Heijligen, Anastasia Klimchuk.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68000 )
Change subject: test_build.sh: Build all programmers individually using Make
......................................................................
Patch Set 4: Code-Review-1
(1 comment)
Patchset:
PS4:
The question if we should fix anything found this way on an old release branch
aside, we'd only have to run it once. We shouldn't do any changes that could
cause a regression again. So this would just waste processor cycles.
--
To view, visit https://review.coreboot.org/c/flashrom/+/68000
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.0.x
Gerrit-Change-Id: I3bacb3ba9c6708f1e7ef5a111290d0ea3af36f1d
Gerrit-Change-Number: 68000
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Anastasia Klimchuk <aklm(a)chromium.org>
Gerrit-Comment-Date: Fri, 30 Sep 2022 20:13:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Martin L Roth.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67999 )
Change subject: test_build.sh: Allow WARNERROR to be overridden
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
Will the merge trigger scan-build automatically or is there anything else to do?
--
To view, visit https://review.coreboot.org/c/flashrom/+/67999
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.0.x
Gerrit-Change-Id: Iea931e57f2a6992762566dc3dbaae8bb8df5b226
Gerrit-Change-Number: 67999
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Comment-Date: Fri, 30 Sep 2022 20:10:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67997 )
Change subject: test_build.sh: Run `make clean` before compiling
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Does this fix anything? `make` should know what to do. It could only fail if
there are bigger changes to the build system that we shouldn't do on a release
branch anyway.
--
To view, visit https://review.coreboot.org/c/flashrom/+/67997
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: 1.0.x
Gerrit-Change-Id: I6a6f5a3483941148330b95936e1445f21a34061b
Gerrit-Change-Number: 67997
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Comment-Date: Fri, 30 Sep 2022 20:07:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Shreeyash .
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66225 )
Change subject: stlinkv3_spi: Bug fix, Initialize uninitialized pointers
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
@Shreeyash Are you still interested in getting this done?
--
To view, visit https://review.coreboot.org/c/flashrom/+/66225
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7ce156a9f7455434ea461560320c84660c93c02f
Gerrit-Change-Number: 66225
Gerrit-PatchSet: 2
Gerrit-Owner: Shreeyash <shreeyash335(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Shreeyash <shreeyash335(a)gmail.com>
Gerrit-Comment-Date: Fri, 30 Sep 2022 17:45:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Thomas Heijligen, Jean THOMAS, Alexander Goncharov.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67878 )
Change subject: dirtyjtag: Add DirtyJTAG programmer
......................................................................
Patch Set 7: Code-Review+1
(4 comments)
Patchset:
PS7:
Thanks for your update. Alas, I missed to check the resource usage/cleanup in
the init function. Everything else looks good to me :)
Also something else I kept forgetting to mention: We have some additional, annoying
programmer lists in `test_build.sh`. You should add yours there too.
File dirtyjtag_spi.c:
https://review.coreboot.org/c/flashrom/+/67878/comment/321761d6_c989c674
PS7, Line 154: 32
Just curious, is there anything in the last two bytes?
https://review.coreboot.org/c/flashrom/+/67878/comment/d45918d2_18f25575
PS7, Line 212: NULL
Should use the `djtag_data->libusb_ctx`. Many more below, too.
https://review.coreboot.org/c/flashrom/+/67878/comment/be295205_640c7791
PS7, Line 297: return -1;
Sorry, I always forget to check such cleanup paths ._.
There are some steps missing (I guess it should do about the same as
the shutdown function). However, not everything should be called on every
error. For instance, calling libusb_close() before `handle` is set might
be bad. Hence we'll need more labels.
Also, all early returns should go through a cleanup path. Except the
first maybe, because there no resources have been allocated yet.
--
To view, visit https://review.coreboot.org/c/flashrom/+/67878
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ic43e9a014ed7d04e429e73b30c9dcfdde1a78913
Gerrit-Change-Number: 67878
Gerrit-PatchSet: 7
Gerrit-Owner: Jean THOMAS <virgule(a)jeanthomas.me>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Jean THOMAS <virgule(a)jeanthomas.me>
Gerrit-Attention: Alexander Goncharov <chat(a)joursoir.net>
Gerrit-Comment-Date: Fri, 30 Sep 2022 13:35:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment