September 2022 - flashrom-gerrit

[S] Change in flashrom[master]: test_build.sh: Use multiple cores if Make is used
by Felix Singer (Code Review) 23 Sep '22

23 Sep '22

Attention is currently required from: Thomas Heijligen, Angel Pons. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67244 ) Change subject: test_build.sh: Use multiple cores if Make is used ...................................................................... Patch Set 10: (1 comment) Patchset: PS10: > I'd complain that some people may want to specify the number of threads, but Meson already hardcodes […] Sounds good 👍 -- To view, visit https://review.coreboot.org/c/flashrom/+/67244 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia67e9202e49f1b4bc3301399a8ec741ac01c3ce0 Gerrit-Change-Number: 67244 Gerrit-PatchSet: 10 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 23 Sep 2022 20:42:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: comment

1 0

[M] Change in flashrom[master]: test_build.sh: Build all programmers individually using Meson
by Felix Singer (Code Review) 23 Sep '22

23 Sep '22

Felix Singer has submitted this change. ( https://review.coreboot.org/c/flashrom/+/66475 ) Change subject: test_build.sh: Build all programmers individually using Meson ...................................................................... test_build.sh: Build all programmers individually using Meson The test build script already builds each programmer individually when Make is used. To check if the Meson build system is working properly, build each programmer individually and in addition to that build-test the programmer groups individually. Builds are done in the directory `out`, while for each build a new subdirectory with the name of the programmer option is created. Also, return when scan-build is used and the group `all` isn't selected, since it's not needed to run scan-build in combination with the other options. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I703127a2dc31d316d3d1c842b5bcb0b22c39c0d4 Reviewed-on: https://review.coreboot.org/c/flashrom/+/66475 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Anastasia Klimchuk <aklm(a)chromium.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Patrick Georgi <patrick(a)coreboot.org> --- M test_build.sh 1 file changed, 50 insertions(+), 3 deletions(-) Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve Anastasia Klimchuk: Looks good to me, but someone else must approve diff --git a/test_build.sh b/test_build.sh index 8f48ba1..2ca8de5 100755 --- a/test_build.sh +++ b/test_build.sh @@ -12,6 +12,14 @@ BUSPIRATE_SPI DEDIPROG DEVELOPERBOX_SPI SATAMV LINUX_MTD LINUX_SPI IT8212 \ CH341A_SPI DIGILENT_SPI JLINK_SPI" +meson_programmer_opts="all auto group_ftdi group_i2c group_jlink group_pci group_serial group_usb \ + atahpt atapromise atavia buspirate_spi ch341a_spi dediprog developerbox_spi \ + digilent_spi drkaiser dummy ft2232_spi gfxnvidia internal it8212 \ + jlink_spi linux_mtd linux_spi parade_lspcon mediatek_i2c_spi mstarddc_spi \ + nic3com nicintel nicintel_eeprom nicintel_spi nicnatsemi nicrealtek \ + ogp_spi pickit2_spi pony_spi raiden_debug_spi rayer_spi realtek_mst_i2c_spi \ + satamv satasii serprog stlinkv3_spi usbblaster_spi" + if [ "$(basename "${CC}")" = "ccc-analyzer" ] || [ -n "${COVERITY_OUTPUT}" ]; then is_scan_build_env=1 @@ -38,12 +46,24 @@ build_meson () { build_dir=out + meson_opts="-Dtests=enabled" + ninja_opts="-j $(nproc)" rm -rf ${build_dir} - meson $build_dir -Dtests=enabled - ninja -C $build_dir - ninja -C $build_dir test + for programmer in ${meson_programmer_opts}; do + programmer_dir="${build_dir}/${programmer}" + + # In case of clang analyzer we don't want to run it on + # each programmer individually. Thus, just return here. + if [ ${is_scan_build_env} -eq 1 ] && [ "${programmer}" != "all" ]; then + return + fi + + meson ${programmer_dir} ${meson_opts} -Dprogrammer=${programmer} + ninja ${ninja_opts} -C ${programmer_dir} + ninja ${ninja_opts} -C ${programmer_dir} test + done } -- To view, visit https://review.coreboot.org/c/flashrom/+/66475 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I703127a2dc31d316d3d1c842b5bcb0b22c39c0d4 Gerrit-Change-Number: 66475 Gerrit-PatchSet: 16 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

[S] Change in flashrom[master]: test_build.sh: Build all programmers individually using Meson
by Patrick Georgi (Code Review) 23 Sep '22

23 Sep '22

Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66475 ) Change subject: test_build.sh: Build all programmers individually using Meson ...................................................................... Patch Set 15: Code-Review+2 (1 comment) File test_build.sh: https://review.coreboot.org/c/flashrom/+/66475/comment/519328ee_ea21f3b7 PS15, Line 57: # In case of clang analyzer we don't want to run it on > scan-build should only run for the programmer group "all". […] Ack -- To view, visit https://review.coreboot.org/c/flashrom/+/66475 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I703127a2dc31d316d3d1c842b5bcb0b22c39c0d4 Gerrit-Change-Number: 66475 Gerrit-PatchSet: 15 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Fri, 23 Sep 2022 20:35:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Patrick Georgi <patrick(a)coreboot.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: test_build.sh: Build all programmers individually using Meson
by Felix Singer (Code Review) 23 Sep '22

23 Sep '22

Attention is currently required from: Nico Huber, Patrick Georgi, Thomas Heijligen. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66475 ) Change subject: test_build.sh: Build all programmers individually using Meson ...................................................................... Patch Set 15: (1 comment) File test_build.sh: https://review.coreboot.org/c/flashrom/+/66475/comment/378761bb_6a0c2036 PS15, Line 57: # In case of clang analyzer we don't want to run it on > Why put this in the loop instead of in front of it? scan-build should only run for the programmer group "all". If it's put before the loop, the build commands would have to be duplicated so that "all" can be separated. I wanted to avoid that and I didn't find another way than doing this. -- To view, visit https://review.coreboot.org/c/flashrom/+/66475 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I703127a2dc31d316d3d1c842b5bcb0b22c39c0d4 Gerrit-Change-Number: 66475 Gerrit-PatchSet: 15 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Fri, 23 Sep 2022 18:56:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi <patrick(a)coreboot.org> Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: test_build.sh: Build all programmers individually using Meson
by Angel Pons (Code Review) 23 Sep '22

23 Sep '22

Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66475 ) Change subject: test_build.sh: Build all programmers individually using Meson ...................................................................... Patch Set 15: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/66475 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I703127a2dc31d316d3d1c842b5bcb0b22c39c0d4 Gerrit-Change-Number: 66475 Gerrit-PatchSet: 15 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Fri, 23 Sep 2022 18:53:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: test_build.sh: Use multiple cores if Make is used
by Angel Pons (Code Review) 23 Sep '22

23 Sep '22

Attention is currently required from: Felix Singer, Thomas Heijligen. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67244 ) Change subject: test_build.sh: Use multiple cores if Make is used ...................................................................... Patch Set 10: Code-Review+1 (1 comment) Patchset: PS10: I'd complain that some people may want to specify the number of threads, but Meson already hardcodes "all the threads" anyway. If anyone wants to change this, it can be done in a follow-up. -- To view, visit https://review.coreboot.org/c/flashrom/+/67244 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia67e9202e49f1b4bc3301399a8ec741ac01c3ce0 Gerrit-Change-Number: 67244 Gerrit-PatchSet: 10 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Comment-Date: Fri, 23 Sep 2022 18:36:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: test_build.sh: Build all programmers individually using Meson
by Patrick Georgi (Code Review) 23 Sep '22

23 Sep '22

Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen, Angel Pons. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66475 ) Change subject: test_build.sh: Build all programmers individually using Meson ...................................................................... Patch Set 15: (1 comment) File test_build.sh: https://review.coreboot.org/c/flashrom/+/66475/comment/ecc82811_c073b1bb PS15, Line 57: # In case of clang analyzer we don't want to run it on Why put this in the loop instead of in front of it? -- To view, visit https://review.coreboot.org/c/flashrom/+/66475 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I703127a2dc31d316d3d1c842b5bcb0b22c39c0d4 Gerrit-Change-Number: 66475 Gerrit-PatchSet: 15 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Patrick Georgi <patrick(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 23 Sep 2022 17:14:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: test_build.sh: Build all programmers individually using Meson
by Felix Singer (Code Review) 23 Sep '22

23 Sep '22

Attention is currently required from: Nico Huber, Thomas Heijligen, Angel Pons. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66475 ) Change subject: test_build.sh: Build all programmers individually using Meson ...................................................................... Patch Set 15: (1 comment) Patchset: PS15: +2 anyone? -- To view, visit https://review.coreboot.org/c/flashrom/+/66475 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I703127a2dc31d316d3d1c842b5bcb0b22c39c0d4 Gerrit-Change-Number: 66475 Gerrit-PatchSet: 15 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 23 Sep 2022 16:29:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[S] Change in flashrom[master]: test_build.sh: Use multiple cores if Make is used
by Felix Singer (Code Review) 23 Sep '22

23 Sep '22

Attention is currently required from: Felix Singer, Thomas Heijligen. Hello build bot (Jenkins), Nico Huber, Thomas Heijligen, Angel Pons, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/67244 to look at the new patch set (#10). Change subject: test_build.sh: Use multiple cores if Make is used ...................................................................... test_build.sh: Use multiple cores if Make is used Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: Ia67e9202e49f1b4bc3301399a8ec741ac01c3ce0 --- M test_build.sh 1 file changed, 12 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/44/67244/10 -- To view, visit https://review.coreboot.org/c/flashrom/+/67244 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: Ia67e9202e49f1b4bc3301399a8ec741ac01c3ce0 Gerrit-Change-Number: 67244 Gerrit-PatchSet: 10 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-MessageType: newpatchset

1 0

[S] Change in flashrom[master]: test_build.sh: Build all programmers individually using Meson
by Felix Singer (Code Review) 23 Sep '22

23 Sep '22

Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen, Angel Pons. Hello build bot (Jenkins), Nico Huber, Thomas Heijligen, Angel Pons, Anastasia Klimchuk, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/flashrom/+/66475 to look at the new patch set (#15). Change subject: test_build.sh: Build all programmers individually using Meson ...................................................................... test_build.sh: Build all programmers individually using Meson The test build script already builds each programmer individually when Make is used. To check if the Meson build system is working properly, build each programmer individually and in addition to that build-test the programmer groups individually. Builds are done in the directory `out`, while for each build a new subdirectory with the name of the programmer option is created. Also, return when scan-build is used and the group `all` isn't selected, since it's not needed to run scan-build in combination with the other options. Signed-off-by: Felix Singer <felixsinger(a)posteo.net> Change-Id: I703127a2dc31d316d3d1c842b5bcb0b22c39c0d4 --- M test_build.sh 1 file changed, 45 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/75/66475/15 -- To view, visit https://review.coreboot.org/c/flashrom/+/66475 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I703127a2dc31d316d3d1c842b5bcb0b22c39c0d4 Gerrit-Change-Number: 66475 Gerrit-PatchSet: 15 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Anastasia Klimchuk <aklm(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

2024

2023

2022

2021

2020

2019

2018

2017

flashrom-gerrit September 2022